All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jane Chu <jane.chu@oracle.com>
To: Dave Jiang <dave.jiang@intel.com>,
	vishal.l.verma@intel.com, dan.j.williams@intel.com
Cc: linux-nvdimm@lists.01.org
Subject: Re: [PATCH v8 05/12] ndctl: add support for sanitize dimm
Date: Wed, 16 Jan 2019 19:08:23 -0800	[thread overview]
Message-ID: <9f4a5a82-0eb3-e7c9-e1d1-0b7bff5c744d@oracle.com> (raw)
In-Reply-To: <154749642390.63704.15541084216631565368.stgit@djiang5-desk3.ch.intel.com>

Hi, Dave,

On 1/14/2019 12:07 PM, Dave Jiang wrote:
> Add support to secure erase to libndctl and also command line option
> of "sanitize-dimm" for ndctl. This will initiate the request to crypto
> erase a DIMM.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
>   Documentation/ndctl/Makefile.am             |    3 +-
>   Documentation/ndctl/ndctl-sanitize-dimm.txt |   38 ++++++++++++++++++++
>   ndctl/builtin.h                             |    1 +
>   ndctl/dimm.c                                |   52 +++++++++++++++++++++++++++
>   ndctl/lib/dimm.c                            |    8 ++++
>   ndctl/lib/keys.c                            |   21 +++++++++--
>   ndctl/lib/libndctl.sym                      |    2 +
>   ndctl/libndctl.h                            |    9 +++++
>   ndctl/ndctl.c                               |    1 +
>   9 files changed, 131 insertions(+), 4 deletions(-)
>   create mode 100644 Documentation/ndctl/ndctl-sanitize-dimm.txt
> 
> diff --git a/Documentation/ndctl/Makefile.am b/Documentation/ndctl/Makefile.am
> index a97f193d..bbea9674 100644
> --- a/Documentation/ndctl/Makefile.am
> +++ b/Documentation/ndctl/Makefile.am
> @@ -51,7 +51,8 @@ man1_MANS = \
>   	ndctl-enable-passphrase.1 \
>   	ndctl-update-passphrase.1 \
>   	ndctl-disable-passphrase.1 \
> -	ndctl-freeze-security.1
> +	ndctl-freeze-security.1 \
> +	ndctl-sanitize-dimm.1
>   
>   CLEANFILES = $(man1_MANS)
>   
> diff --git a/Documentation/ndctl/ndctl-sanitize-dimm.txt b/Documentation/ndctl/ndctl-sanitize-dimm.txt
> new file mode 100644
> index 00000000..79629964
> --- /dev/null
> +++ b/Documentation/ndctl/ndctl-sanitize-dimm.txt
> @@ -0,0 +1,38 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +ndctl-sanitize-dimm(1)
> +======================
> +
> +NAME
> +----
> +ndctl-sanitize-dimm - sanitize the data on the NVDIMM
> +
> +SYNOPSIS
> +--------
> +[verse]
> +'ndctl sanitize' <dimm> [<options>]

Did you actually mean
   'ndctl sanitize-dimm' <dimm> [<options>]
?

thanks!
-jane

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  parent reply	other threads:[~2019-01-17  3:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 20:06 [PATCH v8 00/12] ndctl: add security support Dave Jiang
2019-01-14 20:06 ` [PATCH v8 01/12] ndctl: add support for display security state Dave Jiang
2019-01-16  1:13   ` Dan Williams
2019-01-14 20:06 ` [PATCH v8 02/12] ndctl: add passphrase update to ndctl Dave Jiang
2019-01-16  1:56   ` Dan Williams
2019-01-16 17:43     ` Verma, Vishal L
2019-01-16 17:47       ` Dave Jiang
2019-01-14 20:06 ` [PATCH v8 03/12] ndctl: add disable security support Dave Jiang
2019-01-16  4:41   ` Dan Williams
2019-01-14 20:06 ` [PATCH v8 04/12] ndctl: add support for freeze security Dave Jiang
2019-01-16  4:53   ` Dan Williams
2019-01-14 20:07 ` [PATCH v8 05/12] ndctl: add support for sanitize dimm Dave Jiang
2019-01-16  5:08   ` Dan Williams
2019-01-17  3:08   ` Jane Chu [this message]
2019-01-17 16:58     ` Dave Jiang
2019-01-14 20:07 ` [PATCH v8 06/12] ndctl: add unit test for security ops (minus overwrite) Dave Jiang
2019-01-16  1:02   ` Vishal Verma
2019-01-14 20:07 ` [PATCH v8 07/12] ndctl: add modprobe conf file and load-keys ndctl command Dave Jiang
2019-01-14 20:07 ` [PATCH v8 08/12] ndctl: add overwrite operation support Dave Jiang
2019-01-14 20:07 ` [PATCH v8 09/12] ndctl: add wait-overwrite support Dave Jiang
2019-01-14 20:07 ` [PATCH v8 10/12] ndctl: master phassphrase management support Dave Jiang
2019-01-14 20:07 ` [PATCH v8 11/12] ndctl: add master secure erase support Dave Jiang
2019-01-14 20:07 ` [PATCH v8 12/12] ndctl: documentation for security and key management Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f4a5a82-0eb3-e7c9-e1d1-0b7bff5c744d@oracle.com \
    --to=jane.chu@oracle.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.