From: Anton Gerasimov <tossel@gmail.com>
To: Michal Simek <michal.simek@xilinx.com>, devicetree@vger.kernel.org
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk
Subject: Re: [PATCH] arm: dts: zynq: Add support for Z-turn board
Date: Wed, 7 Mar 2018 20:50:52 +0100 [thread overview]
Message-ID: <9f4e1cb8-1416-58df-398c-d1d3f29c006e@gmail.com> (raw)
In-Reply-To: <d61e039f-36c9-5da9-1471-d1bf83e0e578@xilinx.com>
Hi Michal,
thank you for the detailed review. I'm fixing most of the issues, I've
just got one note and one question.
> Do you really wants to have 3 leds doing heartbeat?
Actually it is one RGB package. But it's controlled through programmable
logic, so I'll just remove it, my bad.
>> + };
>> +
>> + usr_led1 {
>> + label = "usr_led1";
>> + gpios = <&gpio0 0x0 0x1>;
>> + default-state = "off";
>> + linux,default-trigger = "none";
> This is not the part of binding and I think it is useless anyway.
>
>> + };
>> +
>> + usr_led2 {
>> + label = "usr_led2";
>> + gpios = <&gpio0 0x9 0x1>;
>> + default-state = "off";
>> + linux,default-trigger = "none";
> ditto
These two are on the contrary real LEDs that are controlled by hardware
GPIO. You mean they don't belong here because user can control them with
GPIO interface?
Thanks,
Anton
next prev parent reply other threads:[~2018-03-07 19:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 21:30 [PATCH] arm: dts: zynq: Add support for Z-turn board tossel
2018-03-07 7:25 ` Michal Simek
2018-03-07 19:50 ` Anton Gerasimov [this message]
2018-03-08 6:47 ` Michal Simek
2018-03-12 20:05 ` [PATCHv2] " tossel
2018-03-13 12:47 ` Michal Simek
2018-03-28 14:17 ` [PATCHv3] " Anton Gerasimov
2018-04-04 6:56 ` Michal Simek
2018-07-17 13:49 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f4e1cb8-1416-58df-398c-d1d3f29c006e@gmail.com \
--to=tossel@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.