From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH v2 10/14] ravb: simplify link auto-negotiation by ethtool
Date: Fri, 6 Jul 2018 23:30:09 +0300
Message-ID: <9f62a026-2c88-cd88-2ea1-265c34ca4dd3@cogentembedded.com>
References: <20180704081245.7395-1-vladimir_zapolskiy@mentor.com>
 <20180704081612.7628-1-vladimir_zapolskiy@mentor.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Andrew Lunn <andrew@lunn.ch>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
        "David S . Miller" <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f67.google.com ([209.85.221.67]:36165 "EHLO
        mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754117AbeGFUaN (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 6 Jul 2018 16:30:13 -0400
Received: by mail-wr1-f67.google.com with SMTP id h9-v6so5270065wro.3
        for <netdev@vger.kernel.org>; Fri, 06 Jul 2018 13:30:13 -0700 (PDT)
In-Reply-To: <20180704081612.7628-1-vladimir_zapolskiy@mentor.com>
Content-Language: en-MW
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 07/04/2018 11:16 AM, Vladimir Zapolskiy wrote:

> There is no need to call a heavyweight phy_start_aneg() for phy
> auto-negotiation by ethtool, the phy is already initialized and
> link auto-negotiation is started by calling phy_start() from
> ravb_phy_start() when a network device is opened.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
[...]
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

MBR, Sergei