From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver Date: Fri, 24 Jan 2020 09:07:22 +0000 Message-ID: <9f73afdf-1e9a-cdbd-f972-a022d503ef51@nvidia.com> References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> <598fe377-5b95-d30a-eb64-89a645166d42@gmail.com> <3f51939d-cf4b-f69b-728a-7eb99bbae458@nvidia.com> <34ac1fd3-ae0f-07f2-555f-a55087a2c9dc@nvidia.com> <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> <0fc814c2-0dc6-7741-b954-463381ff7fb9@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko , Sameer Pujar Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 23/01/2020 15:16, Dmitry Osipenko wrote: > 23.01.2020 12:22, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> >> On 1/22/2020 9:57 PM, Dmitry Osipenko wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> 22.01.2020 14:52, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> On 22/01/2020 07:16, Sameer Pujar wrote: >>>> >>>> ... >>>> >>>>>>>>>>> +static int tegra210_i2s_remove(struct platform_device *pdev) >>>>>>>>>>> +{ >>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0 pm_runtime_disable(&pdev->dev); >>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0 if (!pm_runtime_status_suspended(&pde= v->dev)) >>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 tegra210_i2s_runtime_suspend(&pdev->dev); >>>>>>>>>> This breaks device's RPM refcounting if it was disabled in the >>>>>>>>>> active >>>>>>>>>> state. This code should be removed. At most you could warn >>>>>>>>>> about the >>>>>>>>>> unxpected RPM state here, but it shouldn't be necessary. >>>>>>>>> I guess this was added for safety and explicit suspend keeps cloc= k >>>>>>>>> disabled. >>>>>>>>> Not sure if ref-counting of the device matters when runtime PM is >>>>>>>>> disabled and device is removed. >>>>>>>>> I see few drivers using this way. >>>>>>>> It should matter (if I'm not missing something) because RPM should >>>>>>>> be in >>>>>>>> a wrecked state once you'll try to re-load the driver's module. >>>>>>>> Likely >>>>>>>> that those few other drivers are wrong. >>>>>>>> >>>>>>>> [snip] >>>>>>> Once the driver is re-loaded and RPM is enabled, I don't think it >>>>>>> would use >>>>>>> the same 'dev' and the corresponding ref count. Doesn't it use the >>>>>>> new >>>>>>> counters? >>>>>>> If RPM is not working for some reason, most likely it would be the >>>>>>> case >>>>>>> for other >>>>>>> devices. What best driver can do is probably do a force suspend >>>>>>> during >>>>>>> removal if >>>>>>> already not done. I would prefer to keep, since multiple drivers >>>>>>> still >>>>>>> have it, >>>>>>> unless there is a real harm in doing so. >>>>>> I took a closer look and looks like the counter actually should be >>>>>> reset. Still I don't think that it's a good practice to make changes >>>>>> underneath of RPM, it may strike back. >>>>> If RPM is broken, it probably would have been caught during device >>>>> usage. >>>>> I will remove explicit suspend here if no any concerns from other >>>>> folks. >>>>> Thanks. >>>> I recall that this was the preferred way of doing this from the RPM >>>> folks. Tegra30 I2S driver does the same and Stephen had pointed me to >>>> this as a reference. >>>> I believe that this is meant to ensure that the >>>> device is always powered-off regardless of it RPM is enabled or not an= d >>>> what the current state is. >>> Yes, it was kinda actual for the case of unavailable RPM. >> >>> Anyways, /I think/ variant like this should have been more preferred: >>> >>> if (!pm_runtime_enabled(&pdev->dev)) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tegra210_i2s_runtime_s= uspend(&pdev->dev); >>> else >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pm_runtime_disable(&pd= ev->dev); >> >> I think it looks to be similar to what is there already. >> >> pm_runtime_disable(&pdev->dev); // it would turn out to be a dummy call >> if !RPM >> if (!pm_runtime_status_suspended(&pdev->dev)) // it is true always if !R= PM >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tegra210_i2s_runtime_suspend(= &pdev->dev); >=20 > Maybe this is fine for !RPM, but not really fine in a case of enabled > RPM. Device could be in resumed state after pm_runtime_disable() if it > wasn't suspended before the disabling. I don't see any problem with this for the !RPM case. Jon --=20 nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6E03C2D0CE for ; Fri, 24 Jan 2020 09:07:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85E882071A for ; Fri, 24 Jan 2020 09:07:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="QwVgTRUk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729863AbgAXJHd (ORCPT ); Fri, 24 Jan 2020 04:07:33 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:8311 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725787AbgAXJHd (ORCPT ); Fri, 24 Jan 2020 04:07:33 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 24 Jan 2020 01:06:46 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 24 Jan 2020 01:07:32 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 24 Jan 2020 01:07:32 -0800 Received: from [10.21.133.51] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 24 Jan 2020 09:07:24 +0000 Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver To: Dmitry Osipenko , Sameer Pujar CC: , , , , , , , , , , , , , , References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> <598fe377-5b95-d30a-eb64-89a645166d42@gmail.com> <3f51939d-cf4b-f69b-728a-7eb99bbae458@nvidia.com> <34ac1fd3-ae0f-07f2-555f-a55087a2c9dc@nvidia.com> <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> <0fc814c2-0dc6-7741-b954-463381ff7fb9@nvidia.com> From: Jon Hunter Message-ID: <9f73afdf-1e9a-cdbd-f972-a022d503ef51@nvidia.com> Date: Fri, 24 Jan 2020 09:07:22 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1579856806; bh=7aoEWgOMrsENsyCSERE4iOvClQ10ZBvAeKGx7j04F0Y=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=QwVgTRUkTeKYuVdIF7IWb8Lx6v4QxDRL3CI5bRnrYOJwXFYDVgMmPs5XFiEQ0Qfk4 wqx0DGl28wvYoC4xC0tkZah++mlIsfR8UrL12MvIgBntdJ0oA57208JrBcXNZRb2xF bxrjLt4MAxLDlMn5/rcnn5er2CGH8stTdmDBAOImYAtrUnk2DOBgU7xWuuOyBrqesr rOkiqEckCbQJwpbwZgu+MuDnK2VVPRFAAitb253LPKwCb3SFyUV1vjYzXrw2hosS7R MZciu+P9Zy8jm+skB8HZ97Q2LK9OiU77dRSKfnIM4aQj72Mnb7bHsjN/hOgGr6jHGA KVmJjRE4Uf0dA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/01/2020 15:16, Dmitry Osipenko wrote: > 23.01.2020 12:22, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> >> On 1/22/2020 9:57 PM, Dmitry Osipenko wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> 22.01.2020 14:52, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> On 22/01/2020 07:16, Sameer Pujar wrote: >>>> >>>> ... >>>> >>>>>>>>>>> +static int tegra210_i2s_remove(struct platform_device *pdev) >>>>>>>>>>> +{ >>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0 pm_runtime_disable(&pdev->dev); >>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0 if (!pm_runtime_status_suspended(&pde= v->dev)) >>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 tegra210_i2s_runtime_suspend(&pdev->dev); >>>>>>>>>> This breaks device's RPM refcounting if it was disabled in the >>>>>>>>>> active >>>>>>>>>> state. This code should be removed. At most you could warn >>>>>>>>>> about the >>>>>>>>>> unxpected RPM state here, but it shouldn't be necessary. >>>>>>>>> I guess this was added for safety and explicit suspend keeps cloc= k >>>>>>>>> disabled. >>>>>>>>> Not sure if ref-counting of the device matters when runtime PM is >>>>>>>>> disabled and device is removed. >>>>>>>>> I see few drivers using this way. >>>>>>>> It should matter (if I'm not missing something) because RPM should >>>>>>>> be in >>>>>>>> a wrecked state once you'll try to re-load the driver's module. >>>>>>>> Likely >>>>>>>> that those few other drivers are wrong. >>>>>>>> >>>>>>>> [snip] >>>>>>> Once the driver is re-loaded and RPM is enabled, I don't think it >>>>>>> would use >>>>>>> the same 'dev' and the corresponding ref count. Doesn't it use the >>>>>>> new >>>>>>> counters? >>>>>>> If RPM is not working for some reason, most likely it would be the >>>>>>> case >>>>>>> for other >>>>>>> devices. What best driver can do is probably do a force suspend >>>>>>> during >>>>>>> removal if >>>>>>> already not done. I would prefer to keep, since multiple drivers >>>>>>> still >>>>>>> have it, >>>>>>> unless there is a real harm in doing so. >>>>>> I took a closer look and looks like the counter actually should be >>>>>> reset. Still I don't think that it's a good practice to make changes >>>>>> underneath of RPM, it may strike back. >>>>> If RPM is broken, it probably would have been caught during device >>>>> usage. >>>>> I will remove explicit suspend here if no any concerns from other >>>>> folks. >>>>> Thanks. >>>> I recall that this was the preferred way of doing this from the RPM >>>> folks. Tegra30 I2S driver does the same and Stephen had pointed me to >>>> this as a reference. >>>> I believe that this is meant to ensure that the >>>> device is always powered-off regardless of it RPM is enabled or not an= d >>>> what the current state is. >>> Yes, it was kinda actual for the case of unavailable RPM. >> >>> Anyways, /I think/ variant like this should have been more preferred: >>> >>> if (!pm_runtime_enabled(&pdev->dev)) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tegra210_i2s_runtime_s= uspend(&pdev->dev); >>> else >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pm_runtime_disable(&pd= ev->dev); >> >> I think it looks to be similar to what is there already. >> >> pm_runtime_disable(&pdev->dev); // it would turn out to be a dummy call >> if !RPM >> if (!pm_runtime_status_suspended(&pdev->dev)) // it is true always if !R= PM >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tegra210_i2s_runtime_suspend(= &pdev->dev); >=20 > Maybe this is fine for !RPM, but not really fine in a case of enabled > RPM. Device could be in resumed state after pm_runtime_disable() if it > wasn't suspended before the disabling. I don't see any problem with this for the !RPM case. Jon --=20 nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B4B5C2D0CE for ; Fri, 24 Jan 2020 09:08:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88EF82071A for ; Fri, 24 Jan 2020 09:08:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="CP0qgRUE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="QwVgTRUk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88EF82071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C3AE4166C; Fri, 24 Jan 2020 10:07:40 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C3AE4166C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579856910; bh=NcGkf0PE5e1m32HCwcT/1TWBHdjbIr/MAL1oMHFvDWM=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CP0qgRUEvQrxKl4cG2EHLbRwD6L0t0RKzIK0LCbhDUuXntmonPfA6oYu/3OY8v9fF GOvoGKfjnVw4CXaanZuYmIAhvc28R7zyEBq9ZosYq9XVJtW8HMSK9+vT98n62q0HFu H+IQVwl6cdmdY/6npP2T59e5+T7gzGkac63Dm3LM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1A54AF801D8; Fri, 24 Jan 2020 10:07:40 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7A582F8020C; Fri, 24 Jan 2020 10:07:38 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A5C71F800F5 for ; Fri, 24 Jan 2020 10:07:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A5C71F800F5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="QwVgTRUk" Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 24 Jan 2020 01:06:46 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 24 Jan 2020 01:07:32 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 24 Jan 2020 01:07:32 -0800 Received: from [10.21.133.51] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 24 Jan 2020 09:07:24 +0000 To: Dmitry Osipenko , Sameer Pujar References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> <598fe377-5b95-d30a-eb64-89a645166d42@gmail.com> <3f51939d-cf4b-f69b-728a-7eb99bbae458@nvidia.com> <34ac1fd3-ae0f-07f2-555f-a55087a2c9dc@nvidia.com> <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> <0fc814c2-0dc6-7741-b954-463381ff7fb9@nvidia.com> From: Jon Hunter Message-ID: <9f73afdf-1e9a-cdbd-f972-a022d503ef51@nvidia.com> Date: Fri, 24 Jan 2020 09:07:22 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1579856806; bh=7aoEWgOMrsENsyCSERE4iOvClQ10ZBvAeKGx7j04F0Y=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=QwVgTRUkTeKYuVdIF7IWb8Lx6v4QxDRL3CI5bRnrYOJwXFYDVgMmPs5XFiEQ0Qfk4 wqx0DGl28wvYoC4xC0tkZah++mlIsfR8UrL12MvIgBntdJ0oA57208JrBcXNZRb2xF bxrjLt4MAxLDlMn5/rcnn5er2CGH8stTdmDBAOImYAtrUnk2DOBgU7xWuuOyBrqesr rOkiqEckCbQJwpbwZgu+MuDnK2VVPRFAAitb253LPKwCb3SFyUV1vjYzXrw2hosS7R MZciu+P9Zy8jm+skB8HZ97Q2LK9OiU77dRSKfnIM4aQj72Mnb7bHsjN/hOgGr6jHGA KVmJjRE4Uf0dA== Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.com, atalambedu@nvidia.com, robh+dt@kernel.org, lgirdwood@gmail.com, viswanathl@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Ck9uIDIzLzAxLzIwMjAgMTU6MTYsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPiAyMy4wMS4yMDIw IDEyOjIyLCBTYW1lZXIgUHVqYXIg0L/QuNGI0LXRgjoKPj4KPj4KPj4gT24gMS8yMi8yMDIwIDk6 NTcgUE0sIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPj4+IEV4dGVybmFsIGVtYWlsOiBVc2UgY2F1 dGlvbiBvcGVuaW5nIGxpbmtzIG9yIGF0dGFjaG1lbnRzCj4+Pgo+Pj4KPj4+IDIyLjAxLjIwMjAg MTQ6NTIsIEpvbiBIdW50ZXIg0L/QuNGI0LXRgjoKPj4+PiBPbiAyMi8wMS8yMDIwIDA3OjE2LCBT YW1lZXIgUHVqYXIgd3JvdGU6Cj4+Pj4KPj4+PiAuLi4KPj4+Pgo+Pj4+Pj4+Pj4+PiArc3RhdGlj IGludCB0ZWdyYTIxMF9pMnNfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4+ Pj4+Pj4+Pj4+ICt7Cj4+Pj4+Pj4+Pj4+ICvCoMKgwqDCoCBwbV9ydW50aW1lX2Rpc2FibGUoJnBk ZXYtPmRldik7Cj4+Pj4+Pj4+Pj4+ICvCoMKgwqDCoCBpZiAoIXBtX3J1bnRpbWVfc3RhdHVzX3N1 c3BlbmRlZCgmcGRldi0+ZGV2KSkKPj4+Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCB0ZWdyYTIxMF9pMnNfcnVudGltZV9zdXNwZW5kKCZwZGV2LT5kZXYpOwo+Pj4+Pj4+Pj4+IFRo aXMgYnJlYWtzIGRldmljZSdzIFJQTSByZWZjb3VudGluZyBpZiBpdCB3YXMgZGlzYWJsZWQgaW4g dGhlCj4+Pj4+Pj4+Pj4gYWN0aXZlCj4+Pj4+Pj4+Pj4gc3RhdGUuIFRoaXMgY29kZSBzaG91bGQg YmUgcmVtb3ZlZC4gQXQgbW9zdCB5b3UgY291bGQgd2Fybgo+Pj4+Pj4+Pj4+IGFib3V0IHRoZQo+ Pj4+Pj4+Pj4+IHVueHBlY3RlZCBSUE0gc3RhdGUgaGVyZSwgYnV0IGl0IHNob3VsZG4ndCBiZSBu ZWNlc3NhcnkuCj4+Pj4+Pj4+PiBJIGd1ZXNzIHRoaXMgd2FzIGFkZGVkIGZvciBzYWZldHkgYW5k IGV4cGxpY2l0IHN1c3BlbmQga2VlcHMgY2xvY2sKPj4+Pj4+Pj4+IGRpc2FibGVkLgo+Pj4+Pj4+ Pj4gTm90IHN1cmUgaWYgcmVmLWNvdW50aW5nIG9mIHRoZSBkZXZpY2UgbWF0dGVycyB3aGVuIHJ1 bnRpbWUgUE0gaXMKPj4+Pj4+Pj4+IGRpc2FibGVkIGFuZCBkZXZpY2UgaXMgcmVtb3ZlZC4KPj4+ Pj4+Pj4+IEkgc2VlIGZldyBkcml2ZXJzIHVzaW5nIHRoaXMgd2F5Lgo+Pj4+Pj4+PiBJdCBzaG91 bGQgbWF0dGVyIChpZiBJJ20gbm90IG1pc3Npbmcgc29tZXRoaW5nKSBiZWNhdXNlIFJQTSBzaG91 bGQKPj4+Pj4+Pj4gYmUgaW4KPj4+Pj4+Pj4gYSB3cmVja2VkIHN0YXRlIG9uY2UgeW91J2xsIHRy eSB0byByZS1sb2FkIHRoZSBkcml2ZXIncyBtb2R1bGUuCj4+Pj4+Pj4+IExpa2VseQo+Pj4+Pj4+ PiB0aGF0IHRob3NlIGZldyBvdGhlciBkcml2ZXJzIGFyZSB3cm9uZy4KPj4+Pj4+Pj4KPj4+Pj4+ Pj4gW3NuaXBdCj4+Pj4+Pj4gT25jZSB0aGUgZHJpdmVyIGlzIHJlLWxvYWRlZCBhbmQgUlBNIGlz IGVuYWJsZWQsIEkgZG9uJ3QgdGhpbmsgaXQKPj4+Pj4+PiB3b3VsZCB1c2UKPj4+Pj4+PiB0aGUg c2FtZSAnZGV2JyBhbmQgdGhlIGNvcnJlc3BvbmRpbmcgcmVmIGNvdW50LiBEb2Vzbid0IGl0IHVz ZSB0aGUKPj4+Pj4+PiBuZXcKPj4+Pj4+PiBjb3VudGVycz8KPj4+Pj4+PiBJZiBSUE0gaXMgbm90 IHdvcmtpbmcgZm9yIHNvbWUgcmVhc29uLCBtb3N0IGxpa2VseSBpdCB3b3VsZCBiZSB0aGUKPj4+ Pj4+PiBjYXNlCj4+Pj4+Pj4gZm9yIG90aGVyCj4+Pj4+Pj4gZGV2aWNlcy4gV2hhdCBiZXN0IGRy aXZlciBjYW4gZG8gaXMgcHJvYmFibHkgZG8gYSBmb3JjZSBzdXNwZW5kCj4+Pj4+Pj4gZHVyaW5n Cj4+Pj4+Pj4gcmVtb3ZhbCBpZgo+Pj4+Pj4+IGFscmVhZHkgbm90IGRvbmUuIEkgd291bGQgcHJl ZmVyIHRvIGtlZXAsIHNpbmNlIG11bHRpcGxlIGRyaXZlcnMKPj4+Pj4+PiBzdGlsbAo+Pj4+Pj4+ IGhhdmUgaXQsCj4+Pj4+Pj4gdW5sZXNzIHRoZXJlIGlzIGEgcmVhbCBoYXJtIGluIGRvaW5nIHNv Lgo+Pj4+Pj4gSSB0b29rIGEgY2xvc2VyIGxvb2sgYW5kIGxvb2tzIGxpa2UgdGhlIGNvdW50ZXIg YWN0dWFsbHkgc2hvdWxkIGJlCj4+Pj4+PiByZXNldC4gU3RpbGwgSSBkb24ndCB0aGluayB0aGF0 IGl0J3MgYSBnb29kIHByYWN0aWNlIHRvIG1ha2UgY2hhbmdlcwo+Pj4+Pj4gdW5kZXJuZWF0aCBv ZiBSUE0sIGl0IG1heSBzdHJpa2UgYmFjay4KPj4+Pj4gSWYgUlBNIGlzIGJyb2tlbiwgaXQgcHJv YmFibHkgd291bGQgaGF2ZSBiZWVuIGNhdWdodCBkdXJpbmcgZGV2aWNlCj4+Pj4+IHVzYWdlLgo+ Pj4+PiBJIHdpbGwgcmVtb3ZlIGV4cGxpY2l0IHN1c3BlbmQgaGVyZSBpZiBubyBhbnkgY29uY2Vy bnMgZnJvbSBvdGhlcgo+Pj4+PiBmb2xrcy4KPj4+Pj4gVGhhbmtzLgo+Pj4+IEkgcmVjYWxsIHRo YXQgdGhpcyB3YXMgdGhlIHByZWZlcnJlZCB3YXkgb2YgZG9pbmcgdGhpcyBmcm9tIHRoZSBSUE0K Pj4+PiBmb2xrcy4gVGVncmEzMCBJMlMgZHJpdmVyIGRvZXMgdGhlIHNhbWUgYW5kIFN0ZXBoZW4g aGFkIHBvaW50ZWQgbWUgdG8KPj4+PiB0aGlzIGFzIGEgcmVmZXJlbmNlLgo+Pj4+IEkgYmVsaWV2 ZSB0aGF0IHRoaXMgaXMgbWVhbnQgdG8gZW5zdXJlIHRoYXQgdGhlCj4+Pj4gZGV2aWNlIGlzIGFs d2F5cyBwb3dlcmVkLW9mZiByZWdhcmRsZXNzIG9mIGl0IFJQTSBpcyBlbmFibGVkIG9yIG5vdCBh bmQKPj4+PiB3aGF0IHRoZSBjdXJyZW50IHN0YXRlIGlzLgo+Pj4gWWVzLCBpdCB3YXMga2luZGEg YWN0dWFsIGZvciB0aGUgY2FzZSBvZiB1bmF2YWlsYWJsZSBSUE0uCj4+Cj4+PiBBbnl3YXlzLCAv SSB0aGluay8gdmFyaWFudCBsaWtlIHRoaXMgc2hvdWxkIGhhdmUgYmVlbiBtb3JlIHByZWZlcnJl ZDoKPj4+Cj4+PiBpZiAoIXBtX3J1bnRpbWVfZW5hYmxlZCgmcGRldi0+ZGV2KSkKPj4+IMKgwqDC oMKgwqDCoMKgwqAgdGVncmEyMTBfaTJzX3J1bnRpbWVfc3VzcGVuZCgmcGRldi0+ZGV2KTsKPj4+ IGVsc2UKPj4+IMKgwqDCoMKgwqDCoMKgwqAgcG1fcnVudGltZV9kaXNhYmxlKCZwZGV2LT5kZXYp Owo+Pgo+PiBJIHRoaW5rIGl0IGxvb2tzIHRvIGJlIHNpbWlsYXIgdG8gd2hhdCBpcyB0aGVyZSBh bHJlYWR5Lgo+Pgo+PiBwbV9ydW50aW1lX2Rpc2FibGUoJnBkZXYtPmRldik7IC8vIGl0IHdvdWxk IHR1cm4gb3V0IHRvIGJlIGEgZHVtbXkgY2FsbAo+PiBpZiAhUlBNCj4+IGlmICghcG1fcnVudGlt ZV9zdGF0dXNfc3VzcGVuZGVkKCZwZGV2LT5kZXYpKSAvLyBpdCBpcyB0cnVlIGFsd2F5cyBpZiAh UlBNCj4+IMKgwqDCoMKgwqDCoMKgIHRlZ3JhMjEwX2kyc19ydW50aW1lX3N1c3BlbmQoJnBkZXYt PmRldik7Cj4gCj4gTWF5YmUgdGhpcyBpcyBmaW5lIGZvciAhUlBNLCBidXQgbm90IHJlYWxseSBm aW5lIGluIGEgY2FzZSBvZiBlbmFibGVkCj4gUlBNLiBEZXZpY2UgY291bGQgYmUgaW4gcmVzdW1l ZCBzdGF0ZSBhZnRlciBwbV9ydW50aW1lX2Rpc2FibGUoKSBpZiBpdAo+IHdhc24ndCBzdXNwZW5k ZWQgYmVmb3JlIHRoZSBkaXNhYmxpbmcuCgpJIGRvbid0IHNlZSBhbnkgcHJvYmxlbSB3aXRoIHRo aXMgZm9yIHRoZSAhUlBNIGNhc2UuCgpKb24KCi0tIApudnB1YmxpYwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApB bHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cHM6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5v cmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg==