From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 943D0C2D0E5 for ; Sun, 29 Mar 2020 11:52:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6ABCB20A8B for ; Sun, 29 Mar 2020 11:52:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728231AbgC2Lwc (ORCPT ); Sun, 29 Mar 2020 07:52:32 -0400 Received: from mail.ut.ac.ir ([80.66.177.10]:56986 "EHLO mail.ut.ac.ir" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728219AbgC2Lwc (ORCPT ); Sun, 29 Mar 2020 07:52:32 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.ut.ac.ir (Postfix) with ESMTP id 006B41DAB47; Sun, 29 Mar 2020 16:22:29 +0430 (+0430) Received: from mail.ut.ac.ir ([127.0.0.1]) by localhost (mail.ut.ac.ir [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1PFPvhqBSxrX; Sun, 29 Mar 2020 16:22:28 +0430 (+0430) Received: from mail.ut.ac.ir (mail.ut.ac.ir [194.225.0.10]) by mail.ut.ac.ir (Postfix) with ESMTP id D0CC41DAA9E; Sun, 29 Mar 2020 16:22:27 +0430 (+0430) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 29 Mar 2020 16:22:27 +0430 From: ahmadkhorrami To: Jiri Olsa Cc: Steven Rostedt , Arnaldo Carvalho de Melo , Linux-trace Users , Peter Zijlstra , linux-trace-users-owner@vger.kernel.org, Jin Yao , Milian Wolff , Namhyung Kim , Andi Kleen Subject: Re: Wrong Perf Backtraces In-Reply-To: <20200329111959.GC2155755@krava> References: <20200327092045.GH1947699@krava> <821540886fc57d7749edee585a50602f@ut.ac.ir> <20200327223743.GA2155755@krava> <57b9e24200019a41bd465e2d78c09e29@ut.ac.ir> <20200328233431.GB2155755@krava> <8a58f8eda97525e5e49daeb001107c9d@ut.ac.ir> <20200329111959.GC2155755@krava> Message-ID: <9f7cae225ed99222e05ca1e840cd93dd@ut.ac.ir> X-Sender: ahmadkhorrami@ut.ac.ir User-Agent: Roundcube Webmail/1.3.6 Sender: linux-trace-users-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-users@vger.kernel.org Hi, Thanks. Still no change. Sorry, I forgot to say that you should initialize the "perfCMD" variable to your perf binary path. Regards. On 2020-03-29 15:49, Jiri Olsa wrote: > On Sun, Mar 29, 2020 at 05:46:57AM +0430, ahmadkhorrami wrote: > >> Hi, >> Each line is correct. I mean addresses match symbols. But some callers >> and >> callees do not match. Perhaps callchain misses some callers in >> between. >> Regards > > right, I missed another case.. how about the change below? > your script is silent now on my data > > jirka > > --- > diff --git a/tools/perf/util/evsel_fprintf.c > b/tools/perf/util/evsel_fprintf.c > index 3b4842840db0..fc4fb88937ed 100644 > --- a/tools/perf/util/evsel_fprintf.c > +++ b/tools/perf/util/evsel_fprintf.c > @@ -173,6 +173,8 @@ int sample__fprintf_callchain(struct perf_sample > *sample, int left_alignment, > > if (print_srcline) > printed += map__fprintf_srcline(map, addr, "\n ", fp); > + else if (node->srcline) > + printed += fprintf(fp, " %s", node->srcline); > > if (sym && sym->inlined) > printed += fprintf(fp, " (inlined)");