From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932812AbdDGJ0A (ORCPT ); Fri, 7 Apr 2017 05:26:00 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:53342 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932563AbdDGJZw (ORCPT ); Fri, 7 Apr 2017 05:25:52 -0400 X-AuditID: b6c32a36-f79446d000002bcd-2d-58e75b1d2b8e Subject: Re: [Patch v4 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder To: Smitha T Murthy Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, a.hajda@samsung.com, pankaj.dubey@samsung.com, kamil@wypas.org, krzk@kernel.org, jtp.park@samsung.com, kyungmin.park@samsung.com, mchehab@kernel.org, m.szyprowski@samsung.com From: Sylwester Nawrocki Message-id: <9f81ed3a-4adb-7827-6094-88847bc0787a@samsung.com> Date: Fri, 07 Apr 2017 11:25:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-version: 1.0 In-reply-to: <1491553894.15698.1142.camel@smitha-fedora> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLKsWRmVeSWpSXmKPExsWy7bCmvq5s9PMIgy2rDCxurTvHanFk7VUm i5kn2lktzp/fwG5xtukNu8Wmx9dYLS7vmsNm0bNhK6vF2iN32S2WbfrDZLFo6xd2i7t7tjE6 8HhsWtXJ5rF5Sb1H35ZVjB6fN8l5XDnSyB7AGsVlk5Kak1mWWqRvl8CVsfPgbeaCfu6KTdsm MDcwTuTsYuTkkBAwkejc0MQKYYtJXLi3nq2LkYtDSGAHo0TDz252CKedSeLVlYusMB2nL35j gkgsZ5SYv+cGK4Rzn1Gi/XYnO0iVsECwxKqOBrAOEQEtiZ87X4AVMQvMZJKYOr+BBSTBJmAo 0Xu0jxHE5hWwk5jzfCcTiM0ioCpx4fNpsEGiAhES1+dsgaoRlPgx+R5YL6eAhcSh6cfA6pkF rCSe/WtlhbDlJTavecsMskxC4By7xJL5fUAJDiBHVmLTAWaIF1wk1m59wgZhC0u8Or6FHcKW llj17xYTRG8/o8SJNc2MEM4MRok77ROYIKqsJQ4fvwi1jU/i3dceqAW8Eh1tQhAlHhI3ms9C hR0lLu2Vg4TQdiaJJU8PMk1glJ+F5J9ZSH6YheSHBYzMqxjFUguKc9NTiw0LjPSKE3OLS/PS 9ZLzczcxghORltkOxkXnfA4xCnAwKvHwejx+EiHEmlhWXJl7iFGCg1lJhFcw8HmEEG9KYmVV alF+fFFpTmrxIUZpDhYlcV7R9dcihATSE0tSs1NTC1KLYLJMHJxSDYynflk4T1TrL2LtPaiZ sXDpbpHbpkHS9zPTJf9uNfl1xVN1G+eepUvO2X9/PanvztH9t5zWPktXOJ7TH/ol5PvskM9Z P3YwxG/hyI7X/8JTdl9kY825GRk/zDtXa1epl59ULS+Z4beMybHJ/ZyNxRkW0Ywj+Unxu8xV eaL3Xv23ZnL73q9LWVmUWIozEg21mIuKEwGPKzpEQAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t9jAV3Z6OcRBqfmcFrcWneO1eLI2qtM FjNPtLNanD+/gd3ibNMbdotNj6+xWlzeNYfNomfDVlaLtUfuslss2/SHyWLR1i/sFnf3bGN0 4PHYtKqTzWPzknqPvi2rGD0+b5LzuHKkkT2ANcrNJiM1MSW1SCE1Lzk/JTMv3VYpNMRN10JJ IS8xN9VWKULXNyRISaEsMacUyDMyQAMOzgHuwUr6dgluGTsP3mYu6Oeu2LRtAnMD40TOLkZO DgkBE4nTF78xQdhiEhfurWcDsYUEljJKPLuR38XIBWQ/ZJS4vfs1WJGwQLDEqo4GVhBbREBL 4ufOF6wQRduZJH53dzKBOMwCM5kkVp24ygJSxSZgKNF7tI8RxOYVsJOY83wn2CQWAVWJC59P s4PYogIREg87d7FD1AhK/Jh8D6yXU8BC4tD0Y2D1zAJmEl9eHmaFsOUlNq95yzyBUWAWkpZZ SMpmISlbwMi8ilEitSC5oDgpPdcwL7Vcrzgxt7g0L10vOT93EyM4Lp9J7WA8uMv9EKMAB6MS D6/H4ycRQqyJZcWVuYcYJTiYlUR4BQOfRwjxpiRWVqUW5ccXleakFh9iNAV6ZCKzlGhyPjBl 5JXEG5qYm5gbG1iYW1qaGCmJ8zbOfhYuJJCeWJKanZpakFoE08fEwSnVwJjwJenlT/7HM83P iAh1ZZhJrlmwQG6jSEHozbUJGu1v3mr6u5fyeyT7v3/Qvtt0q99/3fsXv2wRip8159Uafrla 7VdBoutlMwy5Cj6tuGqtsdC/8JJV5IFPvV9jN1YySMkc/OV2PezolTsX1/y9r2FZKSi9eHFi +mvXTq+o6aaFT+4c/zOZmUuJpTgj0VCLuag4EQDl/idC4QIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170407092549epcas1p2dc754c94a0c5c25a275d7ae2176462ba X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170406061023epcas5p2a3fa65c4254e17a58f71c68d413e6bfd X-RootMTR: 20170406061023epcas5p2a3fa65c4254e17a58f71c68d413e6bfd References: <1491459105-16641-1-git-send-email-smitha.t@samsung.com> <1491459105-16641-11-git-send-email-smitha.t@samsung.com> <374939c7-241a-fcca-c87e-5c4290bdb6aa@samsung.com> <1491553894.15698.1142.camel@smitha-fedora> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2017 10:31 AM, Smitha T Murthy wrote: > On Thu, 2017-04-06 at 15:14 +0200, Sylwester Nawrocki wrote: >> On 04/06/2017 08:11 AM, Smitha T Murthy wrote: >>> @@ -775,6 +832,47 @@ const char *v4l2_ctrl_get_name(u32 id) >>> case V4L2_CID_MPEG_VIDEO_VPX_P_FRAME_QP: return "VPX P-Frame QP Value"; >>> case V4L2_CID_MPEG_VIDEO_VPX_PROFILE: return "VPX Profile"; >>> >>> + /* HEVC controls */ >> [...] >>> + case V4L2_CID_MPEG_VIDEO_HEVC_LF_SLICE_BOUNDARY: return "HEVC LF Across Slice Boundary or Not"; >> Please make sure the names are no longer than 31 characters to avoid >> truncation during control enumeration in user space. >> Data structures like struct v4l2_queryctrl, struct v4l2_query_ext_ctrl >> have only 32 bytes long array dedicated for the control name. > > I will try to make the names less than 31 characters long without losing > the context. But there are many control names in this file which are > longer than 31 characters like > V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP, > V4L2_CID_MPEG_VIDEO_VPX_GOLDEN_FRAME_REF_PERIOD etc so I assumed it was > alright to have such long names. But I will shorten them as per your > suggestion. Apologies if it wasn't clean enough but my comment referred to the length of the character string being returned (e.g. "HEVC LF Across Slice Boundary or Not") and not to the name of the enum. -- Regards, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.nawrocki@samsung.com (Sylwester Nawrocki) Date: Fri, 07 Apr 2017 11:25:43 +0200 Subject: [Patch v4 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder In-Reply-To: <1491553894.15698.1142.camel@smitha-fedora> References: <1491459105-16641-1-git-send-email-smitha.t@samsung.com> <1491459105-16641-11-git-send-email-smitha.t@samsung.com> <374939c7-241a-fcca-c87e-5c4290bdb6aa@samsung.com> <1491553894.15698.1142.camel@smitha-fedora> Message-ID: <9f81ed3a-4adb-7827-6094-88847bc0787a@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/07/2017 10:31 AM, Smitha T Murthy wrote: > On Thu, 2017-04-06 at 15:14 +0200, Sylwester Nawrocki wrote: >> On 04/06/2017 08:11 AM, Smitha T Murthy wrote: >>> @@ -775,6 +832,47 @@ const char *v4l2_ctrl_get_name(u32 id) >>> case V4L2_CID_MPEG_VIDEO_VPX_P_FRAME_QP: return "VPX P-Frame QP Value"; >>> case V4L2_CID_MPEG_VIDEO_VPX_PROFILE: return "VPX Profile"; >>> >>> + /* HEVC controls */ >> [...] >>> + case V4L2_CID_MPEG_VIDEO_HEVC_LF_SLICE_BOUNDARY: return "HEVC LF Across Slice Boundary or Not"; >> Please make sure the names are no longer than 31 characters to avoid >> truncation during control enumeration in user space. >> Data structures like struct v4l2_queryctrl, struct v4l2_query_ext_ctrl >> have only 32 bytes long array dedicated for the control name. > > I will try to make the names less than 31 characters long without losing > the context. But there are many control names in this file which are > longer than 31 characters like > V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP, > V4L2_CID_MPEG_VIDEO_VPX_GOLDEN_FRAME_REF_PERIOD etc so I assumed it was > alright to have such long names. But I will shorten them as per your > suggestion. Apologies if it wasn't clean enough but my comment referred to the length of the character string being returned (e.g. "HEVC LF Across Slice Boundary or Not") and not to the name of the enum. -- Regards, Sylwester