From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Joseph, Anoob" <Anoob.Joseph@caviumnetworks.com>
Subject: Re: [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD
Date: Mon, 8 Oct 2018 18:28:11 +0530
Message-ID: <9f88e0e8-5999-8eb3-a47b-0bbfa6d5d017@caviumnetworks.com>
References: <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com>
 <1538744363-30340-1-git-send-email-anoob.joseph@caviumnetworks.com>
 <4676876.qg1oKfV5S6@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Akhil Goyal <akhil.goyal@nxp.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>,
 Ankur Dwivedi <ankur.dwivedi@caviumnetworks.com>,
 Murthy NSSR <nidadavolu.murthy@caviumnetworks.com>,
 Nithin Dabilpuram <nithin.dabilpuram@caviumnetworks.com>,
 Ragothaman Jayaraman <rjayaraman@caviumnetworks.com>,
 Srisivasubramanian S <ssrinivasan@caviumnetworks.com>,
 Tejasree Kondoj <kondoj.tejasree@caviumnetworks.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0089.outbound.protection.outlook.com [104.47.33.89])
 by dpdk.org (Postfix) with ESMTP id 150047CB0
 for <dev@dpdk.org>; Mon,  8 Oct 2018 14:57:06 +0200 (CEST)
In-Reply-To: <4676876.qg1oKfV5S6@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

On 08-10-2018 18:03, Thomas Monjalon wrote:
> External Email
>
> 05/10/2018 14:58, Anoob Joseph:
>> Ankur Dwivedi (5):
>>    common/cpt: add common logging support
>>    config: add Cavium OCTEONTX crypto PMD skeleton
>>    crypto/octeontx: add register addresses
>>    common/cpt: add common code for init routine
>>    test: adds validation test
>>
>> Anoob Joseph (5):
>>    crypto/octeontx: add hardware init routine
>>    common/cpt: add hardware register defines
>>    crypto/octeontx: add hardware register access for misc poll
>>    crypto/octeontx: adds symmetric capabilities
>>    doc: adds doc file
>>
>> Murthy NSSR (5):
>>    common/cpt: add PMD ops helper functions
>>    crypto/octeontx: add global resource init
>>    crypto/octeontx: add mailbox routines
>>    crypto/octeontx: add basic dev ops
>>    common/cpt: add common macros for queue pair ops
>>
>> Nithin Dabilpuram (5):
>>    crypto/octeontx: add queue pair functions
>>    common/cpt: add common code required for session management
>>    crypto/octeontx: add session management ops
>>    common/cpt: add common code for fill session data
>>    crypto/octeontx: add supported sessions
>>
>> Ragothaman Jayaraman (4):
>>    common/cpt: add common defines for microcode
>>    common/cpt: add microcode interface for encryption
>>    common/cpt: add microcode interface for decryption
>>    common/cpt: add crypo op enqueue request manager framework
>>
>> Srisivasubramanian S (4):
>>    common/cpt: add support for zuc and snow3g
>>    common/cpt: add support for kasumi
>>    common/cpt: add support for hash
>>    crypto/octeontx: add routines to prepare instructions
>>
>> Tejasree Kondoj (4):
>>    common/cpt: add common code for enqueuing cpt instruction
>>    crypto/octeontx: add enqueue burst op
>>    common/cpt: add common code for cpt dequeue
>>    crypto/octeontx: add dequeue burst op
> A lot of patches are split in 2 parts for common/cpt and crypto/octeontx.
> I think it is useless most of the time.
> You are allowed to update any related code in the common part
> while implementing some features in the crypto driver.
The tool, check-git-log.sh was giving warnings when we were making 
changes in two places. That's one reason we had to split it this way.

Anoob