All of lore.kernel.org
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@somainline.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Yassine Oudjana <y.oudjana@protonmail.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Georgi Djakov <djakov@kernel.org>,
	Rob Herring <robh+dt@kernel.org>
Cc: AngeloGioacchino Del Regno <kholk11@gmail.com>,
	linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shawn Guo <shawn.guo@linaro.org>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH v4 1/5] interconnect: qcom: sdm660: Commonize RPM-QoS
Date: Thu, 2 Sep 2021 00:19:08 +0200	[thread overview]
Message-ID: <9f902b08-bdf2-13b5-acbe-215173e7929a@somainline.org> (raw)
In-Reply-To: <efafd058-ad68-eb0a-af42-40d879ef63d9@linaro.org>

Il 02/09/21 00:01, Dmitry Baryshkov ha scritto:
> On 01/09/2021 21:48, AngeloGioacchino Del Regno wrote:
>> Il 01/09/21 14:15, Yassine Oudjana ha scritto:
>>> SoCs such as MSM8996 also control bus QoS in a similar fashion to SDM660,
>>> with some paths being controlled by RPM and others directly by the AP.
>>> Move relevant functions and defines to a new object so that they can be used
>>> in multiple drivers.
>>>
>>> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
>>
>> Hey guys!
>>
>> I'm waiting for the interconnect RPM-QoS commonization to be merged as I have fresh
>> interconnect drivers for MSM8998 and MSM8976, ready to send, that are also using
>> the very same QoS mechanism as SDM660.
> 
> We were also looking onto this. I'd propose to merge sdm660 code into main 
> icc-rpm.c instead of splitting it into separate file. We have enabled QoS for 
> apq8096 (msm8916) and msm8939. See 
> https://lore.kernel.org/linux-arm-msm/20210818015732.1717810-1-dmitry.baryshkov@linaro.org/ 
> for the reference. I'm waiting for Shawn to publish v2 of his fix, then I can post 
> v2 of my patchset.
> 

Merging it into icc-rpm would actually make sense, since the QoS mechanism won't
ever be used by the RPM-Hardened icc... so yeah, on that I agree.

Whenever you guys send the new patchsets, if you can please make sure to Cc me
and/or the other SoMainline guys, we will make sure to review and test the sets
as soon as possible, as a way to speed up the merge process, if that helps!

Thank you,
- Angelo

>>
>> Yassine, please check Shawn's recent patches for SDM660 interconnect, which are
>> fixing some bits for the QoS implementation and adding some required clocks to the
>> SDM660 interconnect driver.
>>
>> Adding Shawn to the Ccs as to make him aware of this patch;
>> also adding Marijn and Konrad from SoMainline as probably interested parties.
>>
>> Cheers!
>> - Angelo
> 
> 


  reply	other threads:[~2021-09-01 22:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 12:15 [PATCH v4 0/5] interconnect: qcom: Add MSM8996 interconnect driver Yassine Oudjana
2021-09-01 12:15 ` [PATCH v4 1/5] interconnect: qcom: sdm660: Commonize RPM-QoS Yassine Oudjana
2021-09-01 18:48   ` AngeloGioacchino Del Regno
2021-09-01 22:01     ` Dmitry Baryshkov
2021-09-01 22:19       ` AngeloGioacchino Del Regno [this message]
2021-09-02  9:42       ` Yassine Oudjana
2021-09-01 12:16 ` [PATCH v4 2/5] dt-bindings: interconnect: Move SDM660 to a new RPM-QoS file Yassine Oudjana
2021-09-01 12:16 ` [PATCH v4 3/5] dt-bindings: interconnect: Add Qualcomm MSM8996 DT bindings Yassine Oudjana
2021-09-01 12:16 ` [PATCH v4 4/5] interconnect: qcom: Add MSM8996 interconnect provider driver Yassine Oudjana
2021-09-01 12:16 ` [PATCH v4 5/5] arm64: dts: qcom: msm8996: Add interconnect support Yassine Oudjana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f902b08-bdf2-13b5-acbe-215173e7929a@somainline.org \
    --to=angelogioacchino.delregno@somainline.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=kholk11@gmail.com \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=robh+dt@kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.