From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1236DC072B5 for ; Fri, 24 May 2019 16:50:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D56F92070D for ; Fri, 24 May 2019 16:50:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="OfUQNVCq"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=lohutok.net header.i=@lohutok.net header.b="LGtHwCWp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390346AbfEXQul (ORCPT ); Fri, 24 May 2019 12:50:41 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:60954 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390210AbfEXQul (ORCPT ); Fri, 24 May 2019 12:50:41 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 473B5152D21; Fri, 24 May 2019 12:50:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=subject:to:cc :references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=sasl; bh=o+O3Pw8J0sj8 Ix8cYztn3dPR+a8=; b=OfUQNVCq+9XrpYO8PdmcHfbnWGek8w4TAH975m2+d4ej g9S8jHYluBsJhG0crQng/PpIW4F1MRTcltGe7B1j7WnPmbf3xYEtuhlzJE/WvKvJ H1J/YLp5kuEUV2j5y6PBqpeQOPgyPFr85eyYAhiTm/mANS4oF3m+ANxuHUiv7zk= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 3D1BF152D20; Fri, 24 May 2019 12:50:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lohutok.net; h=subject:to:cc:references:from:message-id:date:mime-version:in-reply-to:content-type:content-transfer-encoding; s=2018-11.pbsmtp; bh=UBLviy29aHFjkvA40dZZQAQQVX+Pos5brVfAyuGWWJc=; b=LGtHwCWpTi2vhIgxWyXLaASo350O6fX8pTs6P4T2pThQHAynuoE0TIIbdbEe3XlbnWkm37KHzkpLJGIexGsiEzDX0U8LGzh77mvb9fRcZvSffHPZJ+HBNgbiXhD4qouLxlHgqlJK5lbItqyvZYG2+6hNAbNoUs1PtPxH7SUtGuw= Received: from [10.0.0.75] (unknown [24.47.52.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 6041E152D1F; Fri, 24 May 2019 12:50:38 -0400 (EDT) Subject: Re: [Batch 6 - patch 08/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 133 To: Thomas Gleixner , Richard Fontana Cc: linux-spdx@vger.kernel.org References: <20190524100345.776412942@linutronix.de> <20190524100843.594454135@linutronix.de> From: Allison Randal Message-ID: <9f924d00-df10-cb76-3dec-0e60aaeb4f58@lohutok.net> Date: Fri, 24 May 2019 12:50:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Pobox-Relay-ID: 0EE84E26-7E44-11E9-A9F8-46F8B7964D18-44123303!pb-smtp1.pobox.com Sender: linux-spdx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spdx@vger.kernel.org On 5/24/19 12:02 PM, Thomas Gleixner wrote: > On Fri, 24 May 2019, Richard Fontana wrote: >> On Fri, May 24, 2019 at 6:12 AM Thomas Gleixner wrote: >>> >>> From: Thomas Gleixner tglx@linutronix.de >>> >>> Based on 1 normalized pattern(s): >>> >>> this program is free software you can redistribute it and or modify >>> it under the terms of the gnu general public license as published by >>> the free software foundation either version 2 of the license or at >>> your option any later version this program is distributed in the >>> hope that it will be useful but without any warranty without even >>> the implied warranty of merchantability or fitness for a particular >>> purpose see the gnu general public license for more details the full >>> gnu general public license is in this distribution in the file >>> called copying >> >> I just want to note that the final sentence/paragraph in this pattern, >> alerting the user to the location of the license text ("The full GNU >> General Public License is in this distribution in the file called >> COPYING.") arguably raises its own sort of "keep intact" issue, >> separate from the things we've been more focused on (notices of the >> applicability of the license, and warranty/liability disclaimers >> juxtaposed with the license notice). This may have come up in earlier >> cases I looked at but if so I didn't think about it. > > The reference to the COPYING file is all over the place. But what's > worrysome about that? I'd be worried if the boilerplate would be BSD and > then point to the COPYING file in the kernel tree, but a plain GPL boiler > plate? > > I can't see how that might change anything, the SPDX identifier is > documented to be a placeholder for the full license text which is in the > LICENSES directory and pointed to from the reworked COPYING file. Agreed with Thomas. And besides, it's actually inaccurate for the file to say that the full text of the GPL is in the COPYING file, because in the Kernel the COPYING file does not contain the text of the GPL, it only contains a pointer to it. Reviewed-by: Allison Randal