From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE74C433F5 for ; Fri, 1 Oct 2021 16:33:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43555610A3 for ; Fri, 1 Oct 2021 16:33:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 43555610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:40072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWLTT-0002iR-9J for qemu-devel@archiver.kernel.org; Fri, 01 Oct 2021 12:33:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWLSE-0001kK-CP for qemu-devel@nongnu.org; Fri, 01 Oct 2021 12:32:12 -0400 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]:43792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWLSC-0004pL-LA for qemu-devel@nongnu.org; Fri, 01 Oct 2021 12:32:10 -0400 Received: by mail-qk1-x72c.google.com with SMTP id 138so9677180qko.10 for ; Fri, 01 Oct 2021 09:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=TWGQJk5aChMo6jAn48gWAN6C5M7YY9vwaN9CPCi+OVY=; b=orf/xjmWKa1JnCPiMWOaJiMAfYGqywxfcNRei9Jm3DdQVhYiQatF+q/WtOjw84HcRu 0Kznpu9yQejLUWhy6+m7Ezjp4758xkCX1aLFljZXGO9tSG6PmJhnWRpnXbu0DHMpaSdB NmOzZlzTMzMOre/16gLohi9l8DASGbbSpSTeL9dwf1PJ5L279MaRLZFDGLZvKJGndpmb n2vTMnQ72yv3Uqi0rPY/c0qJyKbIqjOSvhqmc8qqES3a++9LdfEfzVq970+i5leJ4y9j xRa6xFyefSqLueIg9FXaDgUQ2/5sM2s8fZRRc776xeOAgoxdW28pGNr+pEwnrHA3UuzM 46aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TWGQJk5aChMo6jAn48gWAN6C5M7YY9vwaN9CPCi+OVY=; b=rf7KHSLkyBIFlrnuwmDnDxJcrppDWkFeCYlquvpCrw6YOcD39TxqI9fP/xrulzg8xs AMdpFN88VNrhkZVYW/7jyt8uz0m5fFuN/Auy5Q8EDa5Dg20g9yGcvQ6pDxAX4GRhuZMg 6jo4+X4PTC01t92HEko2CTHO3r2XtQQdJsiOH4QPsT8iW6lnec3g6hwdWw+YmLH88Tqv 0vHyTjiNP6LYtiiq4W3pS6QYixRT4zt+Ab3H2LhoIdqCx36neDYcOH6hHDpn42W0lquh mEUT1kHdlAOtyzd+ZZ2nOZyLwqjCDgCoaUzmlC/7UzZE1+f7TADleuaXMCVqsi6CmqK5 NMWA== X-Gm-Message-State: AOAM530gT68u1/QoFoq3CaWaMGacrMdULQVOo4lZ+HWRB5yW2AxUq++y /0by09eCh2Ia1cjT57hGSIwsf63PjUjTUA== X-Google-Smtp-Source: ABdhPJwzKaFWt/DN73NhDmlH0ydAD/vxy+pfwyAbbxppf/AepzkBmiREoM46gxnfhDGLNZ31d8tlEw== X-Received: by 2002:a05:620a:430f:: with SMTP id u15mr10430336qko.32.1633105927384; Fri, 01 Oct 2021 09:32:07 -0700 (PDT) Received: from [192.168.3.43] (c-67-174-166-185.hsd1.ga.comcast.net. [67.174.166.185]) by smtp.gmail.com with ESMTPSA id u12sm4018870qtw.73.2021.10.01.09.32.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Oct 2021 09:32:07 -0700 (PDT) Subject: Re: [PATCH 2/3] hw/intc/arm_gicv3: Set GICR_TYPER.Last correctly when nb_redist_regions > 1 To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210930150842.3810-1-peter.maydell@linaro.org> <20210930150842.3810-3-peter.maydell@linaro.org> From: Richard Henderson Message-ID: <9f9d138b-dc0f-0c47-6728-1d781d8f03ec@linaro.org> Date: Fri, 1 Oct 2021 12:32:05 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210930150842.3810-3-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::72c; envelope-from=richard.henderson@linaro.org; helo=mail-qk1-x72c.google.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.127, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/30/21 11:08 AM, Peter Maydell wrote: > The 'Last' bit in the GICR_TYPER GICv3 redistributor register is > supposed to be set to 1 if this is the last redistributor in a series > of contiguous redistributor pages. Currently we set Last only for > the redistributor for CPU (num_cpu - 1). This only works if there is > a single redistributor region; if there are multiple redistributor > regions then we need to set the Last bit for the last redistributor > in each region. > > This doesn't cause any problems currently because only the KVM GICv3 > supports multiple redistributor regions, and it ignores the value in > GICv3State::gicr_typer. But we need to fix this before we can enable > support for multiple regions in the emulated GICv3. > > Signed-off-by: Peter Maydell > --- Reviewed-by: Richard Henderson r~