From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 597F0C433E7 for ; Thu, 3 Sep 2020 05:25:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3480120716 for ; Thu, 3 Sep 2020 05:25:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="nCwvJHb4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726221AbgICFZX (ORCPT ); Thu, 3 Sep 2020 01:25:23 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:38180 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725919AbgICFZV (ORCPT ); Thu, 3 Sep 2020 01:25:21 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0835PGpK106044; Thu, 3 Sep 2020 00:25:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1599110716; bh=gBdMuSqpoJW5+xK4b3xBor8GR+5z9HkxD1LroMmwd0o=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=nCwvJHb4cTIgz0czU5mwtGvPzqf1BZmnb1+bCRwz7FDsyvkjnwBvq9ktjxwy0g0jA ftWz4SrnKDvDDodTw8/luxIb45MNHjMTfmigipDi0H7LElAFpxyR46Ay1I5Ocy7QNI 54sTyMrVhG7QeSmhlH0JR8V6yH3DjxT1uqo0GO0s= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0835PGM4080260; Thu, 3 Sep 2020 00:25:16 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 3 Sep 2020 00:25:14 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 3 Sep 2020 00:25:15 -0500 Received: from [10.250.235.166] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0835PBC9061764; Thu, 3 Sep 2020 00:25:12 -0500 Subject: Re: [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names To: Nishanth Menon , Suman Anna CC: Rob Herring , Tero Kristo , , , , , , References: <20200901223059.14801-1-nm@ti.com> <20200901223059.14801-7-nm@ti.com> <60e6b790-360a-6eaf-03a3-5bb256adf215@ti.com> <20200902181820.nlvl3pfzeh4agzzi@akan> From: Vignesh Raghavendra Message-ID: <9fb2f8f4-5eeb-6190-9cbf-b28084c58a8f@ti.com> Date: Thu, 3 Sep 2020 10:55:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200902181820.nlvl3pfzeh4agzzi@akan> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nishanth, On 9/2/20 11:48 PM, Nishanth Menon wrote: > On 11:51-20200902, Suman Anna wrote: >> On 9/1/20 5:30 PM, Nishanth Menon wrote: >>> Use adc@ naming for nodes following standard conventions of device >>> tree (section 2.2.2 Generic Names recommendation in [1]). >>> >>> [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3 >>> >>> Suggested-by: Suman Anna >>> Signed-off-by: Nishanth Menon >>> --- >>> arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 4 ++-- >>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++-- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi >>> index 51ca4b4d4c21..6dfec68ac865 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi >>> @@ -80,7 +80,7 @@ >>> #size-cells = <0>; >>> }; >>> >>> - tscadc0: tscadc@40200000 { >>> + tscadc0: adc@40200000 { >> >> OK with these changes, since these seem to be only have the adc child nodes. >> This node is essentially a parent node for touchscreen and adc child nodes. The >> driver is currently looking for "tsc" on touchscreen child nodes, but none of >> the K3 SoCs have them atm. >> > > > Vignesh: are you ok with this, care to comment? > On K3 SoCs, ADC IP is reuse from AM335x but just lacks resistive touchscreen interfaces. So, existing AM335x ADC driver is being reused for K3 devices as well. Unfortunately, ADC driver cannot be used as standalone and is dependent on MFD parent to be present... Above node represents the MFD parent and ADC itself is the child node (see arch/arm64/boot/dts/ti/k3-am654-base-board.dts). So, I recommend that we keep this node's name as tscadc in order to avoid having same name for parent and child node which will be quite confusing. Regards Vignesh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77E1FC433E7 for ; Thu, 3 Sep 2020 05:26:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33BB720758 for ; Thu, 3 Sep 2020 05:26:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q3U1tCDx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="nCwvJHb4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33BB720758 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y292spXNz8JBChvTBinCjTTTh0HGm4/zTBl+6erFwVI=; b=q3U1tCDxzxbeiAbDcKyuiRByl Eq8ptTEo4h7PEH/iH2eQWNRjJxcUzH9CUT/q3loOOWij35kWyJPvHOOMVBHhRg135I8zGhX2rK7Wz IEvHjYOJBpE+dK3hYYDBDs2z5DlU2k8o7wgM+3yEzypTpApfwfZSJVHOFcB/97UXHRaFMxSbOoxBz jvQ5ijbPOEGBhJM5nxA2WH6EbiKEQzdFpV6J7WPG812s+XygIgH0+t4rd1bRtdWhM0y5QW9hyBW4K 5oaiTTBrKRPkQQZSpoOsI6BhKJ1mFSjurAnF+SNkfOcvRHgS8b6osc6fpVQe6AKQJI5rj1Hzsrs/O WWZv9Ig0A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDhkP-00087r-RI; Thu, 03 Sep 2020 05:25:21 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDhkM-00087U-Nr for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 05:25:20 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0835PGpK106044; Thu, 3 Sep 2020 00:25:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1599110716; bh=gBdMuSqpoJW5+xK4b3xBor8GR+5z9HkxD1LroMmwd0o=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=nCwvJHb4cTIgz0czU5mwtGvPzqf1BZmnb1+bCRwz7FDsyvkjnwBvq9ktjxwy0g0jA ftWz4SrnKDvDDodTw8/luxIb45MNHjMTfmigipDi0H7LElAFpxyR46Ay1I5Ocy7QNI 54sTyMrVhG7QeSmhlH0JR8V6yH3DjxT1uqo0GO0s= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0835PGM4080260; Thu, 3 Sep 2020 00:25:16 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 3 Sep 2020 00:25:14 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 3 Sep 2020 00:25:15 -0500 Received: from [10.250.235.166] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0835PBC9061764; Thu, 3 Sep 2020 00:25:12 -0500 Subject: Re: [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names To: Nishanth Menon , Suman Anna References: <20200901223059.14801-1-nm@ti.com> <20200901223059.14801-7-nm@ti.com> <60e6b790-360a-6eaf-03a3-5bb256adf215@ti.com> <20200902181820.nlvl3pfzeh4agzzi@akan> From: Vignesh Raghavendra Message-ID: <9fb2f8f4-5eeb-6190-9cbf-b28084c58a8f@ti.com> Date: Thu, 3 Sep 2020 10:55:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200902181820.nlvl3pfzeh4agzzi@akan> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_012518_913881_50367CA9 X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, grygorii.strashko@ti.com, lokeshvutla@ti.com, nsekhar@ti.com, linux-kernel@vger.kernel.org, Tero Kristo , Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nishanth, On 9/2/20 11:48 PM, Nishanth Menon wrote: > On 11:51-20200902, Suman Anna wrote: >> On 9/1/20 5:30 PM, Nishanth Menon wrote: >>> Use adc@ naming for nodes following standard conventions of device >>> tree (section 2.2.2 Generic Names recommendation in [1]). >>> >>> [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3 >>> >>> Suggested-by: Suman Anna >>> Signed-off-by: Nishanth Menon >>> --- >>> arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 4 ++-- >>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++-- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi >>> index 51ca4b4d4c21..6dfec68ac865 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi >>> @@ -80,7 +80,7 @@ >>> #size-cells = <0>; >>> }; >>> >>> - tscadc0: tscadc@40200000 { >>> + tscadc0: adc@40200000 { >> >> OK with these changes, since these seem to be only have the adc child nodes. >> This node is essentially a parent node for touchscreen and adc child nodes. The >> driver is currently looking for "tsc" on touchscreen child nodes, but none of >> the K3 SoCs have them atm. >> > > > Vignesh: are you ok with this, care to comment? > On K3 SoCs, ADC IP is reuse from AM335x but just lacks resistive touchscreen interfaces. So, existing AM335x ADC driver is being reused for K3 devices as well. Unfortunately, ADC driver cannot be used as standalone and is dependent on MFD parent to be present... Above node represents the MFD parent and ADC itself is the child node (see arch/arm64/boot/dts/ti/k3-am654-base-board.dts). So, I recommend that we keep this node's name as tscadc in order to avoid having same name for parent and child node which will be quite confusing. Regards Vignesh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel