From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 1/3] doc: add usage doc for ENETC PMD
Date: Fri, 21 Sep 2018 14:22:25 +0100
Message-ID: <9fb310b0-9ee4-7e9a-f4fe-ccfd702ae4dd@intel.com>
References: <20180906055449.21731-1-g.singh@nxp.com>
 <20180913094201.17098-1-g.singh@nxp.com>
 <20180913094201.17098-2-g.singh@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: pankaj.chauhan@nxp.com
To: Gagandeep Singh <g.singh@nxp.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id A78271B19
 for <dev@dpdk.org>; Fri, 21 Sep 2018 15:22:41 +0200 (CEST)
In-Reply-To: <20180913094201.17098-2-g.singh@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/13/2018 10:41 AM, Gagandeep Singh wrote:
> Add enetc usage document to compile and run the
> DPDK application on enetc supported platform.
> This document introduces the enetc driver, supported
> platforms and supported features.
> 
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> ---
>  MAINTAINERS                        |   5 +
>  doc/guides/nics/enetc.rst          | 153 +++++++++++++++++++++++++++++
>  doc/guides/nics/features/enetc.ini |   8 ++
>  doc/guides/nics/index.rst          |   1 +

Please also add a release note update.
And a web page patch to supported device list: https://core.dpdk.org/supported/

<...>

> +Driver compilation and testing
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +#. Please refer the document :ref:`compiling and testing a PMD for a NIC <pmd_build_and_test>`
> +   to compile the driver. Use target "arm64-armv8a-linuxapp-gcc" in make command
> +
> +#. Refer to the document :ref:`cross build dpdk for arm64 <configure_and_cross_compile_dpdk_build>` to
> +   disable flags and for cross compilation
> +
> +#. To compile in performance mode, please set ``CONFIG_RTE_CACHE_LINE_SIZE=64``
> +
> +#. Running l2fwd:
> +
> +   Follow instructions available in the document
> +   :ref:`compiling and testing a PMD for a NIC <pmd_build_and_test>`
> +   to run l2fwd.
> +
> +   - First unbind the ports from kernel
> +
> +     - echo vfio-pci > /sys/bus/pci/devices/0000\:00\:00.1/driver_override
> +     - echo 0000:00:00.1 > /sys/bus/pci/drivers/fsl_enetc/unbind
> +     - echo vfio-pci > /sys/bus/pci/devices/0000\:00\:00.0/driver_override
> +     - echo 0000:00:00.0 > /sys/bus/pci/drivers/fsl_enetc/unbind
> +   - Then bind them to VFIO, so that DPDK application can use them
> +
> +     - echo 0000:00:00.1 > /sys/bus/pci/drivers/vfio-pci/bind
> +     - echo 0000:00:00.0 > /sys/bus/pci/drivers/vfio-pci/bind
> +   - Mount Hugepages
> +
> +     - mkdir /mnt/hugepages
> +     - mount -t hugetlbfs none /mnt/hugepages
> +   - Run l2fwd application

We moved common part of documentation into " compiling and testing a PMD for a
NIC" section, check other PMD docs for usage, for example ena PMD, "Usage
example" section.

It is good to keep example output if it has PMD specific logs, but not required
to have generic output.