Re: [LTP] [PATCH 2/3] openposix: Setup autoconf and fix installation layout

[Joerg Vehlow <lkml@jv-coder.de>]

Hi Richard,

Am 7/5/2022 um 7:57 AM schrieb Richard Palethorpe:
> Hello Joerg,
> 
> Joerg Vehlow <lkml@jv-coder.de> writes:
> 
>>  
>> -distclean: distclean-makefiles
>> +.PHONY: distclean
>> +distclean: clean distclean-makefiles
>> +	@rm -f $(AUTOGENERATED_FILES)
> 
> Shouldn't this also include the configure script itself? Running
> distclean on the LTP root removes the top level configure script.
No it does not. If autotools generates all the makefiles, it would do
that, but with the hand-crafted makefiles of ltp, it does not.
The same is true for the realtime testsuite. It only deletes the
configure script in maintainer-clean. To keep it consistent, I went for
the same cleanup, as ltp itself an the realtime testsuite use.

$ make distclean &>/dev/null && ls configure
configure


>> diff --git a/testcases/open_posix_testsuite/QUICK-START b/testcases/open_posix_testsuite/QUICK-START
>> index 6f5d881b4..649d7a3d7 100644
>> --- a/testcases/open_posix_testsuite/QUICK-START
>> +++ b/testcases/open_posix_testsuite/QUICK-START
>> @@ -10,8 +10,6 @@ No worries! Here's a quick doc to help you around POSIX** Test Suite.
>>  Setting up your machine
>>  ========================
>>  
>> -* There is nothing to install, the suite is intended to be run directly.
>> -
>>  * See the "BUILD" file for info on how to set up the Makefile and your machine,
>>    depending on what specific area you are concentrating on.
>>  (Signals, Semaphores, Threads, Timers or Message Queues).
>> @@ -20,8 +18,8 @@ Setting up your machine
>>  Running the tests
>>  ===================
>>  
>> -* Easiest way to run all the tests is to do a "make all" in the top-level
>> -  directory.
>> +* Easiest way to run all the tests is to do a "./configure && make all"
> 
> Trailing whitespace at the end of this line
Fixed in v2

>> diff --git a/testcases/open_posix_testsuite/configure.ac b/testcases/open_posix_testsuite/configure.ac
>> new file mode 100644
>> index 000000000..ae0399d07
>> --- /dev/null
>> +++ b/testcases/open_posix_testsuite/configure.ac
>> @@ -0,0 +1,18 @@
>> +AC_PREREQ(2.61)
>> +AC_INIT([open_posix_testsuite], [LTP_VERSION], [ltp@lists.linux.it])
>> +AC_CONFIG_FILES([ \
>> +    include/mk/config.mk \
>> +])
>> +
>> +AC_PROG_CC_C99
> 
> This causes a deprecation warning for me
As already explained, I will replace it with AC_PROG_CC in v2

Joerg


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp