From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7093DC32771 for ; Fri, 10 Jan 2020 01:27:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E50D206ED for ; Fri, 10 Jan 2020 01:27:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730570AbgAJB1Y (ORCPT ); Thu, 9 Jan 2020 20:27:24 -0500 Received: from mail-sh.amlogic.com ([58.32.228.43]:35351 "EHLO mail-sh.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730557AbgAJB1Y (ORCPT ); Thu, 9 Jan 2020 20:27:24 -0500 Received: from [10.18.38.198] (10.18.38.198) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Fri, 10 Jan 2020 09:27:47 +0800 Subject: Re: [PATCH v4 1/6] dt-bindings: phy: Add Amlogic A1 USB2 PHY Bindings To: Martin Blumenstingl CC: Jerome Brunet , Neil Armstrong , Rob Herring , Greg Kroah-Hartman , Kevin Hilman , Yue Wang , , , , , Carlo Caione , Michael Turquette , Stephen Boyd , Liang Yang , Jianxin Pan , Qiufang Dai , Jian Hu , Victor Wan , Xingyu Chen References: <1578537045-23260-1-git-send-email-hanjie.lin@amlogic.com> <1578537045-23260-2-git-send-email-hanjie.lin@amlogic.com> From: Hanjie Lin Message-ID: <9fc103f4-a388-a65e-f621-846f03f77b3a@amlogic.com> Date: Fri, 10 Jan 2020 09:27:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.18.38.198] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2020/1/10 1:12, Martin Blumenstingl wrote: > On Thu, Jan 9, 2020 at 3:30 AM Hanjie Lin wrote: > [...] >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + items: >> + - const: xtal_usb_phy > the "usb_phy" part of "xtal_usb_phy" seems redundant to me: > it's the XTAL clock input (this is what I'd expect as clock-name) of > the USB PHY (this is already part of the node name). > in addition to keeping the reset-names consistent (as Neil suggested) > please also use the same clock-names as G12 > Of course. I will use "xtal" name in next version. Thanks, Hanjie > > Thank you! > Martin > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F7D8C33CA2 for ; Fri, 10 Jan 2020 01:27:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D855E206ED for ; Fri, 10 Jan 2020 01:27:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H5646N9R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D855E206ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hLLBOkIsqU8smrewt5V3beJx63RkbEEGVnkHp+pLXeU=; b=H5646N9RmERo9e L+n6E/4hBhtP8qLpJZgKJ6+/iO8qUb3/pQRn8DbURvS5JyoBRPXkh9kFyG2AuSKTO4gaOnqI5elOi yLBQMlmd9W5HpZ2i9OlBHVV1Q9NKQrprYlh/a/DK249Kjr77MmgIrxJQvCqroTNKl0KO/rtq7wY3X x+061EV+cZHqFl37EF0Fxw1iVeO3vMIDhbaYb+ySlj3mVpajb3MbCwtF1y9sGoVq6FqEtONURlE3o 7afa6zKqJNyi9eVLvtlAVhgNBb0mxKBWXyxoN9Uf/WP18j+Nmk+/w04D9SvpDvzNg54vzrDWq+snA 9jilBy20wytOEtgxczDQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipj5H-0002qO-Vc; Fri, 10 Jan 2020 01:27:31 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipj5D-0002nv-W4; Fri, 10 Jan 2020 01:27:29 +0000 Received: from [10.18.38.198] (10.18.38.198) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Fri, 10 Jan 2020 09:27:47 +0800 Subject: Re: [PATCH v4 1/6] dt-bindings: phy: Add Amlogic A1 USB2 PHY Bindings To: Martin Blumenstingl References: <1578537045-23260-1-git-send-email-hanjie.lin@amlogic.com> <1578537045-23260-2-git-send-email-hanjie.lin@amlogic.com> From: Hanjie Lin Message-ID: <9fc103f4-a388-a65e-f621-846f03f77b3a@amlogic.com> Date: Fri, 10 Jan 2020 09:27:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.18.38.198] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200109_172728_030672_8597154E X-CRM114-Status: UNSURE ( 8.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Victor Wan , Jianxin Pan , Neil Armstrong , Stephen Boyd , Kevin Hilman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Qiufang Dai , devicetree@vger.kernel.org, Liang Yang , Jian Hu , Xingyu Chen , Greg Kroah-Hartman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020/1/10 1:12, Martin Blumenstingl wrote: > On Thu, Jan 9, 2020 at 3:30 AM Hanjie Lin wrote: > [...] >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + items: >> + - const: xtal_usb_phy > the "usb_phy" part of "xtal_usb_phy" seems redundant to me: > it's the XTAL clock input (this is what I'd expect as clock-name) of > the USB PHY (this is already part of the node name). > in addition to keeping the reset-names consistent (as Neil suggested) > please also use the same clock-names as G12 > Of course. I will use "xtal" name in next version. Thanks, Hanjie > > Thank you! > Martin > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A9A2C32771 for ; Fri, 10 Jan 2020 01:27:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E575206ED for ; Fri, 10 Jan 2020 01:27:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HpeVECZ9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E575206ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xIchdU0LtZJSmBuUtS1ambGPmVbww12UP4e3UU5D9HU=; b=HpeVECZ9cn/Ip/ ub8PgL5yW8XZ0GfKLz6HVxnK/Bz8xAyJLm8cltyYR4kyvQwUKdGe0ZuVUZ9Ym/pK4PcF8VDl97PAz 0Dmb/hIrOyYiSTe5AjP2fa6uPP9CCRD2KaKiaisFPK05iiF5jrYXq3f8MyTB1Aw1/2wfhLv4VroZD SOJ6xju1hiKUqQVxqg0pXf2REHvo+Uiv124ineZ1kuzBpylbds7q5UolvxrR+qDUUPd1h9ZwdFqsh /wO4chNeQV3chP7W8noXT1jEqCaRPCLsaEmu4GlG/nr6i2lNjPJ3yFSguy30WVpoUmYaoNCvC+KRU vnOzJ0szCqUSxgvE3BpA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipj5H-0002pm-3C; Fri, 10 Jan 2020 01:27:31 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipj5D-0002nv-W4; Fri, 10 Jan 2020 01:27:29 +0000 Received: from [10.18.38.198] (10.18.38.198) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Fri, 10 Jan 2020 09:27:47 +0800 Subject: Re: [PATCH v4 1/6] dt-bindings: phy: Add Amlogic A1 USB2 PHY Bindings To: Martin Blumenstingl References: <1578537045-23260-1-git-send-email-hanjie.lin@amlogic.com> <1578537045-23260-2-git-send-email-hanjie.lin@amlogic.com> From: Hanjie Lin Message-ID: <9fc103f4-a388-a65e-f621-846f03f77b3a@amlogic.com> Date: Fri, 10 Jan 2020 09:27:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.18.38.198] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200109_172728_030672_8597154E X-CRM114-Status: UNSURE ( 8.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Victor Wan , Jianxin Pan , Neil Armstrong , Stephen Boyd , Kevin Hilman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Qiufang Dai , devicetree@vger.kernel.org, Liang Yang , Jian Hu , Xingyu Chen , Greg Kroah-Hartman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 2020/1/10 1:12, Martin Blumenstingl wrote: > On Thu, Jan 9, 2020 at 3:30 AM Hanjie Lin wrote: > [...] >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + items: >> + - const: xtal_usb_phy > the "usb_phy" part of "xtal_usb_phy" seems redundant to me: > it's the XTAL clock input (this is what I'd expect as clock-name) of > the USB PHY (this is already part of the node name). > in addition to keeping the reset-names consistent (as Neil suggested) > please also use the same clock-names as G12 > Of course. I will use "xtal" name in next version. Thanks, Hanjie > > Thank you! > Martin > > . > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic