On 2018/10/19 下午9:42, David Sterba wrote:
> On Thu, Oct 18, 2018 at 07:17:23PM +0800, Qu Wenruo wrote:
>> This patchset can be fetched from github:
>> https://github.com/adam900710/linux/tree/qgroup_balance_skip_trees
>>
>> Which is still based on v4.19-rc1, but with previous submitted patches
>> as dependency.
> 
> Please rebase this patchset on top of misc-4.20, this should not change
> as it's going to be the 1st pull.
> 
> I tried to pull the git branch and rebase but there were several
> conflicts and some of the paches appeared duplicated so the rebase did
> not recognize the changes as identical.

Yes, the branch has submitted qgroup patches as dependency, and it's
still based on v4.19-rc1, so conflicts are expected.

> 
> Applying patches from mails causes other sort of conflicts and I can't
> seem to get a compilable version.

I'll look into it.

> 
> This is not urgent as I want to put the patchset to a topic branch and
> give it some testing before it goes to for-next. Thanks.

OK, however this patchset may still need extra polish, especially for
the 2nd patch.
As you can see in the benchmark part, it reduces nearly half of dirty
qgroup extents but only cuts about 25% relocation time, that's mostly
caused by that 2nd patch, and that 2nd patch could impact balance
performance even for quota disabled case.

So I'm not eager to push it soon either.

Thanks,
Qu