From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752253AbeERK5q (ORCPT ); Fri, 18 May 2018 06:57:46 -0400 Received: from mga07.intel.com ([134.134.136.100]:25569 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbeERK5o (ORCPT ); Fri, 18 May 2018 06:57:44 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,414,1520924400"; d="scan'208";a="47646733" Subject: Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD To: Andy Shevchenko , Hans de Goede , Chris Chiu Cc: Daniel Drake , Jian-Hong Pan , Jiri Kosina , Benjamin Tissoires , Jani Nikula , Dmitry Torokhov , Adrian Salido , Jason Gerecke , linux-input , Mika Westerberg , Wolfram Sang , linux-i2c@vger.kernel.org, Linux Kernel , Linux Upstreaming Team References: <7728da79-8a7a-b87d-d09c-b36978b3032e@linux.intel.com> <822d5f47cad46ca308d511f7f24cdbc5f4af38b9.camel@linux.intel.com> From: Jarkko Nikula Message-ID: <9fd4cd99-5a4f-2d9e-88ba-18575e951490@linux.intel.com> Date: Fri, 18 May 2018 13:58:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/18/2018 01:20 PM, Andy Shevchenko wrote: > On Fri, 2018-05-18 at 11:37 +0300, Andy Shevchenko wrote: >> On Fri, 2018-05-18 at 09:48 +0200, Hans de Goede wrote: >> >> >>> Could it be the i2c input clock definition in drivers/mfd/intel- >>> lpss- >>> pci.c >>> is also wrong for Apollo Lake (N3450) ? There are lots of people >>> having >>> various issues with i2c attached touchpads on Apollo Lake devices, >>> this bug: >>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1728244 >>> >>> Is sort of a collection bug for these. Various models laptops, lots >>> of >>> reporters. Note not sure thie is an i2c-designware issue, but it >>> would >>> be good to double check the input clock on Apollo Lake. >>> >>> I've checked the datasheet and the datasheet mentions 133MHz as >>> "serial input clk" in the lpio_bxt_regs Registers Summary, which is >>> also part of the LPSS, no clk is mentioned in the "Summary of >>> DW_apb_i2c_mem_map_DW_apb_i2c_addr_block1 Registers". >> >> The internal datasheet we have access to mentioned in this case for >> Broxton and Cannonlake together. So, your assumption might be quite >> close to the truth and the issue is inherited from Broxton. >> > Nope. The specification I have mention the I2C input clock in Broxton is fixed 133 MHz but in Cannon Lake it is derived through non-SW visible divider. > Hans, can your reporters try the following patch? Depending on the > result I may send it out ASAP. > > --- a/drivers/mfd/intel-lpss-pci.c > +++ b/drivers/mfd/intel-lpss-pci.c > @@ -120,7 +120,7 @@ static struct property_entry apl_i2c_properties[] = > { > }; > > static const struct intel_lpss_platform_info apl_i2c_info = { > - .clk_rate = 133000000, > + .clk_rate = 216000000, > .properties = apl_i2c_properties, > }; > Nack. The Apollo Lake HW here shows expected I2C bus clock on oscilloscope so it is indeed clocked at 133 MHz. -- Jarkko