All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: Some microperf tests
Date: Sat, 23 Feb 2019 20:42:07 +0000	[thread overview]
Message-ID: <9fdf6066-6857-bde9-b22a-b346cf0b5696@citrix.com> (raw)
In-Reply-To: <CAHk-=whow092AKSLjgvKc37D+WRFiPyk_XmFxR1eNwGH7YFEGw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

On 23/02/2019 19:30, speck for Linus Torvalds wrote:
> So those numbers are actually sensible.

The old behaviour has always made sense in terms of how legacy software
was expected to use it.

However, given the recommendation, I wasn't certain that the new
behaviour is deliberate.  My first thought was whether it was an
unintended consequence of the NUL selector not resulting in a memory
access, while the pipeline buffers are being frobbed.

> Of course, the fact that verw on a NUL descriptor is so much slower in
> the old case is very inconvenient for the "we should do verw even if
> the CPU says it doesn't have the microcode update, for vmware rasons",
> aka vmverw.
>
> So it would be good to verify that
>
>  (a) yes, this is the intended performance profile from intel
>
>  (b) we probably should give a NUL descriptor for the workaround

As I said - I've currently got these questions open with the relevant
people.  I'll feed back the reply.

>  (c) it hurts the vmverw case, but maybe we can only do vmverw when we
> notice we are actually running under vmware.
>
> Is there any way to do that vmware detection?

CPUID leaves at 0x40000000?  Not necessarily perfect, but will cover the
overwhelming majority of cases.

~Andrew


  reply	other threads:[~2019-02-23 20:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-23 18:26 [MODERATED] Some microperf tests Andrew Cooper
2019-02-23 19:30 ` [MODERATED] " Linus Torvalds
2019-02-23 20:42   ` Andrew Cooper [this message]
2019-02-24 14:23   ` Andi Kleen
2019-03-07 14:26 ` [MODERATED] Updated " Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fdf6066-6857-bde9-b22a-b346cf0b5696@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=speck@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.