All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Cc: blue Swirl <blauwirbel@gmail.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Paul Brook <paul@codesourcery.com>,
	Gleb Natapov <gleb@redhat.com>,
	Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] [PATCH v4 03/13] hpet: Silence warning on write to running main counter
Date: Sun, 13 Jun 2010 14:15:36 +0200	[thread overview]
Message-ID: <9fe7afde72462d56038470e10ce29c0a9c74435b.1276431335.git.jan.kiszka@web.de> (raw)
In-Reply-To: <cover.1276431335.git.jan.kiszka@web.de>
In-Reply-To: <cover.1276431335.git.jan.kiszka@web.de>

From: Jan Kiszka <jan.kiszka@siemens.com>

Setting the main counter while the HPET is enabled may not be a good
idea of the guest, but it is supported and should, thus, not spam the
host console with warnings.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 hw/hpet.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/hpet.c b/hw/hpet.c
index 2836fb0..bcb160b 100644
--- a/hw/hpet.c
+++ b/hw/hpet.c
@@ -520,7 +520,7 @@ static void hpet_ram_writel(void *opaque, target_phys_addr_t addr,
             break;
         case HPET_COUNTER:
             if (hpet_enabled()) {
-                printf("qemu: Writing counter while HPET enabled!\n");
+                DPRINTF("qemu: Writing counter while HPET enabled!\n");
             }
             s->hpet_counter =
                 (s->hpet_counter & 0xffffffff00000000ULL) | value;
@@ -529,7 +529,7 @@ static void hpet_ram_writel(void *opaque, target_phys_addr_t addr,
             break;
         case HPET_COUNTER + 4:
             if (hpet_enabled()) {
-                printf("qemu: Writing counter while HPET enabled!\n");
+                DPRINTF("qemu: Writing counter while HPET enabled!\n");
             }
             s->hpet_counter =
                 (s->hpet_counter & 0xffffffffULL) | (((uint64_t)value) << 32);
-- 
1.6.0.2

  parent reply	other threads:[~2010-06-13 12:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-13 12:15 [Qemu-devel] [PATCH v4 00/13] HPET cleanups, fixes, enhancements Jan Kiszka
2010-06-13 12:15 ` [Qemu-devel] [PATCH v4 01/13] hpet: Catch out-of-bounds timer access Jan Kiszka
2010-06-13 12:15 ` [Qemu-devel] [PATCH v4 02/13] hpet: Coding style cleanups and some refactorings Jan Kiszka
2010-06-13 12:15 ` Jan Kiszka [this message]
2010-06-13 12:15 ` [Qemu-devel] [PATCH v4 04/13] hpet: Move static timer field initialization Jan Kiszka
2010-06-13 12:15 ` [Qemu-devel] [PATCH v4 05/13] hpet: Convert to qdev Jan Kiszka
2010-06-13 12:15 ` [Qemu-devel] [PATCH v4 06/13] hpet: Start/stop timer when HPET_TN_ENABLE is modified Jan Kiszka
2010-06-13 12:15 ` [Qemu-devel] [PATCH v4 07/13] hpet/rtc: Rework RTC IRQ replacement by HPET Jan Kiszka
2010-06-13 12:15 ` [Qemu-devel] [PATCH v4 08/13] hpet: Drop static state Jan Kiszka
2010-06-13 12:15 ` [Qemu-devel] [PATCH v4 09/13] hpet: Add support for level-triggered interrupts Jan Kiszka
2010-06-13 12:15 ` [Qemu-devel] [PATCH v4 10/13] vmstate: Add VMSTATE_STRUCT_VARRAY_UINT8 Jan Kiszka
2010-06-13 12:15 ` [Qemu-devel] [PATCH v4 11/13] hpet: Make number of timers configurable Jan Kiszka
2010-06-13 12:15 ` [Qemu-devel] [PATCH v4 12/13] hpet: Add MSI support Jan Kiszka
2010-06-13 12:15 ` [Qemu-devel] [PATCH v4 13/13] monitor/QMP: Drop info hpet / query-hpet Jan Kiszka
2010-06-13 13:21 ` [Qemu-devel] Re: [PATCH v4 00/13] HPET cleanups, fixes, enhancements Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fe7afde72462d56038470e10ce29c0a9c74435b.1276431335.git.jan.kiszka@web.de \
    --to=jan.kiszka@web.de \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.