From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Daniel Kiper <daniel.kiper@oracle.com>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm64: Don't zero BSS when booting using EFI
Date: Fri, 3 Feb 2017 19:16:02 +0000 [thread overview]
Message-ID: <9feb963f-fa49-7d67-ab3f-9a0d0ec29dc5@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1702031113060.17946@sstabellini-ThinkPad-X260>
Hi Stefano,
On 03/02/17 19:14, Stefano Stabellini wrote:
> On Fri, 3 Feb 2017, Julien Grall wrote:
>> Hi Stefano,
>>
>> On 02/02/17 23:25, Stefano Stabellini wrote:
>>> On Thu, 2 Feb 2017, Julien Grall wrote:
>>>> ---
>>>> xen/arch/arm/arm64/head.S | 23 +++++++++++++++++++----
>>>> 1 file changed, 19 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
>>>> index 3f63d2a..8cb4602 100644
>>>> --- a/xen/arch/arm/arm64/head.S
>>>> +++ b/xen/arch/arm/arm64/head.S
>>>> @@ -65,7 +65,7 @@
>>>> * x23 - UART address
>>>> * x24 - cpuid
>>>> * x25 - identity map in place
>>>> - * x26 -
>>>> + * x26 - skip_zero_bss
>>>> * x27 -
>>>> * x28 -
>>>> * x29 -
>>>> @@ -232,6 +232,10 @@ section_table:
>>>> .long 0xe0500020 /* Characteristics (section flags) */
>>>> .align 5
>>>> real_start:
>>>> + /* BSS should be zeroed when booting with efi */
>>>
>>> Do you mean "without"?
>>
>> Yes.
>>
>>>
>>> Aside from that:
>>>
>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>
>> Thank you! Regarding Jan's comment ([1]) I will let you decide if I should
>> update the comments.
>
> TBH I thought that all the "to avoid nasty surprises" messages are not
> very informative, so I think it would be better to improve them, but I
> don't feel strongly about it, up to you.
I will update the comments and send a new version next week.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-03 19:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 19:25 [PATCH] xen/arm64: Don't zero BSS when booting using EFI Julien Grall
2017-02-02 23:19 ` Daniel Kiper
2017-02-02 23:25 ` Stefano Stabellini
2017-02-02 23:29 ` Andrew Cooper
2017-02-03 19:11 ` Julien Grall
2017-02-03 19:14 ` Stefano Stabellini
2017-02-03 19:16 ` Julien Grall [this message]
2017-02-03 7:41 ` Jan Beulich
2017-02-03 14:24 ` Julien Grall
2017-02-03 14:31 ` Jan Beulich
2017-02-03 14:35 ` Julien Grall
2017-02-03 14:56 ` Jan Beulich
2017-02-08 10:48 Julien Grall
2017-02-08 12:10 ` Daniel Kiper
2017-02-08 23:31 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9feb963f-fa49-7d67-ab3f-9a0d0ec29dc5@arm.com \
--to=julien.grall@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=daniel.kiper@oracle.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.