From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 1/7] MIPS: dts: Add aliases node for lantiq danube serial References: <20180612054034.4969-1-songjun.wu@linux.intel.com> <20180612054034.4969-2-songjun.wu@linux.intel.com> <20180612222424.GA2197@rob-hp-laptop> From: "Wu, Songjun" Message-ID: <9fee8672-f518-eae5-e012-bb718106217b@linux.intel.com> Date: Thu, 14 Jun 2018 14:19:35 +0800 MIME-Version: 1.0 In-Reply-To: <20180612222424.GA2197@rob-hp-laptop> Content-Type: multipart/alternative; boundary="------------7E657573CA43B7DE37B04C05" Content-Language: en-US To: Rob Herring Cc: hua.ma@linux.intel.com, yixin.zhu@linux.intel.com, chuanhua.lei@linux.intel.com, linux-mips@linux-mips.org, qi-ming.wu@intel.com, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, James Hogan , linux-kernel@vger.kernel.org, Thomas Gleixner , Philippe Ombredanne , Kate Stewart , Greg Kroah-Hartman , Mark Rutland , Ralf Baechle List-ID: This is a multi-part message in MIME format. --------------7E657573CA43B7DE37B04C05 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 6/13/2018 6:24 AM, Rob Herring wrote: > On Tue, Jun 12, 2018 at 01:40:28PM +0800, Songjun Wu wrote: >> Previous implementation uses a hard-coded register value to check if >> the current serial entity is the console entity. >> Now the lantiq serial driver uses the aliases for the index of the >> serial port. >> The lantiq danube serial dts are updated with aliases to support this. >> >> Signed-off-by: Songjun Wu >> --- >> >> arch/mips/boot/dts/lantiq/danube.dtsi | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/arch/mips/boot/dts/lantiq/danube.dtsi b/arch/mips/boot/dts/lantiq/danube.dtsi >> index 2dd950181f8a..7a9e15da6bd0 100644 >> --- a/arch/mips/boot/dts/lantiq/danube.dtsi >> +++ b/arch/mips/boot/dts/lantiq/danube.dtsi >> @@ -4,6 +4,10 @@ >> #size-cells = <1>; >> compatible = "lantiq,xway", "lantiq,danube"; >> >> + aliases { >> + serial0 = &asc1; >> + }; >> + >> cpus { >> cpu@0 { >> compatible = "mips,mips24Kc"; >> @@ -74,7 +78,7 @@ >> reg = <0xE100A00 0x100>; >> }; >> >> - serial@E100C00 { >> + asc1: serial@E100C00 { > Fix this to be lower case hex while you are at it. Thanks. All the upper case in unit-address and hex constants will be changed to lower case according to the Linux conventions. > >> compatible = "lantiq,asc"; >> reg = <0xE100C00 0x400>; >> interrupt-parent = <&icu0>; >> -- >> 2.11.0 >> --------------7E657573CA43B7DE37B04C05 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit



On 6/13/2018 6:24 AM, Rob Herring wrote:
On Tue, Jun 12, 2018 at 01:40:28PM +0800, Songjun Wu wrote:

Previous implementation uses a hard-coded register value to check if
the current serial entity is the console entity.
Now the lantiq serial driver uses the aliases for the index of the
serial port.
The lantiq danube serial dts are updated with aliases to support this.

Signed-off-by: Songjun Wu <songjun.wu@linux.intel.com>
---

 arch/mips/boot/dts/lantiq/danube.dtsi | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/lantiq/danube.dtsi b/arch/mips/boot/dts/lantiq/danube.dtsi
index 2dd950181f8a..7a9e15da6bd0 100644
--- a/arch/mips/boot/dts/lantiq/danube.dtsi
+++ b/arch/mips/boot/dts/lantiq/danube.dtsi
@@ -4,6 +4,10 @@
 	#size-cells = <1>;
 	compatible = "lantiq,xway", "lantiq,danube";
 
+	aliases {
+		serial0 = &asc1;
+	};
+
 	cpus {
 		cpu@0 {
 			compatible = "mips,mips24Kc";
@@ -74,7 +78,7 @@
 			reg = <0xE100A00 0x100>;
 		};
 
-		serial@E100C00 {
+		asc1: serial@E100C00 {

Fix this to be lower case hex while you are at it.
Thanks.
All the upper case in unit-address and hex constants will be changed to lower case according to the Linux conventions.


 			compatible = "lantiq,asc";
 			reg = <0xE100C00 0x400>;
 			interrupt-parent = <&icu0>;
-- 
2.11.0



    

    

  


--------------7E657573CA43B7DE37B04C05--