Re: [Qemu-devel] [PATCH 2/4] hw/i386/pc_sysfw: Remove obsolete PcSysFwDevice

From: Laszlo Ersek <lersek@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Max Reitz <mreitz@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] hw/i386/pc_sysfw: Remove obsolete PcSysFwDevice
Date: Tue, 5 Mar 2019 18:19:28 +0100	[thread overview]
Message-ID: <9fef26c9-d43e-0ee3-3251-162ef6f0feb6@redhat.com> (raw)
In-Reply-To: <20190304194857.9780-3-philmd@redhat.com>

On 03/04/19 20:48, Philippe Mathieu-Daudé wrote:
> This structure is not used since 6dd2a5c98a.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/i386/pc_sysfw.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c
> index 34727c5b1f..46b87afe23 100644
> --- a/hw/i386/pc_sysfw.c
> +++ b/hw/i386/pc_sysfw.c
> @@ -40,11 +40,6 @@
>  
>  #define BIOS_FILENAME "bios.bin"
>  
> -typedef struct PcSysFwDevice {
> -    SysBusDevice busdev;
> -    uint8_t isapc_ram_fw;
> -} PcSysFwDevice;
> -
>  static void pc_isa_bios_init(MemoryRegion *rom_memory,
>                               MemoryRegion *flash_mem,
>                               int ram_size)
> 

Looks sane, and the commit reference is precise.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo