From: Laszlo Ersek <lersek@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, riku.voipio@iki.fi, crosthwaite.peter@gmail.com,
sagark@eecs.berkeley.edu, kchamart@redhat.com,
kbastian@mail.uni-paderborn.de, palmer@sifive.com,
laurent@vivier.eu, armbru@redhat.com, mjc@sifive.com,
kraxel@redhat.com, pbonzini@redhat.com, thuth@redhat.com,
dgibson@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 0/6] qapi: introduce the SysEmuTarget enumeration
Date: Wed, 25 Apr 2018 14:26:44 +0200 [thread overview]
Message-ID: <9ffb6634-3480-4ad8-1c9b-e1caa8425628@redhat.com> (raw)
In-Reply-To: <152460739715.2265.8996313982715372139@71c20359a636>
On 04/25/18 00:03, no-reply@patchew.org wrote:
> Hi,
>
> This series failed docker-mingw@fedora build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
[snip]
> qapi/qapi-types-misc.h:654:20: error: expected identifier or '(' before numeric constant
> CpuInfoX86 i386;
> ^
> qapi/qapi-types-misc.h:749:22: error: expected identifier or '(' before numeric constant
> CpuInfoOther i386;
> ^
> make: *** [/tmp/qemu-test/src/rules.mak:66: qapi/qapi-types-misc.o] Error 1
> make: *** Waiting for unfinished jobs....
> qapi/qapi-types-misc.h:654:20: error: expected identifier or '(' before numeric constant
> CpuInfoX86 i386;
> ^
> qapi/qapi-types-misc.h:749:22: error: expected identifier or '(' before numeric constant
> CpuInfoOther i386;
> ^
> make: *** [/tmp/qemu-test/src/rules.mak:66: qapi/qapi-types.o] Error 1
> qapi/qapi-types-misc.h:654:20: error: expected identifier or '(' before numeric constant
> CpuInfoX86 i386;
> ^
> qapi/qapi-types-misc.h:749:22: error: expected identifier or '(' before numeric constant
> CpuInfoOther i386;
> ^
Wow, is "i386" a macro on mingw, one that expands to a number? That is
incredibly st...range.
I do need this enum constant to be "i386" in the QAPI schema, because
that's what TARGET_NAME will map to.
Can I let the generator use the "q_" prefix here somehow?
Hmm, I think that trick is already happening for "sparc":
641 struct CpuInfo {
642 /* Members inherited from CpuInfoBase: */
643 char *qom_path;
644 int64_t thread_id;
645 bool has_props;
646 CpuInstanceProperties *props;
647 CpuInfoArch arch;
648 int64_t CPU;
649 bool current;
650 bool halted;
651 SysEmuTarget target;
652 /* Own members: */
653 union { /* union tag is @target */
654 CpuInfoX86 i386;
655 CpuInfoX86 x86_64;
656 CpuInfoSPARC q_sparc; <----------------- here
Alright, I'll add "i386" to "polluted_words" in "scripts/qapi/common.py".
Sigh, what else is there already... I see Eric's commit 86ae191163d4 :(
Laszlo
next prev parent reply other threads:[~2018-04-25 12:27 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 21:45 [Qemu-devel] [PATCH 0/6] qapi: introduce the SysEmuTarget enumeration Laszlo Ersek
2018-04-24 21:45 ` [Qemu-devel] [PATCH 1/6] qapi: fill in CpuInfoFast.arch in query-cpus-fast Laszlo Ersek
2018-04-24 22:30 ` Eric Blake
2018-04-25 12:30 ` Laszlo Ersek
2018-04-25 6:39 ` Markus Armbruster
2018-04-25 12:30 ` Laszlo Ersek
2018-04-25 7:28 ` Cornelia Huck
2018-04-24 21:45 ` [Qemu-devel] [PATCH 2/6] qapi: handle the riscv CpuInfoArch " Laszlo Ersek
2018-04-24 22:32 ` Eric Blake
2018-04-25 12:32 ` Laszlo Ersek
2018-04-25 6:44 ` Markus Armbruster
2018-04-25 7:48 ` Cornelia Huck
2018-04-25 12:38 ` Viktor VM Mihajlovski
2018-04-25 12:43 ` Laszlo Ersek
2018-04-24 21:45 ` [Qemu-devel] [PATCH 3/6] qapi: add SysEmuTarget to "common.json" Laszlo Ersek
2018-04-24 23:11 ` Eric Blake
2018-04-25 12:54 ` Daniel P. Berrangé
2018-04-25 19:05 ` Laszlo Ersek
2018-04-25 19:08 ` Eric Blake
2018-04-25 22:57 ` Laszlo Ersek
2018-04-24 21:45 ` [Qemu-devel] [PATCH 4/6] qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget Laszlo Ersek
2018-04-25 6:48 ` Markus Armbruster
2018-04-25 12:58 ` Laszlo Ersek
2018-04-24 21:45 ` [Qemu-devel] [PATCH 5/6] qapi: extract CpuInfoCommon to mitigate schema duplication Laszlo Ersek
2018-04-25 7:06 ` Markus Armbruster
2018-04-25 13:20 ` Laszlo Ersek
2018-04-25 17:12 ` Markus Armbruster
2018-04-25 19:12 ` Eric Blake
2018-04-25 22:56 ` Laszlo Ersek
2018-04-26 6:19 ` Markus Armbruster
2018-04-24 21:45 ` [Qemu-devel] [PATCH 6/6] qapi: discriminate CpuInfo[Fast] on SysEmuTarget, not CpuInfoArch Laszlo Ersek
2018-04-25 7:33 ` Markus Armbruster
2018-04-25 13:47 ` Laszlo Ersek
2018-04-26 6:26 ` Markus Armbruster
2018-04-26 9:18 ` Laszlo Ersek
2018-04-26 11:57 ` Markus Armbruster
2018-04-26 13:33 ` Laszlo Ersek
2018-04-26 14:34 ` Markus Armbruster
2018-04-26 14:48 ` Eric Blake
2018-04-26 15:51 ` Markus Armbruster
2018-04-26 16:30 ` Laszlo Ersek
2018-04-27 6:53 ` Markus Armbruster
2018-04-27 13:46 ` Eric Blake
2018-04-24 22:03 ` [Qemu-devel] [PATCH 0/6] qapi: introduce the SysEmuTarget enumeration no-reply
2018-04-25 12:26 ` Laszlo Ersek [this message]
2018-04-25 14:37 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ffb6634-3480-4ad8-1c9b-e1caa8425628@redhat.com \
--to=lersek@redhat.com \
--cc=armbru@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgibson@redhat.com \
--cc=famz@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kchamart@redhat.com \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjc@sifive.com \
--cc=palmer@sifive.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.