From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Keith" Subject: Re: [RFC] checkpatch: don't complain about SPDX tag format Date: Wed, 18 Apr 2018 15:25:22 +0000 Message-ID: References: <20180417214919.8246-1-stephen@networkplumber.org> <4245883.kl7A9e8lPX@xps> <20180418085605.GA111744@bricha3-MOBL.ger.corp.intel.com> <2245312.U4dFV0f5su@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Richardson, Bruce" , Scott Branden , Stephen Hemminger , "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 90F5D8D87 for ; Wed, 18 Apr 2018 17:25:25 +0200 (CEST) In-Reply-To: <2245312.U4dFV0f5su@xps> Content-Language: en-US Content-ID: <30E1E23AD797AE4EB971945309BED659@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Apr 18, 2018, at 8:50 AM, Thomas Monjalon wrote: >=20 > 18/04/2018 10:56, Bruce Richardson: >> On Wed, Apr 18, 2018 at 12:19:07AM +0200, Thomas Monjalon wrote: >>> 18/04/2018 00:11, Scott Branden: >>>> On 18-04-17 03:06 PM, Thomas Monjalon wrote: >>>>> 17/04/2018 23:49, Stephen Hemminger: >>>>>> IMHO would have been better to use the kernel SPDX style and >>>>>> keep the check but that appears to be a minority opinion. >>>>>=20 >>>>> I think it is better to work on checkpatch itself. >>>>> When defining our SPDX style, Linux one was not definitive. >>>>> Do you think we can ask the Linux community to support our SPDX style= ? >>>>>=20 >>>> I think it better to simply follow the Linux community defacto style=20 >>>> rather than go your own way. >>>=20 >>> But our way is better! :) >>> And it has been decided in the Technical Board. >>>=20 >>=20 >> As a general issue, I think we could do with having our own checkpatch-l= ike >> script for performing addition DPDK-specific code-checks *after* Linux >> checkpatch ones. That is, reuse Linux check patch checks as much as >> possible, but have other checks too. I too believe we need to support our own checkpatch to better detect and fi= x DPDK specific issues. >=20 > +1 to call more scripts in checkpatches.sh. > We need to find the right language to do code checks. > Coccinelle looks to be a good candidate for some checks. >=20 >> For example, check for use of strcpy or strncpy (or snprintf with "%s") = and >> suggest replacing with strlcpy. If we did have our own extension script,= we >> could put our own SPDX format check there too. >>=20 >> Thoughts, or any volunteers to look into this? >=20 > I am not volunteer to start the work but I would be glad to contribute la= ter. >=20 > Any motivated volunteer? Regards, Keith