All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-bluetooth@vger.kernel.org, Phil Elwell <phil@raspberrypi.org>
Subject: Re: [PATCH] hciattach: bcm43xx: delay reset after firmware download
Date: Wed, 1 Feb 2017 20:50:10 +0100	[thread overview]
Message-ID: <A0AA909E-8FF1-48A8-90C3-6C7BB2FCB1D1@holtmann.org> (raw)
In-Reply-To: <c23b80351e1a4046f1c0087d2243ed4dc16c0d37.1485697508.git.baruch@tkos.co.il>

Hi Baruch,

> The BCM43438 chip on the Raspberry Pi 3 board needs a delay after firmware
> download for the setup to complete successfully.
> 
> Based on Yocto patch from Phil Elwell.
> ---
> tools/hciattach_bcm43xx.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/tools/hciattach_bcm43xx.c b/tools/hciattach_bcm43xx.c
> index 81f38cbbcf92..1140379d5cc4 100644
> --- a/tools/hciattach_bcm43xx.c
> +++ b/tools/hciattach_bcm43xx.c
> @@ -380,6 +380,7 @@ int bcm43xx_init(int fd, int def_speed, int speed, struct termios *ti,
> 			return -1;
> 		}
> 
> +		sleep(1);
> 		if (bcm43xx_reset(fd))
> 			return -1;
> 	}

any reason not to use the hci_bcm driver support in recent kernels? That would be a lot better than hacking the old hciattach code.

Regards

Marcel


  reply	other threads:[~2017-02-01 19:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-29 13:45 [PATCH] hciattach: bcm43xx: delay reset after firmware download Baruch Siach
2017-02-01 19:50 ` Marcel Holtmann [this message]
2017-02-01 20:10   ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A0AA909E-8FF1-48A8-90C3-6C7BB2FCB1D1@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=baruch@tkos.co.il \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=phil@raspberrypi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.