All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gilles <gilles@gigadevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] bav335x support broken
Date: Fri, 13 Mar 2015 22:06:51 -0700	[thread overview]
Message-ID: <A0D2FA3B-F9FB-4F11-B489-BFA7CE23665D@gigadevices.com> (raw)

Folks,

I posted a patch to add support for bav335x boards (a322aad99de4). The patch was tested against v2015.04-rc1 and worked perfectly but somehow, something was introduced since then which breaks the board support.

There are two main errors I need to fix before posting another patch but need help with the second error. 

The first error is easy. Compilation throws:
#error "Please define NS16550 registers size."
which I can simply fix by defining CONFIG_SYS_NS16550_REG_SIZE in include/configs/bav335x.h
((( Altough I am stil puzzled as to why this was defined as -4 (where?) on v2015.04-rc1 )))

After adding the define, everything compiles up to failing on the final link with:

drivers/serial/built-in.o: In function `get_current':
/home/gilles/bbdev/u-boot/drivers/serial/serial.c:389: undefined reference to `default_serial_console'
drivers/serial/built-in.o: In function `serial_initialize':

Can anyone please explain what changed between 2015.04-rc1 and 2015.04-rc2 which could cause such a behavior? I have spent the last couple hours re-basing a branch to see where it breaks as to maybe get a clue on what changed but no luck so far. Any tips would be appreciated.

Thanks,
Gilles
.

             reply	other threads:[~2015-03-14  5:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-14  5:06 Gilles [this message]
2015-03-14 17:55 ` [U-Boot] bav335x support broken Anish Khurana
2015-03-14 21:47   ` Albert ARIBAUD
2015-03-16  6:32   ` Gilles
2015-03-16 16:14     ` Anish Khurana
2015-03-17  8:09       ` Gilles
2015-03-17  8:56         ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A0D2FA3B-F9FB-4F11-B489-BFA7CE23665D@gigadevices.com \
    --to=gilles@gigadevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.