From: Park, Aiden <aiden.park@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] x86: Drop weak version board_get_usable_ram_top()
Date: Thu, 29 Aug 2019 20:46:02 +0000 [thread overview]
Message-ID: <A1484485FD99714DB2AB2C5EF81E7AC2AA7B222B@ORSMSX116.amr.corp.intel.com> (raw)
In-Reply-To: <aaea37f9-4bd8-1165-b996-aa687262eaa7@gmx.de>
> -----Original Message-----
> From: Heinrich Schuchardt [mailto:xypron.glpk at gmx.de]
> Sent: Thursday, August 29, 2019 12:27 PM
> To: Bin Meng <bmeng.cn@gmail.com>; Simon Glass <sjg@chromium.org>; Park,
> Aiden <aiden.park@intel.com>; U-Boot Mailing List <u-boot@lists.denx.de>
> Subject: Re: [PATCH 1/4] x86: Drop weak version board_get_usable_ram_top()
>
> On 8/29/19 11:53 AM, Bin Meng wrote:
> > Every x86 platform provides board_get_usable_ram_top(), hence there is
> > no need to provide a weak version board_get_usable_ram_top(), not to
> > mention there is another weak version board_get_usable_ram_top() in
> > common/board_f.c.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
Reviewed-by: Aiden Park <aiden.park@intel.com>
> > ---
> >
> > arch/x86/lib/init_helpers.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/arch/x86/lib/init_helpers.c b/arch/x86/lib/init_helpers.c
> > index 5e19f13..4774a9b 100644
> > --- a/arch/x86/lib/init_helpers.c
> > +++ b/arch/x86/lib/init_helpers.c
> > @@ -10,12 +10,6 @@
> >
> > DECLARE_GLOBAL_DATA_PTR;
> >
> > -/* Get the top of usable RAM */
> > -__weak ulong board_get_usable_ram_top(ulong total_size) -{
> > - return gd->ram_size;
> > -}
> > -
> > int init_cache_f_r(void)
> > {
> > #if CONFIG_IS_ENABLED(X86_32BIT_INIT) && !defined(CONFIG_HAVE_FSP)
> > && \
> >
next prev parent reply other threads:[~2019-08-29 20:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 9:53 [U-Boot] [PATCH 1/4] x86: Drop weak version board_get_usable_ram_top() Bin Meng
2019-08-29 9:53 ` [U-Boot] [PATCH 2/4] x86: qemu: Extract getting memory size to a separate routine Bin Meng
2019-09-03 16:54 ` Park, Aiden
2019-09-10 6:17 ` Bin Meng
2019-08-29 9:53 ` [U-Boot] [PATCH 3/4] x86: qemu: Support getting high memory size Bin Meng
2019-09-03 16:55 ` Park, Aiden
2019-09-10 6:17 ` Bin Meng
2019-08-29 9:53 ` [U-Boot] [PATCH 4/4] x86: qemu: Report high memory in the E820 table Bin Meng
2019-09-03 16:56 ` Park, Aiden
2019-09-10 6:17 ` Bin Meng
2019-08-29 19:27 ` [U-Boot] [PATCH 1/4] x86: Drop weak version board_get_usable_ram_top() Heinrich Schuchardt
2019-08-29 20:46 ` Park, Aiden [this message]
2019-09-10 6:17 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A1484485FD99714DB2AB2C5EF81E7AC2AA7B222B@ORSMSX116.amr.corp.intel.com \
--to=aiden.park@intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.