From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nadav Amit Subject: Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks Date: Mon, 13 Apr 2015 17:33:03 +0300 Message-ID: References: <1428881529-29459-1-git-send-email-namit@cs.technion.ac.il> <1428881529-29459-3-git-send-email-namit@cs.technion.ac.il> <552BCF05.8020504@redhat.com> <552BD1B7.4080103@redhat.com> Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Nadav Amit , Jan Kiszka , Bandan Das , qemu-devel@nongnu.org, kvm list , avi.kivity@gmail.com To: Paolo Bonzini Return-path: Received: from mail-wg0-f54.google.com ([74.125.82.54]:35715 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932099AbbDMOdH convert rfc822-to-8bit (ORCPT ); Mon, 13 Apr 2015 10:33:07 -0400 Received: by wgyo15 with SMTP id o15so83263236wgy.2 for ; Mon, 13 Apr 2015 07:33:06 -0700 (PDT) In-Reply-To: <552BD1B7.4080103@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Paolo Bonzini wrote: >=20 >=20 > On 13/04/2015 16:17, Nadav Amit wrote: >> Paolo Bonzini wrote: >>=20 >>> On 13/04/2015 01:32, Nadav Amit wrote: >>>> + if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) { >>>=20 >>> The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not >>> KVM_CAP_ENABLE_CAP_VM. >>>=20 >>> Paolo >>>=20 >>>> + ret =3D kvm_vm_enable_cap(s, KVM_CAP_DISABLE_QUIRKS, 0, >>>> + KVM_QUIRK_LINT0_DISABLED | >>>> + KVM_QUIRK_CD_NW_CLEARED); >>>> + if (ret < 0) { >>>> + return ret; >>>> + } >>>> + } >>=20 >> Of course=85 >> Do you want a v2 now, later (after 4.2), or would you change it your= self? >=20 > Later, close to 4.2 but not necessarily after it. Anyhow, in that case the KVM patch is also wrong (not reporting KVM_CAP_DISABLE_QUIRKS is supported). I don=92t want to spam, so I=92ll= run some tests and resubmit. Nadav From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhfQI-0007i5-2r for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:33:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhfQB-0000r6-PF for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:33:14 -0400 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:38059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhfQB-0000qq-JF for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:33:07 -0400 Received: by wiun10 with SMTP id n10so69037790wiu.1 for ; Mon, 13 Apr 2015 07:33:06 -0700 (PDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) From: Nadav Amit In-Reply-To: <552BD1B7.4080103@redhat.com> Date: Mon, 13 Apr 2015 17:33:03 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <1428881529-29459-1-git-send-email-namit@cs.technion.ac.il> <1428881529-29459-3-git-send-email-namit@cs.technion.ac.il> <552BCF05.8020504@redhat.com> <552BD1B7.4080103@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kvm list , Nadav Amit , Jan Kiszka , qemu-devel@nongnu.org, Bandan Das , avi.kivity@gmail.com Paolo Bonzini wrote: >=20 >=20 > On 13/04/2015 16:17, Nadav Amit wrote: >> Paolo Bonzini wrote: >>=20 >>> On 13/04/2015 01:32, Nadav Amit wrote: >>>> + if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) { >>>=20 >>> The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not >>> KVM_CAP_ENABLE_CAP_VM. >>>=20 >>> Paolo >>>=20 >>>> + ret =3D kvm_vm_enable_cap(s, KVM_CAP_DISABLE_QUIRKS, 0, >>>> + KVM_QUIRK_LINT0_DISABLED | >>>> + KVM_QUIRK_CD_NW_CLEARED); >>>> + if (ret < 0) { >>>> + return ret; >>>> + } >>>> + } >>=20 >> Of course=85 >> Do you want a v2 now, later (after 4.2), or would you change it = yourself? >=20 > Later, close to 4.2 but not necessarily after it. Anyhow, in that case the KVM patch is also wrong (not reporting KVM_CAP_DISABLE_QUIRKS is supported). I don=92t want to spam, so I=92ll = run some tests and resubmit. Nadav=