From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhao1, Wei" Subject: Re: [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF Date: Wed, 13 Feb 2019 03:36:02 +0000 Message-ID: References: <1547613775-58027-1-git-send-email-wei.zhao1@intel.com> <1547614920-59680-1-git-send-email-wei.zhao1@intel.com> <1547614920-59680-2-git-send-email-wei.zhao1@intel.com> <039ED4275CED7440929022BC67E7061153333BB6@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "stable@dpdk.org" , "Lu, Wenzhuo" To: "Zhang, Qi Z" , "dev@dpdk.org" Return-path: In-Reply-To: <039ED4275CED7440929022BC67E7061153333BB6@SHSMSX103.ccr.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, February 13, 2019 11:35 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: stable@dpdk.org; Lu, Wenzhuo > Subject: RE: [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF >=20 >=20 >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Wednesday, January 16, 2019 1:02 PM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Lu, Wenzhuo ; Zhang, Qi Z > > ; Zhao1, Wei > > Subject: [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF > > > > There is need to enable two ops of promiscuous_enable and > > promiscuous_disable on VF. > > > > Fixes: af75078fece3 ("first public release") >=20 > I think this is not a fix, we just add some feature not be implemented. >=20 > Btw, you need to update doc/guides/nics/features/ixgbe_vf.ini Ok, I will update in v3 >=20 > > > > Signed-off-by: Wei Zhao > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index 91ba620..e8a2c6e 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -260,6 +260,8 @@ static int > > ixgbevf_dev_rx_queue_intr_disable(struct > > rte_eth_dev *dev, static void ixgbevf_set_ivar_map(struct ixgbe_hw > > *hw, int8_t direction, > > uint8_t queue, uint8_t msix_vector); static > void > > ixgbevf_configure_msix(struct rte_eth_dev *dev); > > +static void ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev); > > +static void ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev); > > static void ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev); > > static void ixgbevf_dev_allmulticast_disable(struct rte_eth_dev *dev); > > > > @@ -596,6 +598,8 @@ static const struct eth_dev_ops > ixgbevf_eth_dev_ops =3D { > > .xstats_get_names =3D ixgbevf_dev_xstats_get_names, > > .dev_close =3D ixgbevf_dev_close, > > .dev_reset =3D ixgbevf_dev_reset, > > + .promiscuous_enable =3D ixgbevf_dev_promiscuous_enable, > > + .promiscuous_disable =3D ixgbevf_dev_promiscuous_disable, > > .allmulticast_enable =3D ixgbevf_dev_allmulticast_enable, > > .allmulticast_disable =3D ixgbevf_dev_allmulticast_disable, > > .dev_infos_get =3D ixgbevf_dev_info_get, > > @@ -8290,6 +8294,22 @@ ixgbe_dev_udp_tunnel_port_del(struct > > rte_eth_dev *dev, } > > > > static void > > +ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev) { > > + struct ixgbe_hw *hw =3D > > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > > + > > + hw->mac.ops.update_xcast_mode(hw, > > IXGBEVF_XCAST_MODE_PROMISC); } > > + > > +static void > > +ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev) { > > + struct ixgbe_hw *hw =3D > > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > > + > > + hw->mac.ops.update_xcast_mode(hw, > IXGBEVF_XCAST_MODE_NONE); } > > + > > +static void > > ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev) { > > struct ixgbe_hw *hw =3D > > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > > -- > > 2.7.5