All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix x550 reta set fail error
Date: Tue, 23 Jul 2019 03:20:54 +0000	[thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07F25631@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <1563775495-13785-1-git-send-email-wei.zhao1@intel.com>

Tested-by: Zhao  HaiyangX <haiyangx.zhao@intel.com>


> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, July 22, 2019 2:05 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH] net/ixgbe: fix x550 reta set fail error
> 
> There is a bug in function ixgbevf_dev_info_get(), it do not contain the reta
> table size get function for vf port, and this will cause error when update reta
> for x550 vf port.
> 
> Cc: stable@dpdk.org
> 
> Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info")
> Signed-off-by: wei zhao <wei.zhao1@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 22c5b2c..773f667 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3927,6 +3927,8 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
>  				     dev_info->rx_queue_offload_capa);
>  	dev_info->tx_queue_offload_capa = ixgbe_get_tx_queue_offloads(dev);
>  	dev_info->tx_offload_capa = ixgbe_get_tx_port_offloads(dev);
> +	dev_info->hash_key_size = IXGBE_HKEY_MAX_INDEX * sizeof(uint32_t);
> +	dev_info->reta_size = ixgbe_reta_size_get(hw->mac.type);
> 
>  	dev_info->default_rxconf = (struct rte_eth_rxconf) {
>  		.rx_thresh = {
> @@ -7438,6 +7440,9 @@ ixgbe_reta_size_get(enum ixgbe_mac_type
> mac_type) {
>  	case ixgbe_mac_X550EM_x_vf:
>  	case ixgbe_mac_X550EM_a_vf:
>  		return ETH_RSS_RETA_SIZE_64;
> +	case ixgbe_mac_X540_vf:
> +	case ixgbe_mac_82599_vf:
> +		return 0;
>  	default:
>  		return ETH_RSS_RETA_SIZE_128;
>  	}
> --
> 2.7.5


  reply	other threads:[~2019-07-23  3:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22  6:04 [dpdk-dev] [PATCH] net/ixgbe: fix x550 reta set fail error Wei Zhao
2019-07-23  3:20 ` Zhao1, Wei [this message]
2019-07-23  3:21 ` Zhao1, Wei
2019-07-23  4:11 ` [dpdk-dev] [PATCH v2] net/ixgbe: fix x550 Reta " Wei Zhao
2019-07-23  4:13 ` Wei Zhao
2019-07-23  7:30   ` Zhang, Qi Z
2019-07-23 22:15   ` Ye Xiaolong
2019-07-26  1:38   ` [dpdk-dev] [PATCH v3] net/ixgbe: fix Reta size for VF Wei Zhao
2019-07-26  4:54     ` Zhang, Qi Z
2019-07-26  5:52       ` Zhao1, Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07F25631@PGSMSX103.gar.corp.intel.com \
    --to=wei.zhao1@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.