From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F07AC5DF60 for ; Wed, 6 Nov 2019 01:31:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0FDE21D7F for ; Wed, 6 Nov 2019 01:31:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730543AbfKFBbn convert rfc822-to-8bit (ORCPT ); Tue, 5 Nov 2019 20:31:43 -0500 Received: from mga18.intel.com ([134.134.136.126]:22209 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729614AbfKFBbm (ORCPT ); Tue, 5 Nov 2019 20:31:42 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2019 17:31:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,272,1569308400"; d="scan'208";a="192300324" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 05 Nov 2019 17:31:41 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 Nov 2019 17:31:41 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.41]) with mapi id 14.03.0439.000; Wed, 6 Nov 2019 09:31:39 +0800 From: "Liu, Yi L" To: Alex Williamson CC: "Tian, Kevin" , "eric.auger@redhat.com" , "jacob.jun.pan@linux.intel.com" , "joro@8bytes.org" , "Raj, Ashok" , "Tian, Jun J" , "Sun, Yi Y" , "jean-philippe.brucker@arm.com" , "peterx@redhat.com" , "iommu@lists.linux-foundation.org" , "kvm@vger.kernel.org" Subject: RE: [RFC v2 1/3] vfio: VFIO_IOMMU_CACHE_INVALIDATE Thread-Topic: [RFC v2 1/3] vfio: VFIO_IOMMU_CACHE_INVALIDATE Thread-Index: AQHVimn1O4LuhvsTnkSBp1bprAulHadqjiuAgACo1uCAEYKkAIAAsxbg Date: Wed, 6 Nov 2019 01:31:38 +0000 Message-ID: References: <1571919983-3231-1-git-send-email-yi.l.liu@intel.com> <1571919983-3231-2-git-send-email-yi.l.liu@intel.com> <20191105154224.3b894a9c@x1.home> In-Reply-To: <20191105154224.3b894a9c@x1.home> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmFmYmQwY2UtMmRjZC00NWNiLWIxMDctOGJlODA0N2ExN2Y5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ2FESktmTnp3SFBnU0dpSmlrejRFTGd0TXNGK3lsMkN2UGt6V0E1cVNNRjVrSjBXdEVsMGhEQTVNVFpIdFwvS0oifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org > From: Alex Williamson [mailto:alex.williamson@redhat.com] > Sent: Wednesday, November 6, 2019 6:42 AM > To: Liu, Yi L > Subject: Re: [RFC v2 1/3] vfio: VFIO_IOMMU_CACHE_INVALIDATE > > On Fri, 25 Oct 2019 11:20:40 +0000 > "Liu, Yi L" wrote: > > > Hi Kevin, > > > > > From: Tian, Kevin > > > Sent: Friday, October 25, 2019 5:14 PM > > > To: Liu, Yi L ; alex.williamson@redhat.com; > > > Subject: RE: [RFC v2 1/3] vfio: VFIO_IOMMU_CACHE_INVALIDATE > > > > > > > From: Liu, Yi L > > > > Sent: Thursday, October 24, 2019 8:26 PM > > > > > > > > From: Liu Yi L > > > > > > > > When the guest "owns" the stage 1 translation structures, the > > > > host IOMMU driver has no knowledge of caching structure updates > > > > unless the guest invalidation requests are trapped and passed down to the host. > > > > > > > > This patch adds the VFIO_IOMMU_CACHE_INVALIDATE ioctl with aims at > > > > propagating guest stage1 IOMMU cache invalidations to the host. > > > > > > > > Cc: Kevin Tian > > > > Signed-off-by: Liu Yi L > > > > Signed-off-by: Eric Auger > > > > Signed-off-by: Jacob Pan > > > > --- > > > > drivers/vfio/vfio_iommu_type1.c | 55 > > > > +++++++++++++++++++++++++++++++++++++++++ > > > > include/uapi/linux/vfio.h | 13 ++++++++++ > > > > 2 files changed, 68 insertions(+) > > > > > > > > diff --git a/drivers/vfio/vfio_iommu_type1.c > > > > b/drivers/vfio/vfio_iommu_type1.c index 96fddc1d..cd8d3a5 100644 > > > > --- a/drivers/vfio/vfio_iommu_type1.c > > > > +++ b/drivers/vfio/vfio_iommu_type1.c > > > > @@ -124,6 +124,34 @@ struct vfio_regions { > > > > #define IS_IOMMU_CAP_DOMAIN_IN_CONTAINER(iommu) \ > > > > (!list_empty(&iommu->domain_list)) > > > > > > > > +struct domain_capsule { > > > > + struct iommu_domain *domain; > > > > + void *data; > > > > +}; > > > > + > > > > +/* iommu->lock must be held */ > > > > +static int > > > > +vfio_iommu_lookup_dev(struct vfio_iommu *iommu, > > > > + int (*fn)(struct device *dev, void *data), > > > > + void *data) > > > > > > 'lookup' usually means find a device and then return. But the real > > > purpose here is to loop all the devices within this container and > > > then do something. Does it make more sense to be vfio_iommu_for_each_dev? > > +1 > > > yep, I can replace it. > > > > > > > > > +{ > > > > + struct domain_capsule dc = {.data = data}; > > > > + struct vfio_domain *d; > > [...] > > > 2315,6 +2352,24 @@ > > > > static long vfio_iommu_type1_ioctl(void *iommu_data, > > > > > > > > return copy_to_user((void __user *)arg, &unmap, minsz) ? > > > > -EFAULT : 0; > > > > + } else if (cmd == VFIO_IOMMU_CACHE_INVALIDATE) { > > > > + struct vfio_iommu_type1_cache_invalidate ustruct; > > > > > > it's weird to call a variable as struct. > > > > Will fix it. > > > > > > + int ret; > > > > + > > > > + minsz = offsetofend(struct > > > > vfio_iommu_type1_cache_invalidate, > > > > + info); > > > > + > > > > + if (copy_from_user(&ustruct, (void __user *)arg, minsz)) > > > > + return -EFAULT; > > > > + > > > > + if (ustruct.argsz < minsz || ustruct.flags) > > > > + return -EINVAL; > > > > + > > > > + mutex_lock(&iommu->lock); > > > > + ret = vfio_iommu_lookup_dev(iommu, vfio_cache_inv_fn, > > > > + &ustruct); > > > > + mutex_unlock(&iommu->lock); > > > > + return ret; > > > > } > > > > > > > > return -ENOTTY; > > > > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > > > > index 9e843a1..ccf60a2 100644 > > > > --- a/include/uapi/linux/vfio.h > > > > +++ b/include/uapi/linux/vfio.h > > > > @@ -794,6 +794,19 @@ struct vfio_iommu_type1_dma_unmap { > > > > #define VFIO_IOMMU_ENABLE _IO(VFIO_TYPE, VFIO_BASE + 15) > > > > #define VFIO_IOMMU_DISABLE _IO(VFIO_TYPE, VFIO_BASE + 16) > > > > > > > > +/** > > > > + * VFIO_IOMMU_CACHE_INVALIDATE - _IOWR(VFIO_TYPE, VFIO_BASE + > > > > 24, > > What's going on with these ioctl numbers? AFAICT[1] we've used up through > VFIO_BASE + 21, this jumps to 24, the next patch skips to 27, then the last patch fills > in 28 & 29. Thanks, Hi Alex, I rebase my patch to Eric's nested stage translation patches. His base also introduced IOCTLs. I should have made it better. I'll try to sync with Eric to serialize the IOCTLs. [PATCH v6 00/22] SMMUv3 Nested Stage Setup by Eric Auger https://lkml.org/lkml/2019/3/17/124 Thanks, Yi Liu > Alex > > [1] git grep -h VFIO_BASE | grep "VFIO_BASE +" | grep -e ^#define | \ > awk '{print $NF}' | tr -d ')' | sort -u -n From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD4F6C5DF62 for ; Wed, 6 Nov 2019 01:31:44 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8155921929 for ; Wed, 6 Nov 2019 01:31:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8155921929 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 69FF7CDB; Wed, 6 Nov 2019 01:31:44 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id A8845CCC for ; Wed, 6 Nov 2019 01:31:43 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1434E5D0 for ; Wed, 6 Nov 2019 01:31:42 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2019 17:31:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,272,1569308400"; d="scan'208";a="192300324" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 05 Nov 2019 17:31:41 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 Nov 2019 17:31:41 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.41]) with mapi id 14.03.0439.000; Wed, 6 Nov 2019 09:31:39 +0800 From: "Liu, Yi L" To: Alex Williamson Subject: RE: [RFC v2 1/3] vfio: VFIO_IOMMU_CACHE_INVALIDATE Thread-Topic: [RFC v2 1/3] vfio: VFIO_IOMMU_CACHE_INVALIDATE Thread-Index: AQHVimn1O4LuhvsTnkSBp1bprAulHadqjiuAgACo1uCAEYKkAIAAsxbg Date: Wed, 6 Nov 2019 01:31:38 +0000 Message-ID: References: <1571919983-3231-1-git-send-email-yi.l.liu@intel.com> <1571919983-3231-2-git-send-email-yi.l.liu@intel.com> <20191105154224.3b894a9c@x1.home> In-Reply-To: <20191105154224.3b894a9c@x1.home> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmFmYmQwY2UtMmRjZC00NWNiLWIxMDctOGJlODA0N2ExN2Y5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ2FESktmTnp3SFBnU0dpSmlrejRFTGd0TXNGK3lsMkN2UGt6V0E1cVNNRjVrSjBXdEVsMGhEQTVNVFpIdFwvS0oifQ== x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Cc: "Tian, Kevin" , "Raj, Ashok" , "kvm@vger.kernel.org" , "jean-philippe.brucker@arm.com" , "Tian, Jun J" , "iommu@lists.linux-foundation.org" , "Sun, Yi Y" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org > From: Alex Williamson [mailto:alex.williamson@redhat.com] > Sent: Wednesday, November 6, 2019 6:42 AM > To: Liu, Yi L > Subject: Re: [RFC v2 1/3] vfio: VFIO_IOMMU_CACHE_INVALIDATE > > On Fri, 25 Oct 2019 11:20:40 +0000 > "Liu, Yi L" wrote: > > > Hi Kevin, > > > > > From: Tian, Kevin > > > Sent: Friday, October 25, 2019 5:14 PM > > > To: Liu, Yi L ; alex.williamson@redhat.com; > > > Subject: RE: [RFC v2 1/3] vfio: VFIO_IOMMU_CACHE_INVALIDATE > > > > > > > From: Liu, Yi L > > > > Sent: Thursday, October 24, 2019 8:26 PM > > > > > > > > From: Liu Yi L > > > > > > > > When the guest "owns" the stage 1 translation structures, the > > > > host IOMMU driver has no knowledge of caching structure updates > > > > unless the guest invalidation requests are trapped and passed down to the host. > > > > > > > > This patch adds the VFIO_IOMMU_CACHE_INVALIDATE ioctl with aims at > > > > propagating guest stage1 IOMMU cache invalidations to the host. > > > > > > > > Cc: Kevin Tian > > > > Signed-off-by: Liu Yi L > > > > Signed-off-by: Eric Auger > > > > Signed-off-by: Jacob Pan > > > > --- > > > > drivers/vfio/vfio_iommu_type1.c | 55 > > > > +++++++++++++++++++++++++++++++++++++++++ > > > > include/uapi/linux/vfio.h | 13 ++++++++++ > > > > 2 files changed, 68 insertions(+) > > > > > > > > diff --git a/drivers/vfio/vfio_iommu_type1.c > > > > b/drivers/vfio/vfio_iommu_type1.c index 96fddc1d..cd8d3a5 100644 > > > > --- a/drivers/vfio/vfio_iommu_type1.c > > > > +++ b/drivers/vfio/vfio_iommu_type1.c > > > > @@ -124,6 +124,34 @@ struct vfio_regions { > > > > #define IS_IOMMU_CAP_DOMAIN_IN_CONTAINER(iommu) \ > > > > (!list_empty(&iommu->domain_list)) > > > > > > > > +struct domain_capsule { > > > > + struct iommu_domain *domain; > > > > + void *data; > > > > +}; > > > > + > > > > +/* iommu->lock must be held */ > > > > +static int > > > > +vfio_iommu_lookup_dev(struct vfio_iommu *iommu, > > > > + int (*fn)(struct device *dev, void *data), > > > > + void *data) > > > > > > 'lookup' usually means find a device and then return. But the real > > > purpose here is to loop all the devices within this container and > > > then do something. Does it make more sense to be vfio_iommu_for_each_dev? > > +1 > > > yep, I can replace it. > > > > > > > > > +{ > > > > + struct domain_capsule dc = {.data = data}; > > > > + struct vfio_domain *d; > > [...] > > > 2315,6 +2352,24 @@ > > > > static long vfio_iommu_type1_ioctl(void *iommu_data, > > > > > > > > return copy_to_user((void __user *)arg, &unmap, minsz) ? > > > > -EFAULT : 0; > > > > + } else if (cmd == VFIO_IOMMU_CACHE_INVALIDATE) { > > > > + struct vfio_iommu_type1_cache_invalidate ustruct; > > > > > > it's weird to call a variable as struct. > > > > Will fix it. > > > > > > + int ret; > > > > + > > > > + minsz = offsetofend(struct > > > > vfio_iommu_type1_cache_invalidate, > > > > + info); > > > > + > > > > + if (copy_from_user(&ustruct, (void __user *)arg, minsz)) > > > > + return -EFAULT; > > > > + > > > > + if (ustruct.argsz < minsz || ustruct.flags) > > > > + return -EINVAL; > > > > + > > > > + mutex_lock(&iommu->lock); > > > > + ret = vfio_iommu_lookup_dev(iommu, vfio_cache_inv_fn, > > > > + &ustruct); > > > > + mutex_unlock(&iommu->lock); > > > > + return ret; > > > > } > > > > > > > > return -ENOTTY; > > > > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > > > > index 9e843a1..ccf60a2 100644 > > > > --- a/include/uapi/linux/vfio.h > > > > +++ b/include/uapi/linux/vfio.h > > > > @@ -794,6 +794,19 @@ struct vfio_iommu_type1_dma_unmap { > > > > #define VFIO_IOMMU_ENABLE _IO(VFIO_TYPE, VFIO_BASE + 15) > > > > #define VFIO_IOMMU_DISABLE _IO(VFIO_TYPE, VFIO_BASE + 16) > > > > > > > > +/** > > > > + * VFIO_IOMMU_CACHE_INVALIDATE - _IOWR(VFIO_TYPE, VFIO_BASE + > > > > 24, > > What's going on with these ioctl numbers? AFAICT[1] we've used up through > VFIO_BASE + 21, this jumps to 24, the next patch skips to 27, then the last patch fills > in 28 & 29. Thanks, Hi Alex, I rebase my patch to Eric's nested stage translation patches. His base also introduced IOCTLs. I should have made it better. I'll try to sync with Eric to serialize the IOCTLs. [PATCH v6 00/22] SMMUv3 Nested Stage Setup by Eric Auger https://lkml.org/lkml/2019/3/17/124 Thanks, Yi Liu > Alex > > [1] git grep -h VFIO_BASE | grep "VFIO_BASE +" | grep -e ^#define | \ > awk '{print $NF}' | tr -d ')' | sort -u -n _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu