From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754011AbbIQJ6V (ORCPT ); Thu, 17 Sep 2015 05:58:21 -0400 Received: from usevmg21.ericsson.net ([198.24.6.65]:61360 "EHLO usevmg21.ericsson.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753411AbbIQJ6R convert rfc822-to-8bit (ORCPT ); Thu, 17 Sep 2015 05:58:17 -0400 X-AuditID: c6180641-f792c6d00000686a-be-55fa23bb7d0f From: Jon Maloy To: Andrzej Hajda , Ying Xue CC: Bartlomiej Zolnierkiewicz , Marek Szyprowski , "linux-kernel@vger.kernel.org" , "David S. Miller" , "netdev@vger.kernel.org" Subject: RE: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation Thread-Topic: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation Thread-Index: AQHQ0OcvWiyL3WyLhUO4nm3P5Nnte54/cC6AgAFMkBA= Date: Thu, 17 Sep 2015 09:58:08 +0000 Message-ID: References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-28-git-send-email-a.hajda@samsung.com> <55F93F55.70505@samsung.com> In-Reply-To: <55F93F55.70505@samsung.com> Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [147.117.188.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeLIzCtJLcpLzFFi42KZXLonVne38q9Qg8vnNC1urTvHarFxxnpW iznnW1gsLu+aw2ax9shddotjC8QsHl+/zuzA7rFl5U0mj74tqxg9Pm+S81i/ZStTAEsUl01K ak5mWWqRvl0CV8a6Y3fYChZzV/zpbmNsYGzm7GLk5JAQMJGYPXETM4QtJnHh3nq2LkYuDiGB o4wSza0rWCGc5YwSa060s4BUsQloSLyc1sEIYosIeElM+vMJrINZoI1JYurzD0wgCWGBWInu 21/YIIriJG59esYCYVtJrNj5FWwdi4CqxOdVl8DqeQV8JQ6tmsAOsW02o8TyY5/ANnAKaErs 2/YSrJlRQFZi99nrYA3MAuISt57MZ4K4W0BiyZ7zUD+ISrx8/I8VwlaSmLT0HCtEvY7Egt2f 2CBsbYllC18zQywWlDg58wnLBEaxWUjGzkLSMgtJyywkLQsYWVYxcpQWp5blphsZbmIERtsx CTbHHYwLPlkeYhTgYFTi4U149jNUiDWxrLgy9xCjNAeLkjjvvBn3Q4UE0hNLUrNTUwtSi+KL SnNSiw8xMnFwSjUwrnsosVpKbo948mSvwBclLFcmbzj9cLfLiZkrROd2Lks/Ks9V5eurZrP5 uqyUclvS48OBu62fuvy2rly+0cpdTOiCsY3ove9diaqH+r02eb3ctGjVghts7yKl1Wd9Pu35 uTL32dMaq2X7E5wMQmQYRI9NTuLuuWPIk5NddkzjiLteucwxg/LJSizFGYmGWsxFxYkAcRaY rZcCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Jon Maloy ///jon > -----Original Message----- > From: Andrzej Hajda [mailto:a.hajda@samsung.com] > Sent: Wednesday, 16 September, 2015 06:07 > To: Jon Maloy; Ying Xue > Cc: Bartlomiej Zolnierkiewicz; Marek Szyprowski; linux- > kernel@vger.kernel.org; David S. Miller; netdev@vger.kernel.org > Subject: Re: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its > implementation > > Ping. > > Regards > Andrzej > > On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > > The patch was generated using fixed coccinelle semantic patch > > scripts/coccinelle/api/memdup.cocci [1]. > > > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > > > Signed-off-by: Andrzej Hajda > > --- > > net/tipc/server.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/net/tipc/server.c b/net/tipc/server.c index > > 922e04a..c187cad 100644 > > --- a/net/tipc/server.c > > +++ b/net/tipc/server.c > > @@ -411,13 +411,12 @@ static struct outqueue_entry > *tipc_alloc_entry(void *data, int len) > > if (!entry) > > return NULL; > > > > - buf = kmalloc(len, GFP_ATOMIC); > > + buf = kmemdup(data, len, GFP_ATOMIC); > > if (!buf) { > > kfree(entry); > > return NULL; > > } > > > > - memcpy(buf, data, len); > > entry->iov.iov_base = buf; > > entry->iov.iov_len = len; > >