All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Haxby <jch@thehaxbys.co.uk>
To: Prarit Bhargava <prarit@redhat.com>
Cc: David Miller <davem@davemloft.net>,
	Florian Westphal <fw@strlen.de>,
	fbl@redhat.com, netdev@vger.kernel.org, agospoda@redhat.com,
	nhorman@redhat.com, lwoodman@redhat.com
Subject: Re: [PATCH]: Add Network Sysrq Support
Date: Wed, 22 Jun 2011 19:57:11 +0100	[thread overview]
Message-ID: <A2D02CF4-27C4-4A6E-A322-8D04C15EF3F3@oracle.com> (raw)
In-Reply-To: <4E0228C3.8090402@redhat.com>


On 22 Jun 2011, at 18:39, Prarit Bhargava wrote:

> 
>> Although I wasn't sure that it could happen, it's also possible that the
>> cryptographic functions can get in your way.  xt_SYSRQ does its best to
>> avoid problems by pre-allocating everything it can so there is as little
>> as possible to do when it is needed, but it is possible for it to fail.
>> 
>> 
> 
> My running theory as to the failure is that the CPU that took the sysrq
> is also the CPU that was having problems that resulted in the "slow
> down" of the system.
> 
> On a known-good system, xt_SYSRQ behaves properly AFAICT.  It functions
> exactly the way we want it to.
> 
> So ... I read the following discussion of xt_SYSRQ from last year:
> 
> http://www.kerneltrap.com/mailarchive/linux-netdev/2010/4/21/6275199/thread
> 
> And it seems there were no technical objections to the code, but there
> were other concerns.
> 
> davem -- as I don't monitor this list, are you indicating that you are
> more amenable to this code being accepted upstream?  Or is that part of
> the debate still ongoing?
> 
> 

I've just re-read the thread and I'm reminded that I never did submit the xt_SYSRQ hash update I mentioned at the end of the thread.




  parent reply	other threads:[~2011-06-22 18:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21 13:00 [PATCH]: Add Network Sysrq Support Prarit Bhargava
2011-06-21 17:08 ` Stephen Hemminger
2011-06-21 18:30   ` Neil Horman
2011-06-21 20:09 ` Randy Dunlap
2011-06-21 20:37   ` Florian Westphal
2011-06-21 20:46     ` Randy Dunlap
2011-06-21 22:12   ` Prarit Bhargava
2011-06-21 22:05 ` Flavio Leitner
2011-06-21 22:26   ` Prarit Bhargava
2011-06-21 23:32     ` Flavio Leitner
2011-06-21 22:56   ` Florian Westphal
2011-06-21 22:58     ` David Miller
2011-06-22 10:26       ` Prarit Bhargava
2011-06-22 10:35         ` David Miller
2011-06-22 10:42           ` Prarit Bhargava
2011-06-22 10:54         ` Florian Westphal
2011-06-22 12:19           ` Prarit Bhargava
2011-06-22 12:37           ` John Haxby
2011-06-22 17:39             ` Prarit Bhargava
2011-06-22 18:46               ` John Haxby
2011-06-22 20:29                 ` David Miller
2011-06-22 18:57               ` John Haxby [this message]
2011-06-22 20:27               ` David Miller
2011-06-24 14:37           ` John Haxby
2011-06-22  7:55 ` WANG Cong
2011-06-22 15:29 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A2D02CF4-27C4-4A6E-A322-8D04C15EF3F3@oracle.com \
    --to=jch@thehaxbys.co.uk \
    --cc=agospoda@redhat.com \
    --cc=davem@davemloft.net \
    --cc=fbl@redhat.com \
    --cc=fw@strlen.de \
    --cc=lwoodman@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=prarit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.