All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] powerpc/85xx: standardize display of address map size (32-bit vs. 36-bit)
Date: Fri, 2 Sep 2011 13:24:10 -0500	[thread overview]
Message-ID: <A324986C-C4BF-459A-83AC-2B753FED7A1F@kernel.crashing.org> (raw)
In-Reply-To: <4E60DCEC.9090205@freescale.com>


On Sep 2, 2011, at 8:41 AM, Timur Tabi wrote:

> Kumar Gala wrote:
>> Both.  I'm think for your patch we'd add some general config option for extra print info.
> 
> So you want to see this instead:
> 
> /*
> * Display whether this is a 32-bit build or a 36-bit build.
> */
> #ifdef CONFIG_DISPLAY_ADDR_SIZE
> #ifdef CONFIG_PHYS_64BIT
> 	puts("ADDR:  36-bit address map\n");
> #else
> 	puts("ADDR:  32-bit address map\n");
> #endif
> #endif
> 
> I still like my way better.  It eliminates the need to think about another
> CONFIG option.  I think adding another CONFIG option is worse than adding
> another line of text.

I think we could introduce kernel style "printk" levels that would allow more control over something like this.

- k

  reply	other threads:[~2011-09-02 18:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31 22:15 [U-Boot] [PATCH 1/2] powerpc/85xx: CONFIG_ENABLE_36BIT_PHYS does not depend on CONFIG_PHYS_64BIT Timur Tabi
2011-08-31 22:15 ` [U-Boot] [PATCH 2/2] powerpc/85xx: standardize display of address map size (32-bit vs. 36-bit) Timur Tabi
2011-09-01 14:07   ` Kumar Gala
2011-09-01 14:13     ` Timur Tabi
2011-09-01 14:22     ` Wolfgang Denk
2011-09-01 14:54       ` Timur Tabi
2011-09-01 21:59         ` Wolfgang Denk
2011-09-01 22:09           ` Timur Tabi
2011-09-05 14:11             ` Wolfgang Denk
2011-09-02  3:38           ` Kumar Gala
2011-09-02 11:36             ` Tabi Timur-B04825
2011-09-02 13:12               ` Kumar Gala
2011-09-02 13:41                 ` Timur Tabi
2011-09-02 18:24                   ` Kumar Gala [this message]
2011-09-02 18:25                     ` Timur Tabi
2011-09-02 22:10                     ` Wolfgang Denk
2011-09-05 14:15                   ` Wolfgang Denk
2011-09-05 14:14             ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A324986C-C4BF-459A-83AC-2B753FED7A1F@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.