From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Alain Michaud <alainm@chromium.org>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v1] bluetooth: guard against controllers sending zero'd events
Date: Sun, 1 Mar 2020 10:38:20 +0200 [thread overview]
Message-ID: <A417E313-0ABE-46D6-92CD-434DDCC2D573@gmail.com> (raw)
In-Reply-To: <14FD24FA-1455-4FE4-832B-9851D9E22780@holtmann.org>
Hi Marcel,
On 1. Mar 2020, at 4.44, Marcel Holtmann <marcel@holtmann.org> wrote:
>>> Why are you bothering to check for event here. Do we have requests set with hci_req.event == 0?
>>
>> If I remember right, most requests are like that. req.event is only used then the request completes in something else than a command complete/status.
>
> so what do we do then if we get an event == 0 from the controller? Just bail out early? It seems kind pointless to keep processing it.
Yeah, that’s what I’d do. Bail out early, but log a warning.
Johan
prev parent reply other threads:[~2020-03-01 8:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 20:51 [PATCH v1] bluetooth: guard against controllers sending zero'd events Alain Michaud
2020-02-29 7:14 ` Marcel Holtmann
2020-02-29 8:44 ` Johan Hedberg
2020-03-01 2:44 ` Marcel Holtmann
2020-03-01 8:38 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A417E313-0ABE-46D6-92CD-434DDCC2D573@gmail.com \
--to=johan.hedberg@gmail.com \
--cc=alainm@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.