All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: yocto@yoctoproject.org
Subject: Re: Help with DISTRO settings
Date: Mon, 25 Jul 2016 22:51:30 -0700	[thread overview]
Message-ID: <A45630F5-217D-4CD4-ABDE-DFD37637C0BF@gmail.com> (raw)
In-Reply-To: <1814307.50VheZsyPG@peggleto-mobl.ger.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 2386 bytes --]


> On Jul 25, 2016, at 10:00 PM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> 
> On Mon, 25 Jul 2016 20:34:32 Khem Raj wrote:
>>> On Jul 25, 2016, at 8:31 PM, Edward Wingate <edwingate8@gmail.com> wrote:
>>> 
>>> On Mon, Jul 25, 2016 at 1:27 AM, Nicolas Dechesne
>>> 
>>> <nicolas.dechesne@linaro.org> wrote:
>>>> hmm. you shouldn't set DISTRO in conf/layer.conf, that doesn't sound
>>>> right. DISTRO needs to be set in local.conf (or any of the other build
>>>> specific conf files).
>>> 
>>> I agree, I don't know why I had it in conf/layer.conf.  Just
>>> beginner's mistake.
>>> 
>>> I moved DISTRO to local.conf (changed the existing DISTRO ?= "poky" to
>>> DISTRO ?= "mydistro") and it still works.  But if I remove DISTRO from
>>> conf/distro/mydistro.conf, DISTRO will revert to "poky", even though
>>> it is set to my "mydistro" in local.conf.  So it seems I have to have
>>> it in both places.
>> 
>> in your mydistro.conf you should first set the settings that you want to
>> customize then include conf/distro/poky.conf not other way around. May be
>> we should change poky.conf to use ??= so the substitution happens at the
>> end of parsing. but thats for another time.
> 
> I'm clearly missing something - why must it be done that way around? If you
> were to set the values you want *after* the include/require then that should
> work just fine, and would be the way I would recommend doing it - it's also
> the way poky-lsb distro does it.
> 
> One thing to note is that poky.conf itself sets DISTRO, mostly for historical
> reasons I believe. Thus if you do include/require poky.conf then you may wish
> to set DISTRO back to whatever it should be and you'd have to do that after
> the include/require, not before it.

Those are valid assertions. However user is changing DISTRO ?= “poky”
which will take effect if DISTRO is unset before above is parsed.

> 
> Another thing to consider is that any _poky overrides will only be applied if
> DISTRO = "poky", thus include/require of poky.conf won't incorporate those
> into your custom distro. You can set DISTROOVERRIDES to include "poky" to
> counter this. In practice though there aren't too many of these - in fact I
> can only see one in the psplash recipe.
> 
> Cheers,
> Paul
> 
> --
> 
> Paul Eggleton
> Intel Open Source Technology Centre


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

      reply	other threads:[~2016-07-26  5:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-24  5:49 Help with DISTRO settings Edward Wingate
2016-07-24  6:05 ` Khem Raj
2016-07-24  7:04   ` Edward Wingate
2016-07-24  7:34     ` Edward Wingate
2016-07-24 14:38       ` Khem Raj
2016-07-25  5:13         ` Edward Wingate
2016-07-25  8:27           ` Nicolas Dechesne
2016-07-26  3:31             ` Edward Wingate
2016-07-26  3:34               ` Khem Raj
2016-07-26  5:00                 ` Paul Eggleton
2016-07-26  5:51                   ` Khem Raj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A45630F5-217D-4CD4-ABDE-DFD37637C0BF@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=paul.eggleton@linux.intel.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.