All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Widawsky <ben@bwidawsk.net>
To: Andrew Lutomirski <luto@mit.edu>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/i915: Dumb down the semaphore logic
Date: Wed, 7 Sep 2011 18:19:56 -0700	[thread overview]
Message-ID: <A46ACFD7-245D-4202-A381-C859BCEF230F@bwidawsk.net> (raw)
In-Reply-To: <CAObL_7FdATx1ga-j1wn5jYvuHPajqLgo1DMW=NVWD7-73aRmFw@mail.gmail.com>



On Sep 7, 2011, at 5:30 PM, Andrew Lutomirski <luto@mit.edu> wrote:

> On Wed, Sep 7, 2011 at 4:12 PM, Ben Widawsky <ben@bwidawsk.net> wrote:
>> While I think the previous code is correct, it was hard to follow and
>> hard to debug. Since we already have a ring abstraction, might as well
>> use it to handle the semaphore updates and compares.
>> 
>> I don't expect this code to make semaphores better or worse, but you
>> never know...
>> 
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Cc: Eric Anholt <eric@anholt.net>
>> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>> ---
>>  drivers/gpu/drm/i915/i915_gem_execbuffer.c |    3 +-
>>  drivers/gpu/drm/i915/i915_reg.h            |    7 +
>>  drivers/gpu/drm/i915/intel_ringbuffer.c    |  176 +++++++++++++++++++++-------
>>  drivers/gpu/drm/i915/intel_ringbuffer.h    |    7 +-
>>  4 files changed, 145 insertions(+), 48 deletions(-)
>> 
> 
> Sadly, it still instantly crashes.
> 
> --Andy

Remind me again... Does ssh still work?

  reply	other threads:[~2011-09-08  1:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07 23:12 [PATCH 1/2] drm/i915: Dumb down the semaphore logic Ben Widawsky
2011-09-07 23:12 ` [PATCH 2/2] drm/i915: tracepoints for semaphores Ben Widawsky
2011-09-08  0:30 ` [PATCH 1/2] drm/i915: Dumb down the semaphore logic Andrew Lutomirski
2011-09-08  1:19   ` Ben Widawsky [this message]
2011-09-08  1:22     ` Andrew Lutomirski
2011-09-08  4:31 ` Keith Packard
2011-09-08  7:52 ` Daniel Vetter
2011-09-08 12:04   ` [PATCH] tests: basic ring<->cpu and ring<->ring tests Daniel Vetter
2011-09-11  3:44   ` [PATCH 1/2] drm/i915: Dumb down the semaphore logic Ben Widawsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A46ACFD7-245D-4202-A381-C859BCEF230F@bwidawsk.net \
    --to=ben@bwidawsk.net \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=luto@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.