From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rcd3H-0004Fg-Md for qemu-devel@nongnu.org; Mon, 19 Dec 2011 08:14:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rcd3A-0006dH-Qe for qemu-devel@nongnu.org; Mon, 19 Dec 2011 08:14:47 -0500 Received: from cantor2.suse.de ([195.135.220.15]:44562 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rcd3A-0006d5-J8 for qemu-devel@nongnu.org; Mon, 19 Dec 2011 08:14:40 -0500 Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Alexander Graf In-Reply-To: <1322548878-14000-1-git-send-email-yu.liu@freescale.com> Date: Mon, 19 Dec 2011 14:14:38 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <1322548878-14000-1-git-send-email-yu.liu@freescale.com> Subject: Re: [Qemu-devel] [PATCH] kvm-ppc: halt secondary cpus when guest reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Yu Cc: qemu-devel@nongnu.org On 29.11.2011, at 07:41, Liu Yu wrote: > When guest reset, we need to halt secondary cpus until guest kick = them. > This already works for tcg. The patch add the support for kvm. >=20 > For kvm, if use in-kernel mpic, it should not be halted. > In this case, we pause the sencondaries instead. > This has impact to handling of halt exit, > but fortunately, kvmppc doesn't use halt exit. >=20 > Signed-off-by: Liu Yu > --- > hw/ppce500_spin.c | 1 + > target-ppc/kvm.c | 11 ++++++++++- > 2 files changed, 11 insertions(+), 1 deletions(-) >=20 > diff --git a/hw/ppce500_spin.c b/hw/ppce500_spin.c > index cccd940..2b52728 100644 > --- a/hw/ppce500_spin.c > +++ b/hw/ppce500_spin.c > @@ -112,6 +112,7 @@ static void spin_kick(void *data) >=20 > env->halted =3D 0; > env->exception_index =3D -1; > + env->stopped =3D 0; > qemu_cpu_kick(env); > } >=20 > diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c > index 429349f..ff4cfdb 100644 > --- a/target-ppc/kvm.c > +++ b/target-ppc/kvm.c > @@ -504,7 +504,16 @@ void kvm_arch_post_run(CPUState *env, struct = kvm_run *run) >=20 > int kvm_arch_process_async_events(CPUState *env) > { > - return 0; > + if (kvm_irqchip_in_kernel()) { There is no in-kernel irqchip in upstream KVM for BookE. I'll drop this = branch. The rest is applied to ppc-next. Alex