From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbdB1V00 convert rfc822-to-8bit (ORCPT ); Tue, 28 Feb 2017 16:26:26 -0500 Received: from mout.gmx.net ([212.227.17.21]:56378 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752025AbdB1V0W (ORCPT ); Tue, 28 Feb 2017 16:26:22 -0500 Date: Tue, 28 Feb 2017 22:24:45 +0100 User-Agent: K-9 Mail for Android In-Reply-To: <20170228211326.3667625-1-arnd@arndb.de> References: <20170228211326.3667625-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCH] tpm: select CONFIG_CRYPTO To: Arnd Bergmann , Marcel Selhorst , Jarkko Sakkinen CC: Jason Gunthorpe , Stefan Berger , Christophe Ricard , Nayna Jain , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org From: Peter Huewe Message-ID: X-Provags-ID: V03:K0:AHGeAqQ+Gq6874QVxIEC+oaeVGRYBxxL6JpaSHJaahmnVEDH4GH rgLXuDVfLCYTCau0BB2JoXNbKV39gUDf6aFLo8oHdIN6WlVtbDdu9Eb5yAuPHfSkg8BMrL7 eIninFOF9vpDNilydxi1CqyXJqsYmRUif8birAk/kJK6zcEmEe89HKXdQYXmLfhoNvhIWeU peETck7lrg3ooEilspQ8w== X-UI-Out-Filterresults: notjunk:1;V01:K0:xwK2QIyecaM=:FDIBBD8KmWevcG/fU1FIXq a6HcAmyEIQVQreJWsejuPvmglbWO9ZQbEjs9K9ncxr8DkGjO1nk3SBwZqXD94MA3HCfHhtaz2 n/PbL77BCJhzKU5BQiCGw8UHCp2Noq0tOqcJomeUhygGnT4aNqRZD6B10WmRnKBvMH6brcxs8 ySadQaa7XK++zTnRu2G2Wd3xHEXR25oyGAQJE+qqfHisGpGWfhkNoyeDw71e7V8WHOWAi2WdT CxIQZtgMD9xv+bvONVcs1r0kSPC6rTW7nUynu3VhYPgu4ODCJYDQ7WheZp+cDwhXaMfkq1rA9 OwU+iLAXKIecNUVWEJOVYF/bNZrweMFQqIRvWr83lmPngU8iVcscEr9kfWKd+2cHKYTmtVgaK KtJxX4cM1rS2KKnI/uE11xxd8/fTpW8f3mNFGV7oL7ekPjsJK/Z0vAkQM54Pk61G/fR4+K0WD qPYP8oMMEzcmsL23pgJZkxqjsYWZHDZBwGe/K28zfGnJ4JQSPvzVjsLwUxX3So8bldSck300Y J7zg7AogUmiyS/sNOOn28uEE2DYN5K6KvC3/yVuFL+nWq6GxVIvjQYJwt4d9xg6WBLvC/QdD1 VAOMLhBDQZovdzFv4nXsUesuSQGwId5nLiv0bqYuC8icPGZbV2IEAkgtBKaWCOrWtvau812vQ y9TQPOTFzzMc+Qwa63vsl67rf9IMDfMuauTPMYqvXdErUj1rQCMzn3Ts4iZKSB+sFGFpgd+oM O3eHDOAd1hSevdByqZiD0+OPaNoxkT/gDu0DjHrqMgMUV+IufY2OpGPQi4eMfNm7BZhAXcxyS LYxot7G Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann : >We get a newly introduced harmless warning when CONFIG_CRYPTO is >disabled: > >warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO >which has unmet direct dependencies (CRYPTO) > >This adds another select to avoid the warning, consistent with other >users >of the crypto code. > >Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support >multiple banks") >Signed-off-by: Arnd Bergmann Lgtm Reviewed-by: Peter Huewe >--- > drivers/char/tpm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig >index af985cca413c..d520ac51c11c 100644 >--- a/drivers/char/tpm/Kconfig >+++ b/drivers/char/tpm/Kconfig >@@ -6,6 +6,7 @@ menuconfig TCG_TPM > tristate "TPM Hardware Support" > depends on HAS_IOMEM > select SECURITYFS >+ select CRYPTO > select CRYPTO_HASH_INFO > ---help--- > If you have a TPM security chip in your system, which -- Sent from my mobile From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Huewe Subject: Re: [PATCH] tpm: select CONFIG_CRYPTO Date: Tue, 28 Feb 2017 22:24:45 +0100 Message-ID: References: <20170228211326.3667625-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170228211326.3667625-1-arnd-r2nGTMty4D4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Arnd Bergmann , Marcel Selhorst , Jarkko Sakkinen Cc: Christophe Ricard , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann : >We get a newly introduced harmless warning when CONFIG_CRYPTO is >disabled: > >warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO >which has unmet direct dependencies (CRYPTO) > >This adds another select to avoid the warning, consistent with other >users >of the crypto code. > >Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support >multiple banks") >Signed-off-by: Arnd Bergmann Lgtm Reviewed-by: Peter Huewe >--- > drivers/char/tpm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig >index af985cca413c..d520ac51c11c 100644 >--- a/drivers/char/tpm/Kconfig >+++ b/drivers/char/tpm/Kconfig >@@ -6,6 +6,7 @@ menuconfig TCG_TPM > tristate "TPM Hardware Support" > depends on HAS_IOMEM > select SECURITYFS >+ select CRYPTO > select CRYPTO_HASH_INFO > ---help--- > If you have a TPM security chip in your system, which -- Sent from my mobile ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot