From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kim, Milo" Subject: RE: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver Date: Mon, 22 Sep 2014 01:01:12 +0000 Message-ID: References: <1410448403-19402-1-git-send-email-svarbanov@mm-sol.com> <1410448403-19402-2-git-send-email-svarbanov@mm-sol.com> <54138151.8010902@gmx.de> <54147E97.60808@kernel.org> <5416F3E2.3030009@mm-sol.com> <4dbc485f-599a-4b50-854c-c2e1c44d4810@email.android.com> <541AAC80.1090708@mm-sol.com> <541ED2C0.4040801@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:39469 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbaIVBCH (ORCPT ); Sun, 21 Sep 2014 21:02:07 -0400 In-Reply-To: <541ED2C0.4040801@kernel.org> Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Jonathan Cameron , Stanimir Varbanov Cc: Hartmut Knaack , Ian Campbell , Pawel Moll , Rob Herring , Kumar Gala , Mark Rutland , Grant Likely , Arnd Bergmann , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , Greg Kroah-Hartman , Lars-Peter Clausen , Angelo Compagnucci , Doug Anderson , Fugang Duan , Johannes Thumshirn , Jean Delvare , Philippe Reynes , Lee SGVsbG8gSm9uYXRoYW4gYW5kIFN0YW5pbWlyLA0KDQo+ID4+IFNlZSBEb2N1bWVudGF0aW9uL0FC SS9zeXNmcy1idXMtaWlvDQo+ID4+IE1pbGxpdm9sdHMgSSB0aGluay4uLiBXZSBjb3BpZWQgaHdt b24gd2hlcmUgcG9zc2libGUuDQo+ID4NCj4gPiBJJ20gYSBiaXQgY29uZnVzZWQgYWJvdXQgdGhl c2UgdW5pdHMuIEkgc2VhcmNoZWQgcmVmZXJlbmNlcyBvZg0KPiA+IGlpb19yZWFkX2NoYW5uZWxf cHJvY2Vzc2VkKCkgYW5kIGZvdW5kIGEgZmV3Lg0KPiA+DQo+ID4gVGhlIGlpb19od21vbiBleHBl Y3RpbmcgbWlsaXZvbHRzLiBPbiB0aGUgb3RoZXIgc2lkZSBscDg3ODgtY2hhcmdlci5jDQo+ID4g cmVnaXN0ZXJzIGEgZ2V0X3Byb3BlcnR5IG1ldGhvZCBpbiBjaGFyZ2VyLW1hbmFnZXIuYywgd2hp Y2ggZXhwZWN0cw0KPiA+IG1pY3Jvdm9sdHMgaW4gZ2V0X2JhdHRfdVYoKS4NCj4gSXQncyBkZWZp bml0ZWx5IG1lYW50IHRvIGJlIG1pbGxpdm9sdHMgKGxpZnRlZCBmcm9tIGh3bW9uIGEgd2hpbGUg YmFjaykuDQo+IFNlZSBEb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL3N5c2ZzLWJ1cy1paW8NCj4g DQo+IExvb2tzIGxpa2Ugd2UgaGF2ZSBhIGJ1ZyBpbiBscDg3ODgtY2hhcmdlciAtIGl0IG1pZ2h0 IGJlIG1hdGNoZWQgd2l0aCBvbmUgaW4NCj4gbHA4Nzg4LWFkYywgYnV0IHRoZW4gdGhlcmUgd2ls bCBiZSBhIGJ1ZyB0aGVyZS4uLg0KPiANCj4gQ2MnZCBNaWxvIEtpbS4NCg0KJ2xwODc4OC1jaGFy Z2VyJyByZWdpc3RlcnMgbm90IGNoYXJnZXItbWFuYWdlciBidXQgcG93ZXItc3VwcGx5IHN1YnN5 c3RlbS4NCidscDg3ODgtYWRjJyBpcyB0aGUgSUlPIGRyaXZlci4NCidscDg3ODgtY2hhcmdlcicg aXMgdGhlIElJTyBjb25zdW1lciBvZiBscDg3ODgtYWRjLg0KDQooSG93IHRvIGNvbW11bmljYXRl IGJldHdlZW4gbHA4Nzg4LWFkYyBhbmQgbHA4Nzg4LWNoYXJnZXIpDQoxLiBBcHBsaWNhdGlvbiBy ZXF1ZXN0cyB2YmF0dChiYXR0ZXJ5IHZvbHRhZ2UpIGJ5IGFjY2Vzc2luZyAvc3lzL2NsYXNzL3Bv d2VyLw0KMi4gbHA4Nzg4LWNoYXJnZXIgYXNrcyBscDg3ODgtYWRjIHRvIGdldCBjb252ZXJ0ZWQg dmJhdHQgdmFsdWUNCjMuIGxwODc4OC1hZGMgZ2V0IHRoZSBiYXR0ZXJ5IEFEQyBmcm9tIHRoZSBk ZXZpY2UuDQogICBJdCByZXR1cm5zIGNhbGN1bGF0ZWQgbWljcm8gdm9sdGFnZSB0byBscDg3ODgt Y2hhcmdlci4NCjQuIGxwODc4OC1jaGFyZ2VyIHJlcG9ydHMgdGhpcyB1ViB2YWx1ZSB0byB0aGUg YXBwbGljYXRpb24NCjUuIEFwcGxpY2F0aW9uIHVzZXMgdVYgb3IgY29udmVydHMgdG8gbVYgb3Ig ViB1bml0LiBJdCdzIHVwIHRvIHRoZSBhcHAuDQoNClBsZWFzZSBub3RlIHRoYXQgYmF0dGVyeSBh cHAgYWNjZXNzZXMgbm90IC9zeXMvYnVzL2lpbyBidXQgL3N5cy9jbGFzcy9wb3dlci8uDQoNCkJl c3QgcmVnYXJkcywNCk1pbG8NCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752738AbaIVBCK (ORCPT ); Sun, 21 Sep 2014 21:02:10 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:39469 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbaIVBCH (ORCPT ); Sun, 21 Sep 2014 21:02:07 -0400 From: "Kim, Milo" To: Jonathan Cameron , Stanimir Varbanov CC: Hartmut Knaack , Ian Campbell , Pawel Moll , Rob Herring , Kumar Gala , Mark Rutland , Grant Likely , Arnd Bergmann , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , Greg Kroah-Hartman , Lars-Peter Clausen , "Angelo Compagnucci" , Doug Anderson , Fugang Duan , "Johannes Thumshirn" , Jean Delvare , Philippe Reynes , Lee Jones , "Josh Cartwright" , Stephen Boyd , "David Collins" , "Ivan T. Ivanov" Subject: RE: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver Thread-Topic: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver Thread-Index: AQHP1aAelxktd+4Ys02WPQc9e32zY5wMSPVQ Date: Mon, 22 Sep 2014 01:01:12 +0000 Message-ID: References: <1410448403-19402-1-git-send-email-svarbanov@mm-sol.com> <1410448403-19402-2-git-send-email-svarbanov@mm-sol.com> <54138151.8010902@gmx.de> <54147E97.60808@kernel.org> <5416F3E2.3030009@mm-sol.com> <4dbc485f-599a-4b50-854c-c2e1c44d4810@email.android.com> <541AAC80.1090708@mm-sol.com> <541ED2C0.4040801@kernel.org> In-Reply-To: <541ED2C0.4040801@kernel.org> Accept-Language: en-US, ko-KR Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.34.32] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s8M12FKB025421 Hello Jonathan and Stanimir, > >> See Documentation/ABI/sysfs-bus-iio > >> Millivolts I think... We copied hwmon where possible. > > > > I'm a bit confused about these units. I searched references of > > iio_read_channel_processed() and found a few. > > > > The iio_hwmon expecting milivolts. On the other side lp8788-charger.c > > registers a get_property method in charger-manager.c, which expects > > microvolts in get_batt_uV(). > It's definitely meant to be millivolts (lifted from hwmon a while back). > See Documentation/ABI/testing/sysfs-bus-iio > > Looks like we have a bug in lp8788-charger - it might be matched with one in > lp8788-adc, but then there will be a bug there... > > Cc'd Milo Kim. 'lp8788-charger' registers not charger-manager but power-supply subsystem. 'lp8788-adc' is the IIO driver. 'lp8788-charger' is the IIO consumer of lp8788-adc. (How to communicate between lp8788-adc and lp8788-charger) 1. Application requests vbatt(battery voltage) by accessing /sys/class/power/ 2. lp8788-charger asks lp8788-adc to get converted vbatt value 3. lp8788-adc get the battery ADC from the device. It returns calculated micro voltage to lp8788-charger. 4. lp8788-charger reports this uV value to the application 5. Application uses uV or converts to mV or V unit. It's up to the app. Please note that battery app accesses not /sys/bus/iio but /sys/class/power/. Best regards, Milo {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from comal.ext.ti.com ([198.47.26.152]:39469 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbaIVBCH (ORCPT ); Sun, 21 Sep 2014 21:02:07 -0400 From: "Kim, Milo" To: Jonathan Cameron , Stanimir Varbanov CC: Hartmut Knaack , Ian Campbell , Pawel Moll , Rob Herring , Kumar Gala , Mark Rutland , Grant Likely , Arnd Bergmann , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , Greg Kroah-Hartman , Lars-Peter Clausen , "Angelo Compagnucci" , Doug Anderson , Fugang Duan , "Johannes Thumshirn" , Jean Delvare , Philippe Reynes , Lee Jones , "Josh Cartwright" , Stephen Boyd , "David Collins" , "Ivan T. Ivanov" Subject: RE: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver Date: Mon, 22 Sep 2014 01:01:12 +0000 Message-ID: References: <1410448403-19402-1-git-send-email-svarbanov@mm-sol.com> <1410448403-19402-2-git-send-email-svarbanov@mm-sol.com> <54138151.8010902@gmx.de> <54147E97.60808@kernel.org> <5416F3E2.3030009@mm-sol.com> <4dbc485f-599a-4b50-854c-c2e1c44d4810@email.android.com> <541AAC80.1090708@mm-sol.com> <541ED2C0.4040801@kernel.org> In-Reply-To: <541ED2C0.4040801@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org SGVsbG8gSm9uYXRoYW4gYW5kIFN0YW5pbWlyLA0KDQo+ID4+IFNlZSBEb2N1bWVudGF0aW9uL0FC SS9zeXNmcy1idXMtaWlvDQo+ID4+IE1pbGxpdm9sdHMgSSB0aGluay4uLiBXZSBjb3BpZWQgaHdt b24gd2hlcmUgcG9zc2libGUuDQo+ID4NCj4gPiBJJ20gYSBiaXQgY29uZnVzZWQgYWJvdXQgdGhl c2UgdW5pdHMuIEkgc2VhcmNoZWQgcmVmZXJlbmNlcyBvZg0KPiA+IGlpb19yZWFkX2NoYW5uZWxf cHJvY2Vzc2VkKCkgYW5kIGZvdW5kIGEgZmV3Lg0KPiA+DQo+ID4gVGhlIGlpb19od21vbiBleHBl Y3RpbmcgbWlsaXZvbHRzLiBPbiB0aGUgb3RoZXIgc2lkZSBscDg3ODgtY2hhcmdlci5jDQo+ID4g cmVnaXN0ZXJzIGEgZ2V0X3Byb3BlcnR5IG1ldGhvZCBpbiBjaGFyZ2VyLW1hbmFnZXIuYywgd2hp Y2ggZXhwZWN0cw0KPiA+IG1pY3Jvdm9sdHMgaW4gZ2V0X2JhdHRfdVYoKS4NCj4gSXQncyBkZWZp bml0ZWx5IG1lYW50IHRvIGJlIG1pbGxpdm9sdHMgKGxpZnRlZCBmcm9tIGh3bW9uIGEgd2hpbGUg YmFjaykuDQo+IFNlZSBEb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL3N5c2ZzLWJ1cy1paW8NCj4g DQo+IExvb2tzIGxpa2Ugd2UgaGF2ZSBhIGJ1ZyBpbiBscDg3ODgtY2hhcmdlciAtIGl0IG1pZ2h0 IGJlIG1hdGNoZWQgd2l0aCBvbmUgaW4NCj4gbHA4Nzg4LWFkYywgYnV0IHRoZW4gdGhlcmUgd2ls bCBiZSBhIGJ1ZyB0aGVyZS4uLg0KPiANCj4gQ2MnZCBNaWxvIEtpbS4NCg0KJ2xwODc4OC1jaGFy Z2VyJyByZWdpc3RlcnMgbm90IGNoYXJnZXItbWFuYWdlciBidXQgcG93ZXItc3VwcGx5IHN1YnN5 c3RlbS4NCidscDg3ODgtYWRjJyBpcyB0aGUgSUlPIGRyaXZlci4NCidscDg3ODgtY2hhcmdlcicg aXMgdGhlIElJTyBjb25zdW1lciBvZiBscDg3ODgtYWRjLg0KDQooSG93IHRvIGNvbW11bmljYXRl IGJldHdlZW4gbHA4Nzg4LWFkYyBhbmQgbHA4Nzg4LWNoYXJnZXIpDQoxLiBBcHBsaWNhdGlvbiBy ZXF1ZXN0cyB2YmF0dChiYXR0ZXJ5IHZvbHRhZ2UpIGJ5IGFjY2Vzc2luZyAvc3lzL2NsYXNzL3Bv d2VyLw0KMi4gbHA4Nzg4LWNoYXJnZXIgYXNrcyBscDg3ODgtYWRjIHRvIGdldCBjb252ZXJ0ZWQg dmJhdHQgdmFsdWUNCjMuIGxwODc4OC1hZGMgZ2V0IHRoZSBiYXR0ZXJ5IEFEQyBmcm9tIHRoZSBk ZXZpY2UuDQogICBJdCByZXR1cm5zIGNhbGN1bGF0ZWQgbWljcm8gdm9sdGFnZSB0byBscDg3ODgt Y2hhcmdlci4NCjQuIGxwODc4OC1jaGFyZ2VyIHJlcG9ydHMgdGhpcyB1ViB2YWx1ZSB0byB0aGUg YXBwbGljYXRpb24NCjUuIEFwcGxpY2F0aW9uIHVzZXMgdVYgb3IgY29udmVydHMgdG8gbVYgb3Ig ViB1bml0LiBJdCdzIHVwIHRvIHRoZSBhcHAuDQoNClBsZWFzZSBub3RlIHRoYXQgYmF0dGVyeSBh cHAgYWNjZXNzZXMgbm90IC9zeXMvYnVzL2lpbyBidXQgL3N5cy9jbGFzcy9wb3dlci8uDQoNCkJl c3QgcmVnYXJkcywNCk1pbG8NCg==