From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Subject: Re: [PATCH for 4.6 07/13] xen: Introduce a generic way
 to	describe device
Date: Thu, 18 Dec 2014 01:12:53 +0000
Message-ID: <A9667DDFB95DB7438FA9D7D576C3D87E0AC04044@SHSMSX104.ccr.corp.intel.com>
References: <1418760534-18163-1-git-send-email-julien.grall@linaro.org>
	<1418760534-18163-8-git-send-email-julien.grall@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <yang.z.zhang@intel.com>) id 1Y1Peo-0007dD-HI
	for xen-devel@lists.xenproject.org; Thu, 18 Dec 2014 01:13:34 +0000
In-Reply-To: <1418760534-18163-8-git-send-email-julien.grall@linaro.org>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>, "ian.campbell@citrix.com" <ian.campbell@citrix.com>, "manish.jaggi@caviumnetworks.com" <manish.jaggi@caviumnetworks.com>, "tim@xen.org" <tim@xen.org>, "stefano.stabellini@citrix.com" <stefano.stabellini@citrix.com>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

Julien Grall wrote on 2014-12-17:
> diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h index
> 5f295f3..6ace79d 100644
> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -13,6 +13,7 @@
>  #include <xen/irq.h> #include <xen/pci_regs.h> #include <xen/pfn.h>
>  +#include <xen/device.h> #include <asm/pci.h>
>  
>  /* @@ -75,8 +76,19 @@ struct pci_dev { #define PT_FAULT_THRESHOLD 10
>      } fault;
>      u64 vf_rlen[6];
> +
> +    struct device dev;
>  };
> +#define pci_to_dev(pcidev)  (&(pcidev)->dev)
> +
> +static inline struct pci_dev *dev_to_pci(struct device *dev) {
> +    ASSERT(dev->type == DEV_PCI);
> +
> +    return container_of(dev, struct pci_dev, dev); }
> +
>  #define for_each_pdev(domain, pdev) \
>      list_for_each_entry(pdev, &(domain->arch.pdev_list), domain_list)

I'd suggest splitting the changes to common code to a separate patch and also CC the VT-d/AMD maintainers. Because I didn't find those definitions when reviewing the 8th patch and I need to search the whole patch set to find them.

Best regards,
Yang