All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikhail Malygin <m.malygin@yadro.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	Sergey Kojushev <S.Kojushev@yadro.com>,
	"linux@yadro.com" <linux@yadro.com>
Subject: Re:  [PATCH] rdma_rxe: Prevent access to wr->next ptr afrer wr is posted to send queue
Date: Wed, 15 Jul 2020 08:57:40 +0000	[thread overview]
Message-ID: <A9F28BA8-EAB3-48AC-99C0-09E93D7B9DE0@yadro.com> (raw)


> Why is this READ_ONCE? The wr list at this point cannot be allowed to
> change
> 
> Jason

The idea behind this READ_ONCE was to make sure read of wr->next happens before post_send_one(), as there is no data dependency between post_send_one and read of wr->next. However I’m not 100% sure this is necessary here.

Mikhail

             reply	other threads:[~2020-07-15  8:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15  8:57 Mikhail Malygin [this message]
2020-07-15 11:37 ` [PATCH] rdma_rxe: Prevent access to wr->next ptr afrer wr is posted to send queue Jason Gunthorpe
2020-07-15 12:18   ` Mikhail Malygin
2020-07-16  3:17     ` Zhu Yanjun
2020-07-16 11:41       ` Jason Gunthorpe
  -- strict thread matches above, loose matches on Subject: below --
2020-06-09 12:54 m.malygin
2020-07-14 19:59 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A9F28BA8-EAB3-48AC-99C0-09E93D7B9DE0@yadro.com \
    --to=m.malygin@yadro.com \
    --cc=S.Kojushev@yadro.com \
    --cc=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux@yadro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.