From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N7aBc-0000qF-L7
	for qemu-devel@nongnu.org; Mon, 09 Nov 2009 14:46:00 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N7aBX-0000ma-Vo
	for qemu-devel@nongnu.org; Mon, 09 Nov 2009 14:46:00 -0500
Received: from [199.232.76.173] (port=36695 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N7aBX-0000mO-MZ
	for qemu-devel@nongnu.org; Mon, 09 Nov 2009 14:45:55 -0500
Received: from cantor2.suse.de ([195.135.220.15]:36965 helo=mx2.suse.de)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <agraf@suse.de>) id 1N7aBW-0008Dt-Ud
	for qemu-devel@nongnu.org; Mon, 09 Nov 2009 14:45:55 -0500
Subject: Re: [Qemu-devel] [PATCH 9/9] Move mp_state to CPU_COMMON
Mime-Version: 1.0 (Apple Message framework v1076)
Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes
From: Alexander Graf <agraf@suse.de>
In-Reply-To: <4AF87124.50204@codemonkey.ws>
Date: Mon, 9 Nov 2009 20:45:49 +0100
Content-Transfer-Encoding: 7bit
Message-Id: <AA74E8AE-247F-4908-8A9B-C1C18A1AA58C@suse.de>
References: <1256152621-18863-1-git-send-email-agraf@suse.de>
	<1256152621-18863-2-git-send-email-agraf@suse.de>
	<1256152621-18863-3-git-send-email-agraf@suse.de>
	<1256152621-18863-4-git-send-email-agraf@suse.de>
	<1256152621-18863-5-git-send-email-agraf@suse.de>
	<1256152621-18863-6-git-send-email-agraf@suse.de>
	<1256152621-18863-7-git-send-email-agraf@suse.de>
	<1256152621-18863-8-git-send-email-agraf@suse.de>
	<1256152621-18863-9-git-send-email-agraf@suse.de>
	<1256152621-18863-10-git-send-email-agraf@suse.de>
	<1256852394.9044.118.camel@slab.beaverton.ibm.com>
	<31B0F419-D1B8-4E5C-A134-B3593A898B09@suse.de>
	<4AF87124.50204@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Hollis Blanchard <hollisb@us.ibm.com>


On 09.11.2009, at 20:44, Anthony Liguori wrote:

> Alexander Graf wrote:
>>
>> On 29.10.2009, at 22:39, Hollis Blanchard wrote:
>>
>>> On Wed, 2009-10-21 at 21:17 +0200, Alexander Graf wrote:
>>>> MP State is implemented in the generic code, so let's move the  
>>>> variable
>>>> it accesses to generic code as well.
>>>>
>>>> Still unbreaks PPC and now even S390x w/ KVM.
>>>>
>>>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>>
>>> Acked-by: Hollis Blanchard <hollisb@us.ibm.com>
>>>
>>> Anthony, this patch fixes a build break in PowerPC KVM. Arguably it
>>> should not be patch 9/9 in an S390 series, but in any case please  
>>> apply
>>> it. :)
>>
>> Anthony, could you please apply it? Not having S390 support is  
>> pitiful, but having PPC break too is even worse!
>
> mp_state does not belong in CPU_COMMON.

So you'd rather like a patch #ifdef'ing out the mp code to x86 only?  
Or move it to target-i386/kvm.c?

Alex