All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Junjie J" <junjie.j.chen@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"Tan, Jianfeng" <jianfeng.tan@intel.com>,
	"mtetsuyah@gmail.com" <mtetsuyah@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v6 1/2] vhost: add support for interrupt mode
Date: Fri, 13 Apr 2018 10:07:55 +0000	[thread overview]
Message-ID: <AA85A5A5E706C44BACB0BEFD5AC08BF6313C8EF6@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <68db4761-520a-1bc2-f7dc-fe75078d88c8@redhat.com>

Hi 
> Please next time run checkpatch before posting, I had to fix below errors when

Thanks, I ran for v1-v5 and too confident for the last minor change.
> applying.
> 
> Thanks,
> Maxime
> 
> ### [dpdk-dev,v6,1/2] vhost: add support for interrupt mode
> 
> CHECK:BRACES: braces {} should be used on all arms of this statement
> #208: FILE: drivers/net/vhost/rte_eth_vhost.c:743:
> +	if (rte_atomic32_read(&internal->started) == 1) {
> [...]
>   	else
> [...]
> 
> ERROR:TRAILING_WHITESPACE: trailing whitespace
> #237: FILE: drivers/net/vhost/rte_eth_vhost.c:939:
> +^I$
> 
> ERROR:TRAILING_WHITESPACE: trailing whitespace
> #282: FILE: lib/librte_vhost/vhost.c:554:
> +^Ielse^I$
> 
> total: 2 errors, 0 warnings, 225 lines checked
> 
> 0/1 valid patch

  reply	other threads:[~2018-04-13 10:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22  9:59 [PATCH] vhost: add support for interrupt mode Junjie Chen
2018-03-29 14:37 ` [PATCH v2] " Junjie Chen
2018-03-31  4:00   ` Tan, Jianfeng
2018-04-02  8:51     ` Chen, Junjie J
2018-04-03 16:33   ` [PATCH v3] " Junjie Chen
2018-04-04  9:43     ` [PATCH v4] " Junjie Chen
2018-04-08 16:50       ` [PATCH v5] " Junjie Chen
2018-04-12 16:28         ` [PATCH v6 1/2] " Junjie Chen
2018-04-12 12:18           ` Tan, Jianfeng
2018-04-13  9:15           ` Maxime Coquelin
2018-04-13 10:07             ` Chen, Junjie J [this message]
2018-04-12 16:29         ` [PATCH v6 2/2] net/vhost: update license to SPDX format Junjie Chen
2018-04-12 16:43         ` Junjie Chen
2018-04-12 12:21           ` Maxime Coquelin
2018-04-19  1:07           ` Takanari Hayama
2018-04-19 14:55             ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AA85A5A5E706C44BACB0BEFD5AC08BF6313C8EF6@SHSMSX101.ccr.corp.intel.com \
    --to=junjie.j.chen@intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mtetsuyah@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.