Re: [PATCH 1/1] RDMA/irdma: change the returned type to void

From: Majd Dibbiny <majd@nvidia.com>
To: "yanjun.zhu@linux.dev" <yanjun.zhu@linux.dev>
Cc: "zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
	"mustafa.ismail@intel.com" <mustafa.ismail@intel.com>,
	"shiraz.saleem@intel.com" <shiraz.saleem@intel.com>,
	"dledford@redhat.com" <dledford@redhat.com>,
	"jgg@ziepe.ca" <jgg@ziepe.ca>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH 1/1] RDMA/irdma: change the returned type to void
Date: Wed, 7 Jul 2021 14:33:00 +0000	[thread overview]
Message-ID: <AA895EB3-CA70-4907-83CB-ACFB56CF58CB@nvidia.com> (raw)
In-Reply-To: <20210708064752.797520-1-yanjun.zhu@linux.dev>


> On 7 Jul 2021, at 17:24, yanjun.zhu@linux.dev wrote:
> 
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
> 
> Since the function irdma_sc_parse_fpm_commit_buf always returns 0,
> remove the returned value check and change the returned type to void.
> 
> Fixes: 3f49d6842569 ("RDMA/irdma: Implement HW Admin Queue OPs")
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Reviewed-by: Majd Dibbiny <majd@nvidia.com>
> ---
> drivers/infiniband/hw/irdma/ctrl.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/ctrl.c b/drivers/infiniband/hw/irdma/ctrl.c
> index b1023a7d0bd1..c3880a85e255 100644
> --- a/drivers/infiniband/hw/irdma/ctrl.c
> +++ b/drivers/infiniband/hw/irdma/ctrl.c
> @@ -2845,7 +2845,7 @@ static u64 irdma_sc_decode_fpm_commit(struct irdma_sc_dev *dev, __le64 *buf,
>  * parses fpm commit info and copy base value
>  * of hmc objects in hmc_info
>  */
> -static enum irdma_status_code
> +static void
> irdma_sc_parse_fpm_commit_buf(struct irdma_sc_dev *dev, __le64 *buf,
>                  struct irdma_hmc_obj_info *info, u32 *sd)
> {
> @@ -2915,7 +2915,6 @@ irdma_sc_parse_fpm_commit_buf(struct irdma_sc_dev *dev, __le64 *buf,
>    else
>        *sd = (u32)(size >> 21);
> 
> -    return 0;
> }
> 
> /**
> @@ -4434,9 +4433,9 @@ static enum irdma_status_code irdma_sc_cfg_iw_fpm(struct irdma_sc_dev *dev,
>    ret_code = irdma_sc_commit_fpm_val(dev->cqp, 0, hmc_info->hmc_fn_id,
>                       &commit_fpm_mem, true, wait_type);
>    if (!ret_code)
> -        ret_code = irdma_sc_parse_fpm_commit_buf(dev, dev->fpm_commit_buf,
> -                             hmc_info->hmc_obj,
> -                             &hmc_info->sd_table.sd_cnt);
> +        irdma_sc_parse_fpm_commit_buf(dev, dev->fpm_commit_buf,
> +                          hmc_info->hmc_obj,
> +                          &hmc_info->sd_table.sd_cnt);
>    print_hex_dump_debug("HMC: COMMIT FPM BUFFER", DUMP_PREFIX_OFFSET, 16,
>                 8, commit_fpm_mem.va, IRDMA_COMMIT_FPM_BUF_SIZE,
>                 false);
> -- 
> 2.27.0
>