From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tian, Kevin" <kevin.tian@intel.com>
Subject: Re: [PATCH 4/4] x86/EPT: also force EMT re-evaluation
 if pinned ranges change
Date: Mon, 28 Apr 2014 07:43:36 +0000
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D125E53B21@SHSMSX101.ccr.corp.intel.com>
References: <53579447020000780000B2A9@nat28.tlf.novell.com>
	<535798E6020000780000B2EE@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <kevin.tian@intel.com>) id 1WegED-0000t7-95
	for xen-devel@lists.xenproject.org; Mon, 28 Apr 2014 07:43:53 +0000
In-Reply-To: <535798E6020000780000B2EE@nat28.tlf.novell.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>, "Dong, Eddie" <eddie.dong@intel.com>, "Nakajima,
	Jun" <jun.nakajima@intel.com>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: Wednesday, April 23, 2014 4:42 PM
> 
> This was inadvertently left out of aa9114ed ("x86/EPT: force
> re-evaluation of memory type as necessary"). Note that this
> intentionally doesn't use memory_type_changed(): Changes to the pinned
> ranges are independent of IOMMU presence, which that function uses to
> determine whether to call the underlying p2m_memory_type_changed().
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Kevin Tian <kevin.tian@intel.com>

> 
> --- a/xen/arch/x86/hvm/mtrr.c
> +++ b/xen/arch/x86/hvm/mtrr.c
> @@ -650,6 +650,7 @@ int32_t hvm_set_mem_pinned_cacheattr(
>                  rcu_read_unlock(&pinned_cacheattr_rcu_lock);
>                  list_del_rcu(&range->list);
>                  call_rcu(&range->rcu, free_pinned_cacheattr_entry);
> +                p2m_memory_type_changed(d);
>                  return 0;
>              }
>          rcu_read_unlock(&pinned_cacheattr_rcu_lock);
> @@ -695,6 +696,7 @@ int32_t hvm_set_mem_pinned_cacheattr(
>      range->type = type;
> 
>      list_add_rcu(&range->list,
> &d->arch.hvm_domain.pinned_cacheattr_ranges);
> +    p2m_memory_type_changed(d);
> 
>      return 0;
>  }
> 
>