From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"tim@xen.org" <tim@xen.org>,
"dietmar.hahn@ts.fujitsu.com" <dietmar.hahn@ts.fujitsu.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
"Aravind.Gopalakrishnan@amd.com" <Aravind.Gopalakrishnan@amd.com>,
"Nakajima, Jun" <jun.nakajima@intel.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
"dgdegra@tycho.nsa.gov" <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v24 12/15] x86/VPMU: Handle PMU interrupts for PV(H) guests
Date: Thu, 11 Jun 2015 09:36:17 +0000 [thread overview]
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D12628A0DB@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <557971FD02000078000837FE@mail.emea.novell.com>
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: Thursday, June 11, 2015 5:33 PM
>
> >>> On 11.06.15 at 10:38, <kevin.tian@intel.com> wrote:
> >> From: Boris Ostrovsky [mailto:boris.ostrovsky@oracle.com]
> >> Sent: Wednesday, June 10, 2015 11:04 PM
> >>
> >> Add support for handling PMU interrupts for PV(H) guests.
> >>
> >> VPMU for the interrupted VCPU is unloaded until the guest issues
> > XENPMU_flush
> >> hypercall. This allows the guest to access PMU MSR values that are stored in
> >> VPMU context which is shared between hypervisor and domain, thus avoiding
> >> traps to hypervisor.
> >>
> >> Since the interrupt handler may now force VPMU context save (i.e. set
> >> VPMU_CONTEXT_SAVE flag) we need to make changes to amd_vpmu_save() which
> >> until now expected this flag to be set only when the counters were stopped.
> >>
> >> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> >> Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> >
> > I may need more time to understand the whole interrupt stuff for PV(H)
> > guest. But regarding to VMX specific changes I think they are clear:
> >
> > Signed-off-by: Kevin Tian <kevin.tian@intel.com>
>
> I don't think you really meant S-o-b here?
>
My bad when doing batch reviews.
Acked-by: Kevin Tian <kevin.tian@intel.com>
Thanks
Kevin
next prev parent reply other threads:[~2015-06-11 9:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 15:04 [PATCH v24 00/15] x86/PMU: Xen PMU PV(H) support Boris Ostrovsky
2015-06-10 15:04 ` [PATCH v24 01/15] common/symbols: Export hypervisor symbols to privileged guest Boris Ostrovsky
2015-06-10 15:04 ` [PATCH v24 02/15] x86/VPMU: Add public xenpmu.h Boris Ostrovsky
2015-06-15 14:59 ` Jan Beulich
2015-06-10 15:04 ` [PATCH v24 03/15] x86/VPMU: Make vpmu not HVM-specific Boris Ostrovsky
2015-06-10 15:04 ` [PATCH v24 04/15] x86/VPMU: Interface for setting PMU mode and flags Boris Ostrovsky
2015-06-11 8:17 ` Tian, Kevin
2015-06-11 14:54 ` Boris Ostrovsky
2015-06-11 15:04 ` Jan Beulich
2015-06-11 15:14 ` Boris Ostrovsky
2015-06-11 16:09 ` Jan Beulich
2015-06-12 3:23 ` Tian, Kevin
2015-06-12 13:58 ` Boris Ostrovsky
2015-06-10 15:04 ` [PATCH v24 05/15] x86/VPMU: Initialize VPMUs with __initcall Boris Ostrovsky
2015-06-10 15:04 ` [PATCH v24 06/15] x86/VPMU: Initialize PMU for PV(H) guests Boris Ostrovsky
2015-06-11 8:21 ` Tian, Kevin
2015-06-10 15:04 ` [PATCH v24 07/15] x86/VPMU: Save VPMU state for PV guests during context switch Boris Ostrovsky
2015-06-10 15:04 ` [PATCH v24 08/15] x86/VPMU: When handling MSR accesses, leave fault injection to callers Boris Ostrovsky
2015-06-15 15:06 ` Jan Beulich
2015-06-15 16:23 ` Boris Ostrovsky
2015-06-10 15:04 ` [PATCH v24 09/15] x86/VPMU: Add support for PMU register handling on PV guests Boris Ostrovsky
2015-06-10 15:04 ` [PATCH v24 10/15] x86/VPMU: Use pre-computed masks when checking validity of MSRs Boris Ostrovsky
2015-06-11 8:22 ` Tian, Kevin
2015-06-10 15:04 ` [PATCH v24 11/15] VPMU/AMD: Check MSR values before writing to hardware Boris Ostrovsky
2015-06-10 15:04 ` [PATCH v24 12/15] x86/VPMU: Handle PMU interrupts for PV(H) guests Boris Ostrovsky
2015-06-11 8:38 ` Tian, Kevin
2015-06-11 9:33 ` Jan Beulich
2015-06-11 9:36 ` Tian, Kevin [this message]
2015-06-15 15:50 ` Jan Beulich
2015-06-15 17:17 ` Boris Ostrovsky
2015-06-16 7:45 ` Jan Beulich
2015-06-16 14:14 ` Boris Ostrovsky
2015-06-10 15:04 ` [PATCH v24 13/15] x86/VPMU: Merge vpmu_rdmsr and vpmu_wrmsr Boris Ostrovsky
2015-06-10 15:04 ` [PATCH v24 14/15] x86/VPMU: Add privileged PMU mode Boris Ostrovsky
2015-06-10 15:04 ` [PATCH v24 15/15] x86/VPMU: Move VPMU files up from hvm/ directory Boris Ostrovsky
2015-06-11 8:39 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AADFC41AFE54684AB9EE6CBC0274A5D12628A0DB@SHSMSX101.ccr.corp.intel.com \
--to=kevin.tian@intel.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=dietmar.hahn@ts.fujitsu.com \
--cc=jun.nakajima@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.