From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tian, Kevin" <kevin.tian@intel.com>
Subject: Re: [PATCH v2 2/2] x86/hvm: add support for pcommit
	instruction
Date: Tue, 5 Jan 2016 07:45:21 +0000
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D15F764574@SHSMSX101.ccr.corp.intel.com>
References: <1451476139-22148-1-git-send-email-haozhong.zhang@intel.com>
	<1451476139-22148-3-git-send-email-haozhong.zhang@intel.com>
	<AADFC41AFE54684AB9EE6CBC0274A5D15F7644A6@SHSMSX101.ccr.corp.intel.com>
	<20160105071500.GA2440@hz-desktop.sh.intel.com>
	<AADFC41AFE54684AB9EE6CBC0274A5D15F764510@SHSMSX101.ccr.corp.intel.com>
	<20160105073259.GB2440@hz-desktop.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20160105073259.GB2440@hz-desktop.sh.intel.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Zhang, Haozhong" <haozhong.zhang@intel.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, "Nakajima,
	Jun" <jun.nakajima@intel.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Jan Beulich <jbeulich@suse.com>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

> From: Zhang, Haozhong
> Sent: Tuesday, January 05, 2016 3:33 PM
> 
> On 01/05/16 15:19, Tian, Kevin wrote:
> > > From: Zhang, Haozhong
> > > Sent: Tuesday, January 05, 2016 3:15 PM
> > >
> > > On 01/05/16 15:08, Tian, Kevin wrote:
> > > > > From: Zhang, Haozhong
> > > > > Sent: Wednesday, December 30, 2015 7:49 PM
> > > > >
> > > > > Pass PCOMMIT CPU feature into HMV domain. Currently, we do not intercept
> > > > > pcommit instruction for L1 guest, and allow L1 to intercept pcommit
> > > > > instruction for L2 guest.
> > > >
> > > > Could you elaborate why different policies are used for L1/L2? And better
> > > > add a comment in code (at least for vvmx) to describe the intention.
> > > >
> > > > Thanks
> > > > Kevin
> > >
> > > The intention is that we completely expose pcommit (both the
> > > instruction and VMEXIT caused by pcommit) to L1.
> > >
> > > Haozhong
> >
> > My question is why pcommit can't not be directly in L2 w/o interception?
> >
> > Thanks
> > Kevin
> >
> 
> Isn't it because L1 hypervisor may decide to intercept L2 pcommit?
> 

Well, I misunderstood the original statement and actual patch w/ the
impression that pcommit interception is always enabled for L2 guest.
Now I see that itt's just the intrinsic result when we don't intercept 
L1 pcommit (either a L1 guest or L1 hypervisor). So,

Acked-by: Kevin Tian <kevin.tian@intel.com>

Thanks
Kevin