From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tian, Kevin" <kevin.tian@intel.com>
Subject: Re: [PATCHv6 2/2] x86/ept: defer the invalidation until
 the p2m lock is released
Date: Tue, 2 Feb 2016 07:58:32 +0000
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D15F7941A2@SHSMSX101.ccr.corp.intel.com>
References: <1450446634-8762-1-git-send-email-david.vrabel@citrix.com>
	<1450446634-8762-3-git-send-email-david.vrabel@citrix.com>
	<AADFC41AFE54684AB9EE6CBC0274A5D15F750BAD@SHSMSX101.ccr.corp.intel.com>
	<56AF70A1.9060503@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <kevin.tian@intel.com>) id 1aQVrD-0001JL-83
	for xen-devel@lists.xenproject.org; Tue, 02 Feb 2016 07:58:39 +0000
In-Reply-To: <56AF70A1.9060503@citrix.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Tim Deegan <tim@xen.org>, "Nakajima,
	Jun" <jun.nakajima@intel.com>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

> From: David Vrabel [mailto:david.vrabel@citrix.com]
> Sent: Monday, February 01, 2016 10:50 PM
> 
> On 20/12/15 06:56, Tian, Kevin wrote:
> >> From: David Vrabel [mailto:david.vrabel@citrix.com]
> >> Sent: Friday, December 18, 2015 9:51 PM
> >>
> >> Holding the p2m lock while calling ept_sync_domain() is very expensive
> >> since it does a on_selected_cpus() call.  IPIs on many socket machines
> >> can be very slows and on_selected_cpus() is serialized.
> >>
> >> It is safe to defer the invalidate until the p2m lock is released
> >> except for two cases:
> >>
> >> 1. When freeing a page table page (since partial translations may be
> >>    cached).
> >> 2. When reclaiming a zero page as part of PoD.
> >>
> >> For these cases, add p2m_tlb_flush_sync() calls which will immediately
> >> perform the invalidate before the page is freed or reclaimed.
> >>
> >> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> >
> > In a quick glimpse the patch is OK. Will find a time to think about it more
> > carefully since this part is tricky (also allow others to comment before
> > my ack in EPT part).
> 
> Ping?  Did you get more time to think about this patch?
> 

Sorry for delay on this. I saw you've sent out a v7 on this. Queued to
be reviewed tomorrow.

Thanks
Kevin