From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tian, Kevin" Subject: RE: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU. Date: Wed, 17 Feb 2016 10:47:31 +0000 Message-ID: References: <20160217041743.GA7903@nvidia.com> <20160217053742.GA8839@nvidia.com> <20160217072610.GA9416@nvidia.com> <20160217075448.GC9416@nvidia.com> <20160217093430.GA11166@nvidia.com> <20160217103409.GB11166@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "Ruan, Shuai" , "Song, Jike" , "kvm@vger.kernel.org" , Kirti Wankhede , qemu-devel , Alex Williamson , Gerd Hoffmann , "Paolo Bonzini" , "Lv, Zhiyuan" , "Paul Durrant (Paul.Durrant@citrix.com)" , "Malcolm Crossley (malcolm.crossley@citrix.com)" To: Neo Jia Return-path: Received: from mga02.intel.com ([134.134.136.20]:23139 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933441AbcBQKrh convert rfc822-to-8bit (ORCPT ); Wed, 17 Feb 2016 05:47:37 -0500 In-Reply-To: <20160217103409.GB11166@nvidia.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: > From: Neo Jia [mailto:cjia@nvidia.com] > Sent: Wednesday, February 17, 2016 6:34 PM > > > > > Qemu is not a kernel component. And UUID is OPTIONAL for Qemu. > > > > KVM is the kernel component. It doesn't use UUID at all. the relation between > > UUID and VM is fully maintained in user space. > > Hold on ... we are talking about the vgpu.ko not KVM right? You said UUID is a general way to represent an object. VM is an object. There is UUID associated with a VM. But UUID is not recorded in the kernel KVM. It's a good reference to our design on vgpu object. If one thing can be done in user space, then better not involve kernel side. > > > > > > This is why I think we should use this UUID as a generic management interface, > > > and we shouldn't have anything optional. > > > > > > > I don't buy-in this argument. I always think kernel design should provide > > enough flexibility, instead of assuming user space behavior. > > > > I think you are using the wrong terms here. Flexibility doesn't apply here. What > we are trying to achieve here is to have a generic interface for upper layer > software to manage vgpu device. Even Qemu doesn't make UUID as mandatory. It's just an optional parameter. I'm not sure why you insist UUID mandatory for vGPU here. > > > Let me also add some Citrix friends. See how they feel about the necessity of > > having UUID in vgpu name. > > Sorry? Paul/Malcolm are experts in Citrix XenServer. So I think they may give some suggestions from their angle. :-) Thanks Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVze2-0001s4-01 for qemu-devel@nongnu.org; Wed, 17 Feb 2016 05:47:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVzdx-0004fr-L0 for qemu-devel@nongnu.org; Wed, 17 Feb 2016 05:47:41 -0500 Received: from mga02.intel.com ([134.134.136.20]:35644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVzdx-0004ff-CT for qemu-devel@nongnu.org; Wed, 17 Feb 2016 05:47:37 -0500 From: "Tian, Kevin" Date: Wed, 17 Feb 2016 10:47:31 +0000 Message-ID: References: <20160217041743.GA7903@nvidia.com> <20160217053742.GA8839@nvidia.com> <20160217072610.GA9416@nvidia.com> <20160217075448.GC9416@nvidia.com> <20160217093430.GA11166@nvidia.com> <20160217103409.GB11166@nvidia.com> In-Reply-To: <20160217103409.GB11166@nvidia.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Neo Jia Cc: "Ruan, Shuai" , "Song, Jike" , "kvm@vger.kernel.org" , Kirti Wankhede , qemu-devel , Alex Williamson , "Paul Durrant (Paul.Durrant@citrix.com)" , Gerd Hoffmann , Paolo Bonzini , "Malcolm Crossley (malcolm.crossley@citrix.com)" , "Lv, Zhiyuan" > From: Neo Jia [mailto:cjia@nvidia.com] > Sent: Wednesday, February 17, 2016 6:34 PM >=20 > > > > Qemu is not a kernel component. And UUID is OPTIONAL for Qemu. > > > > KVM is the kernel component. It doesn't use UUID at all. the relation b= etween > > UUID and VM is fully maintained in user space. >=20 > Hold on ... we are talking about the vgpu.ko not KVM right? You said UUID is a general way to represent an object. VM is an object. There is UUID associated with a VM. But UUID is not recorded in the kernel KVM. It's a good reference to our design on vgpu object. If one thing can be done in user space, then better not involve kernel side. > > > > > > This is why I think we should use this UUID as a generic management i= nterface, > > > and we shouldn't have anything optional. > > > > > > > I don't buy-in this argument. I always think kernel design should provi= de > > enough flexibility, instead of assuming user space behavior. > > >=20 > I think you are using the wrong terms here. Flexibility doesn't apply her= e. What > we are trying to achieve here is to have a generic interface for upper la= yer > software to manage vgpu device. Even Qemu doesn't make UUID as mandatory. It's just an optional parameter. I'm not sure why you insist UUID mandatory for vGPU here. >=20 > > Let me also add some Citrix friends. See how they feel about the necess= ity of > > having UUID in vgpu name. >=20 > Sorry? Paul/Malcolm are experts in Citrix XenServer. So I think they may give some suggestions from their angle. :-) Thanks Kevin