From: "Tian, Kevin" <kevin.tian@intel.com>
To: Euan Harris <euan.harris@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"Nakajima, Jun" <jun.nakajima@intel.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/2] nested vmx: Validate host VMX MSRs before accessing them
Date: Sun, 12 Jun 2016 07:39:04 +0000 [thread overview]
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D15F8A4D1B@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20160609132032.GA2458@citrix.com>
> From: Euan Harris [mailto:euan.harris@citrix.com]
> Sent: Thursday, June 09, 2016 9:21 PM
>
> On Thu, Jun 09, 2016 at 06:47:55AM -0600, Jan Beulich wrote:
> > > /*
> > > - * Those MSRs are available only when bit 55 of
> > > - * MSR_IA32_VMX_BASIC is set.
> > > + * These MSRs are only available when flags in other MSRs are set.
> > > + * These prerequisites are listed in the Intel 64 and IA-32
> > > + * Architectures Software Developer’s Manual, Vol 3, Appendix A.
> > > */
> > > - switch ( msr )
> > > - {
> > > + switch ( msr ) { case MSR_IA32_VMX_PROCBASED_CTLS2:
> >
> > I hope you didn't really mean to produce a garbled line like this?
> > With proper formatting restored
> > Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
> Oops, definitely not. I think this happened when I was re-wrapping
> the comment above - !}fmt went further than I intended.
>
Acked-by: Kevin Tian <kevin.tian@intel.com>, with above fixed.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-12 7:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 10:14 [PATCH 0/2] Validate host VMX MSRs before accessing them Euan Harris
2016-06-09 10:14 ` [PATCH 1/2] nested vmx: Fix comment typos in nvmx_msr_read_intercept() Euan Harris
2016-06-12 7:37 ` Tian, Kevin
2016-06-09 10:14 ` [PATCH 2/2] nested vmx: Validate host VMX MSRs before accessing them Euan Harris
2016-06-09 12:47 ` Jan Beulich
2016-06-09 13:20 ` Euan Harris
2016-06-12 7:39 ` Tian, Kevin [this message]
2016-06-13 12:13 ` [PATCH 0/2] " Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AADFC41AFE54684AB9EE6CBC0274A5D15F8A4D1B@SHSMSX101.ccr.corp.intel.com \
--to=kevin.tian@intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=euan.harris@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.